mbox series

[V2,00/14] arm64: dts: ti: Fix up references to phandles

Message ID 20230606182220.3661956-1-nm@ti.com (mailing list archive)
Headers show
Series arm64: dts: ti: Fix up references to phandles | expand

Message

Nishanth Menon June 6, 2023, 6:22 p.m. UTC
When referring to array of phandles, using <> to separate the array
entries is better notation as it makes potential errors with phandle and
cell arguments easier to catch. Fix the outliers to be consistent with
the rest of the usage.

This set was caught by using: git grep '\s&' arch/arm64/boot/dts/ti/
and manually going through the list.

Changes since V1:
* Few formatting changes included to keep consistent
* Picked a Reviewed-by
* ai64 gets a few fixes as part of the cleanup (patches #3, #4)
* Picked up Reviewed-by from Jan.

V1: https://lore.kernel.org/all/20230601152636.858553-1-nm@ti.com/

Nishanth Menon (14):
  arm64: dts: ti: k3-j721e-sk: Fixup reference to phandles array
  arm64: dts: ti: k3-j721e-som-p0/common-proc-board: Fixup reference to
    phandles array
  arm64: dts: ti: k3-j721e-beagleboneai64: Move camera gpio pinctrl to
    gpio node
  arm64: dts: ti: k3-j721e-beagleboneai64: Move eeprom WP gpio pinctrl
    to eeprom node
  arm64: dts: ti: k3-j721e-beagleboneai64: Fixup reference to phandles
    array
  arm64: dts: ti: k3-am642-phyboard-electra-rdk: Fixup reference to
    phandles array
  arm64: dts: ti: k3-j7200-som/common-proc-board: Fixup reference to
    phandles array
  arm64: dts: ti: k3-j721s2-common-proc-board: Fixup reference to
    phandles array
  arm64: dts: ti: k3-am625-sk: Fixup reference to phandles array
  arm64: dts: ti: k3-am64-evm: Fixup reference to phandles array
  arm64: dts: ti: k3-am64-sk: Fixup reference to phandles array
  arm64: dts: ti: k3-am65-iot*: Fixup reference to phandles array
  arm64: dts: ti: k3-am654-base-board: Fixup reference to phandles array
  arm64: dts: ti: k3-am68-sk-base-board: Fixup reference to phandles
    array

 arch/arm64/boot/dts/ti/k3-am625-sk.dts        |  3 +-
 arch/arm64/boot/dts/ti/k3-am642-evm.dts       | 11 +++---
 .../dts/ti/k3-am642-phyboard-electra-rdk.dts  |  2 +-
 arch/arm64/boot/dts/ti/k3-am642-sk.dts        | 11 +++---
 .../boot/dts/ti/k3-am65-iot2050-common.dtsi   | 17 +++++----
 .../arm64/boot/dts/ti/k3-am654-base-board.dts |  4 +--
 .../dts/ti/k3-am6548-iot2050-advanced-m2.dts  | 18 +++++-----
 .../boot/dts/ti/k3-am68-sk-base-board.dts     |  2 +-
 .../dts/ti/k3-j7200-common-proc-board.dts     |  2 +-
 arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi   |  8 ++---
 .../boot/dts/ti/k3-j721e-beagleboneai64.dts   | 36 +++++++++++--------
 .../dts/ti/k3-j721e-common-proc-board.dts     |  4 +--
 arch/arm64/boot/dts/ti/k3-j721e-sk.dts        | 20 +++++------
 arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi   | 18 +++++-----
 .../dts/ti/k3-j721s2-common-proc-board.dts    |  2 +-
 15 files changed, 80 insertions(+), 78 deletions(-)

Comments

Kumar, Udit June 7, 2023, 7:48 a.m. UTC | #1
Thanks Nishanth

On 6/6/2023 11:52 PM, Nishanth Menon wrote:
> When referring to array of phandles, using <> to separate the array
> entries is better notation as it makes potential errors with phandle and
> cell arguments easier to catch. Fix the outliers to be consistent with
> the rest of the usage.
>
> This set was caught by using: git grep '\s&' arch/arm64/boot/dts/ti/
> and manually going through the list.
>
> Changes since V1:
> * Few formatting changes included to keep consistent
> * Picked a Reviewed-by
> * ai64 gets a few fixes as part of the cleanup (patches #3, #4)
> * Picked up Reviewed-by from Jan.
>
> V1:https://lore.kernel.org/all/20230601152636.858553-1-nm@ti.com/
>
> Nishanth Menon (14):
>    arm64: dts: ti: k3-j721e-sk: Fixup reference to phandles array
>    arm64: dts: ti: k3-j721e-som-p0/common-proc-board: Fixup reference to
>      phandles array
>    arm64: dts: ti: k3-j721e-beagleboneai64: Move camera gpio pinctrl to
>      gpio node
>    arm64: dts: ti: k3-j721e-beagleboneai64: Move eeprom WP gpio pinctrl
>      to eeprom node
>    arm64: dts: ti: k3-j721e-beagleboneai64: Fixup reference to phandles
>      array
>    arm64: dts: ti: k3-am642-phyboard-electra-rdk: Fixup reference to
>      phandles array
>    arm64: dts: ti: k3-j7200-som/common-proc-board: Fixup reference to
>      phandles array
>    arm64: dts: ti: k3-j721s2-common-proc-board: Fixup reference to
>      phandles array
>    arm64: dts: ti: k3-am625-sk: Fixup reference to phandles array
>    arm64: dts: ti: k3-am64-evm: Fixup reference to phandles array
>    arm64: dts: ti: k3-am64-sk: Fixup reference to phandles array
>    arm64: dts: ti: k3-am65-iot*: Fixup reference to phandles array
>    arm64: dts: ti: k3-am654-base-board: Fixup reference to phandles array
>    arm64: dts: ti: k3-am68-sk-base-board: Fixup reference to phandles
>      array


Reviewed by : Udit Kumar <u-kumar1@ti.com>

>   arch/arm64/boot/dts/ti/k3-am625-sk.dts        |  3 +-
>   arch/arm64/boot/dts/ti/k3-am642-evm.dts       | 11 +++---
>   .../dts/ti/k3-am642-phyboard-electra-rdk.dts  |  2 +-
>   arch/arm64/boot/dts/ti/k3-am642-sk.dts        | 11 +++---
>   .../boot/dts/ti/k3-am65-iot2050-common.dtsi   | 17 +++++----
>   .../arm64/boot/dts/ti/k3-am654-base-board.dts |  4 +--
>   .../dts/ti/k3-am6548-iot2050-advanced-m2.dts  | 18 +++++-----
>   .../boot/dts/ti/k3-am68-sk-base-board.dts     |  2 +-
>   .../dts/ti/k3-j7200-common-proc-board.dts     |  2 +-
>   arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi   |  8 ++---
>   .../boot/dts/ti/k3-j721e-beagleboneai64.dts   | 36 +++++++++++--------
>   .../dts/ti/k3-j721e-common-proc-board.dts     |  4 +--
>   arch/arm64/boot/dts/ti/k3-j721e-sk.dts        | 20 +++++------
>   arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi   | 18 +++++-----
>   .../dts/ti/k3-j721s2-common-proc-board.dts    |  2 +-
>   15 files changed, 80 insertions(+), 78 deletions(-)
>
Vignesh Raghavendra June 15, 2023, 1:27 p.m. UTC | #2
Hi Nishanth Menon,

On Tue, 06 Jun 2023 13:22:06 -0500, Nishanth Menon wrote:
> When referring to array of phandles, using <> to separate the array
> entries is better notation as it makes potential errors with phandle and
> cell arguments easier to catch. Fix the outliers to be consistent with
> the rest of the usage.
> 
> This set was caught by using: git grep '\s&' arch/arm64/boot/dts/ti/
> and manually going through the list.
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[01/14] arm64: dts: ti: k3-j721e-sk: Fixup reference to phandles array
        commit: 12bf41da5c3a02a9a6f8059404ba97c39a8f1852
[02/14] arm64: dts: ti: k3-j721e-som-p0/common-proc-board: Fixup reference to phandles array
        commit: 7335c987de3e4741908a032914bd3f2979898375
[03/14] arm64: dts: ti: k3-j721e-beagleboneai64: Move camera gpio pinctrl to gpio node
        commit: d528c29fa7526adf7074fb166b99df7d5fd90670
[04/14] arm64: dts: ti: k3-j721e-beagleboneai64: Move eeprom WP gpio pinctrl to eeprom node
        commit: 88875d4c70cabcb509e9836086fdf2064ef89468
[05/14] arm64: dts: ti: k3-j721e-beagleboneai64: Fixup reference to phandles array
        commit: 4a701c01e7ff96966fcf2cf9df0d3dd851197317
[06/14] arm64: dts: ti: k3-am642-phyboard-electra-rdk: Fixup reference to phandles array
        commit: 56ccd4b1eb52e153d557c7c7ae19f849e5d5c2e1
[07/14] arm64: dts: ti: k3-j7200-som/common-proc-board: Fixup reference to phandles array
        commit: a6550e2547acbcd7b01ea26d447a437140df7c43
[08/14] arm64: dts: ti: k3-j721s2-common-proc-board: Fixup reference to phandles array
        commit: 6a2baa853500d1bbe986f29aacce4a0c859bf017
[09/14] arm64: dts: ti: k3-am625-sk: Fixup reference to phandles array
        commit: 875aad10d219494bb0ef0880b1b4a33f99c98a13
[10/14] arm64: dts: ti: k3-am64-evm: Fixup reference to phandles array
        commit: bb867df51d3b7f305222405c4e01373efc8866c7
[11/14] arm64: dts: ti: k3-am64-sk: Fixup reference to phandles array
        commit: 0e97d245633bffc0ae348c95f98a2af5b973811c
[12/14] arm64: dts: ti: k3-am65-iot*: Fixup reference to phandles array
        commit: f722090aeb70ca67b5f5a37a39a26fca29664dce
[13/14] arm64: dts: ti: k3-am654-base-board: Fixup reference to phandles array
        commit: 9da060be7491cc67323b8f4386ebc4524eba5970
[14/14] arm64: dts: ti: k3-am68-sk-base-board: Fixup reference to phandles array
        commit: 918ef215db22b18b75292b6e5bcb763ce27e0483

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh