From patchwork Mon Jun 26 08:58:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Puranjay Mohan X-Patchwork-Id: 13292530 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36244EB64D7 for ; Mon, 26 Jun 2023 08:58:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=8R99FUQhNal2Y/0rh5QSw3KgmliqRQn5/e17hqwLY5o=; b=EpxrhfYWNWsg8H wcjOS3uCBG62A/qKWBfUgejkkQIYsdL38LGYM0Qx3XbZUz/oUQgrgPjtU70XvkhjionPPMUlAZWOj l7HcTOCEDueZnz0wo7GMFpaKCv/0Hksa+o5CrWbH6dBshWhPkfzk+US1npo+ggNmn+/d11AXFXGeS qtHu0I/9+ysPIGyhOTMdSylNozFS2yps97varCtNR9nq5UEJ0yQTteVH1c6beEL2QR7Yo3vCyDzzT 5CHHmlstAIPS8Rogd/l6BIDOLA4V9Nbb4NeutwgZ2kZwO+wpihCv623mpJnrOpNe9YvxCSfLWXHxY di8ZVGiHgnUb5pHAwPRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qDi38-009gQ0-30; Mon, 26 Jun 2023 08:58:18 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qDi35-009gOL-1F for linux-arm-kernel@lists.infradead.org; Mon, 26 Jun 2023 08:58:16 +0000 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-313f18f5295so881957f8f.3 for ; Mon, 26 Jun 2023 01:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687769893; x=1690361893; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BW6tD5LOYWEQLPeqm6MtP4jYXlwBj96utCaHDwz4Kxc=; b=RRjPJ80u+sy8/xjuKuQc1tJhhq1uyD5CsNrRA39bWR4FyyGMA6XStFH2P76h/nR2En pDzDxVoXa3N0uhye3NfPf/6DBgfySBdosx9Nun49hKlpYIyQo1NxoHt7lb1K2bqioMRQ 4UYaZ35+n1WxcQ3ud8ms034GRB7/wWyC28wmvzKGFZzh1P/nY+xm+FSTSkz3GYdGWFRU BUyNcBcwdFza+fLXV/WNU/bToNvfxkvqTCKb/GX6Hs5FHTI++jdta7sRc3NVyJQPPdzx Zmj+fUBwcrWPeIo5IFlJwWS+XgcY88SF3holQ6YmG2fTZVafwAfz+vgjRE8Suw7464L4 HUXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687769893; x=1690361893; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BW6tD5LOYWEQLPeqm6MtP4jYXlwBj96utCaHDwz4Kxc=; b=Yr1VgdNVzzZ6XiNGepwB0hYTCjNA3CjaEiJh0W6z1gLaAYTWQo4RrfEkF9vIMa2oQl zGWuTcb5FI5hW0El8Rxlv+Otr5HkqteeND5cip39XkuHp6AeTXL4fAUs1s3Hr/ZIl547 KV0fVaXg5A3Ty1gt1HA8bxt0YX1GQqXFJxH2zAmELC4b5yk6/Fv/0HoaCaZHaLInMY98 E8QSaul8DCEoGNT9BM8lNd1nM/6wKFt2R4nFqcXsFg+6MiWe+2/Ms4Ukz/AChIMQuLOo 7fzpPzXYlmaunaupjYMRTfgWMT1fDExErH8GCJQTXk/TOzs+TEcmXmjLwB6ijSsINplC D6gA== X-Gm-Message-State: AC+VfDxjLoSlmEHk3FZBuA3OglpOy9O069thxDVulpGLyEtHVPJHSfGx +zM35SY2Jeu4YdIqtRLrO14= X-Google-Smtp-Source: ACHHUZ6tVXS7MOEvgK570FibtSg2oP1aHFaBodfNSREPRFB2rcVLuJ1Ld7L87ssLJZfF8OX/o4adAQ== X-Received: by 2002:a05:600c:284:b0:3fa:7dfc:411f with SMTP id 4-20020a05600c028400b003fa7dfc411fmr7082596wmk.23.1687769892795; Mon, 26 Jun 2023 01:58:12 -0700 (PDT) Received: from ip-172-31-22-112.eu-west-1.compute.internal (ec2-34-242-96-229.eu-west-1.compute.amazonaws.com. [34.242.96.229]) by smtp.gmail.com with ESMTPSA id h10-20020a5d504a000000b00313e8dc7facsm4883533wrt.116.2023.06.26.01.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jun 2023 01:58:12 -0700 (PDT) From: Puranjay Mohan To: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com, bpf@vger.kernel.org, kpsingh@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: puranjay12@gmail.com Subject: [PATCH bpf-next v4 0/3] bpf, arm64: use BPF prog pack allocator in BPF JIT Date: Mon, 26 Jun 2023 08:58:08 +0000 Message-Id: <20230626085811.3192402-1-puranjay12@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230626_015815_426194_95760067 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org BPF programs currently consume a page each on ARM64. For systems with many BPF programs, this adds significant pressure to instruction TLB. High iTLB pressure usually causes slow down for the whole system. Song Liu introduced the BPF prog pack allocator[1] to mitigate the above issue. It packs multiple BPF programs into a single huge page. It is currently only enabled for the x86_64 BPF JIT. This patch series enables the BPF prog pack allocator for the ARM64 BPF JIT. ==================================================== Performance Analysis of prog pack allocator on ARM64 ==================================================== To test the performance of the BPF prog pack allocator on ARM64, a stresser tool[2] was built. This tool loads 8 BPF programs on the system and triggers 5 of them in an infinite loop by doing system calls. The runner script starts 20 instances of the above which loads 8*20=160 BPF programs on the system, 5*20=100 of which are being constantly triggered. In the above environment we try to build Python-3.8.4 and try to find different iTLB metrics for the compilation done by gcc-12.2.0. The source code[3] is configured with the following command: ./configure --enable-optimizations --with-ensurepip=install Then the runner script is executed with the following command: ./run.sh "perf stat -e ITLB_WALK,L1I_TLB,INST_RETIRED,iTLB-load-misses -a make -j32" This builds Python while 160 BPF programs are loaded and 100 are being constantly triggered and measures iTLB related metrics. The output of the above command is discussed below before and after enabling the BPF prog pack allocator. The tests were run on qemu-system-aarch64 with 32 cpus, 4G memory, -machine virt, -cpu host, and -enable-kvm. Results ------- Before enabling prog pack allocator: ------------------------------------ Performance counter stats for 'system wide': 333278635 ITLB_WALK 6762692976558 L1I_TLB 25359571423901 INST_RETIRED 15824054789 iTLB-load-misses 189.029769053 seconds time elapsed After enabling prog pack allocator: ----------------------------------- Performance counter stats for 'system wide': 190333544 ITLB_WALK 6712712386528 L1I_TLB 25278233304411 INST_RETIRED 5716757866 iTLB-load-misses 185.392650561 seconds time elapsed Improvements in metrics ----------------------- Compilation time ---> 1.92% faster iTLB-load-misses/Sec (Less is better) ---> 63.16% decrease ITLB_WALK/1000 INST_RETIRED (Less is better) ---> 42.71% decrease ITLB_Walk/L1I_TLB (Less is better) ---> 42.47% decrease [1] https://lore.kernel.org/bpf/20220204185742.271030-1-song@kernel.org/ [2] https://github.com/puranjaymohan/BPF-Allocator-Bench [3] https://www.python.org/ftp/python/3.8.4/Python-3.8.4.tgz Chanes in V3 => V4: Changes only in 3rd patch 1. Fix the I-cache maintenance: Clean the data cache and invalidate the i-Cache only *after* the instructions have been copied to the ROX region. Chanes in V2 => V3: Changes only in 3rd patch 1. Set prog = orig_prog; in the failure path of bpf_jit_binary_pack_finalize() call. 2. Add comments explaining the usage of the offsets in the exception table. Changes in v1 => v2: 1. Make the naming consistent in the 3rd patch: ro_image and image ro_header and header ro_image_ptr and image_ptr 2. Use names dst/src in place of addr/opcode in second patch. 3. Add Acked-by: Song Liu in 1st and 2nd patch. Puranjay Mohan (3): bpf: make bpf_prog_pack allocator portable arm64: patching: Add aarch64_insn_copy() bpf, arm64: use bpf_jit_binary_pack_alloc arch/arm64/include/asm/patching.h | 1 + arch/arm64/kernel/patching.c | 39 ++++++++ arch/arm64/net/bpf_jit_comp.c | 145 +++++++++++++++++++++++++----- kernel/bpf/core.c | 8 +- 4 files changed, 165 insertions(+), 28 deletions(-) Acked-by: Florent Revest