From patchwork Thu Jul 27 14:14:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexandre Ghiti X-Patchwork-Id: 13330152 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C720C001E0 for ; Thu, 27 Jul 2023 14:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=/hFFILgUAqouHqJcD8QcA/vHFxDaOnf0QpKHVo1+YtU=; b=2TCR5t0zhbO8C5 Kd7rFYW/4zGLh7qSkBKkJUuoau7dpQZZZIIgqs9szPmV8MOH5W4v922NYFLMKy1hZwEsSHqOTtob8 sv5DuiVlCTjYPBnjWEDkAjg/+zFdKPd4unnnbGgCSYDOJ3NBcekGmpksZmEWMqpPPGgUrsognAGyI cxPHXw9L/woImQznG49cQA61o89sed33a55c5gGtz3yfQDfDRVfXMgwYlcAg0R6jLbjzBB0ErrXg8 Pro9QYsIE0lIfAuBRYofHgC19l9bcaKosNRcFX5AHWNqVsD2TSJirUTB2TomgQvFMw9Ay9bEOuj07 JlmScaPf/wx01KHUvthQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qP1lG-00F2TF-1D; Thu, 27 Jul 2023 14:14:38 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qP1lC-00F2Oo-1V for linux-arm-kernel@lists.infradead.org; Thu, 27 Jul 2023 14:14:36 +0000 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3144098df56so1080488f8f.2 for ; Thu, 27 Jul 2023 07:14:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1690467271; x=1691072071; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eRw/cUGu8fcnPxw+KMMOjGF5bTHqXAR/GW2x87Rw3dw=; b=dA/0oC16Y7iRuAHbZ0n7kmQyHW2sbVHip1jppF98hz846ZU9Ac3FhBcMVz1BN7wQAv n6rWRQ9Oe/fpRKluovb17FotrSk27Fp/vXu/uvZowB+D0EMCB+ibgu2gj6mF81VA7/WM gOikeA2J5GodOO0o83+Kwf2Khyer8Lcz0yHNDW37sBfk+cu+uPKySkuB1yfUjHIcMSPp zYGcXq6fQS9j6kK8kEGVng0wnc50QyO+AhyYuqVhXNmu2gZAldWORTGZeta+7HAmUs31 rNw+GmtcbI9m7Aj0Hz+UixmbpoBVbFTDVaDk00Je86nfD7NR8HYXWQT73Fij3pgc0Eaa lVSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690467271; x=1691072071; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eRw/cUGu8fcnPxw+KMMOjGF5bTHqXAR/GW2x87Rw3dw=; b=Fb3R6NBvQ/aqE/DU9GaV0lcXg3tdNf2AxZymSNrj6ObnIXdit47UG+zan1SVQpe44o DnFWNfSqb/3GdSqthlphePKboVgVFBYDfpOky8VfdhL0AhDAMWvEEAzrhs2YeCWONw7U 7wYm3d1qTHL2ea1l90BoDAkXcw3nML+eGcNJocTcsblS1HpTy0MYBGV9XqVPSSgkFtuR Yqu8gm3RK5/BgEHvroeaTMljgbV4+mhIKP0r0ketI+3EneKrPNwhajJBbueckfs4LTRP 2SL1PAuluyCqoIaT8OXlCGguat7YXN9MOBq8EotjzZVRGSjDoFDF9WUgjBaCKGRcaugK FAPw== X-Gm-Message-State: ABy/qLae+ZmB9KAAiT4LWsD9oW+5+mLqzDzHBcTMWH6dUqSKb+5x+D1q d4S9DkUAP4YMjKpDEBxXVslHkg== X-Google-Smtp-Source: APBJJlE4sSE0D9stukeJcl06BIhweZAvV/Wivm9L17pK3nhJzWm3GrFSQ3BMSkamty6LskMNEBrLcw== X-Received: by 2002:adf:de09:0:b0:315:96ca:dcab with SMTP id b9-20020adfde09000000b0031596cadcabmr1607584wrm.35.1690467271509; Thu, 27 Jul 2023 07:14:31 -0700 (PDT) Received: from alex-rivos.home (amontpellier-656-1-456-62.w92-145.abo.wanadoo.fr. [92.145.124.62]) by smtp.gmail.com with ESMTPSA id l15-20020a5d674f000000b0030ae3a6be4asm2193853wrw.72.2023.07.27.07.14.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jul 2023 07:14:31 -0700 (PDT) From: Alexandre Ghiti To: Jonathan Corbet , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Paul Walmsley , Palmer Dabbelt , Albert Ou , Atish Patra , Anup Patel , Will Deacon , Rob Herring , Andrew Jones , =?utf-8?q?R=C3=A9mi_Denis-Courmont?= , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: Alexandre Ghiti Subject: [PATCH v4 00/10] riscv: Allow userspace to directly access perf counters Date: Thu, 27 Jul 2023 16:14:18 +0200 Message-Id: <20230727141428.962286-1-alexghiti@rivosinc.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230727_071434_718490_BE6EB043 X-CRM114-Status: GOOD ( 18.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org riscv used to allow direct access to cycle/time/instret counters, bypassing the perf framework, this patchset intends to allow the user to mmap any counter when accessed through perf. **Important**: The default mode is now user access through perf only, not the legacy so some applications will break. However, we introduce a sysctl perf_user_access like arm64 does, which will allow to switch to the legacy mode described above. This version needs openSBI v1.3 *and* a kernel fix that went upstream lately (https://lore.kernel.org/lkml/20230616114831.3186980-1-maz@kernel.org/T/). base-commit-tag: v6.5-rc1 Changes in v5: - Fix typo from Atish - Add RB from Atish and Andrew - Improve cover letter and patch 7 commit log to explain why we made the choice to break userspace for security reasons, thanks Atish and Rémi - Rebase on top of v6.5-rc1 Changes in v4: - Fixed some nits in riscv_pmu_sbi.c thanks to Andrew - Fixed the documentation thanks to Andrew - Added RB from Andrew \o/ Changes in v3: - patch 1 now contains the ref to the faulty commit (no Fixes tag as it is only a comment), as Andrew suggested - Removed RISCV_PMU_LEGACY_TIME from patch 3, as Andrew suggested - Rename RISCV_PMU_PDEV_NAME to "riscv-pmu-sbi", patch4 is just cosmetic now, as Andrew suggested - Removed a few useless (and wrong) comments, as Andrew suggested - Simplify arch_perf_update_userpage code, as Andrew suggested - Documentation now mentions that time CSR is *always* accessible, whatever the mode, as suggested by Andrew - Removed CYCLEH reference and add TODO for rv32 support, as suggested by Atish - Do not rename the pmu instance as Atish suggested - Set pmc_width only if rdpmc is enabled and CONFIG_RISCV_PMU is set and the event is a hw event - Move arch_perf_update_userpage https://lore.kernel.org/lkml/20230616114831.3186980-1-maz@kernel.org/T/ - **Switch to user mode access by default** Changes in v2: - Split into smaller patches, way better! - Add RB from Conor - Simplify the way we checked riscv architecture - Fix race mmap and other thread running on other cpus - Use hwc when available - Set all userspace access flags in event_init, too cumbersome to handle sysctl changes - Fix arch_perf_update_userpage for pmu other than riscv-pmu by renaming pmu driver - Fixed kernel test robot build error - Fixed documentation (Andrew and Bagas) - perf testsuite passes mmap tests in all 3 modes Alexandre Ghiti (10): perf: Fix wrong comment about default event_idx include: riscv: Fix wrong include guard in riscv_pmu.h riscv: Make legacy counter enum match the HW numbering drivers: perf: Rename riscv pmu sbi driver riscv: Prepare for user-space perf event mmap support drivers: perf: Implement perf event mmap support in the legacy backend drivers: perf: Implement perf event mmap support in the SBI backend Documentation: admin-guide: Add riscv sysctl_perf_user_access tools: lib: perf: Implement riscv mmap support perf: tests: Adapt mmap-basic.c for riscv Documentation/admin-guide/sysctl/kernel.rst | 27 ++- drivers/perf/riscv_pmu.c | 113 +++++++++++ drivers/perf/riscv_pmu_legacy.c | 28 ++- drivers/perf/riscv_pmu_sbi.c | 196 +++++++++++++++++++- include/linux/perf/riscv_pmu.h | 12 +- include/linux/perf_event.h | 3 +- tools/lib/perf/mmap.c | 65 +++++++ tools/perf/tests/mmap-basic.c | 4 +- 8 files changed, 428 insertions(+), 20 deletions(-)