From patchwork Mon Aug 28 06:45:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13367611 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51861C71153 for ; Mon, 28 Aug 2023 06:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=mPFRIya6bR9iNZF/6Cw5p0R2UkOWv4zvojNtSuDCMIw=; b=Y8MCgCX+7FFq+G xFwPKuHWA0JdLN/GWuT+efmNDsSbyW+coSHFHrpUpqZyYcpbTGRPPgjBxHW6pOrDYyWi9ajjroAdl shEffI1u83OZEG8vvST2nz8+jG3z9NLlsuSTedggCQ3w/NvwPkxRAuKTtX4g04+hc6vkri4zipIdd 0oKgJbFYN7FZNkOD+ToqsZ8vNcL/CC1uNyVIqNKmqChbfrhNivqGcvc79HCyo01jxGNwArDgy/HDH RftZ+MwuD7uSXji97Chkt5wQfA5Lq/cvurBEhMz7p+NFDvFJ0TehC5WjYJPKl2kk16VP/MIT50O8B l0J6fBrZUVlH4uaxH56g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qaW0o-008zzP-31; Mon, 28 Aug 2023 06:46:10 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qaW0m-008zwT-1b for linux-arm-kernel@lists.infradead.org; Mon, 28 Aug 2023 06:46:09 +0000 Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RZ1FB5bKJzhZFT; Mon, 28 Aug 2023 14:42:06 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 28 Aug 2023 14:45:55 +0800 From: Jinjie Ruan To: , , , , , , , , , CC: Subject: [PATCH -next v3 0/3] iio: adc: at91_adc: Cleanup with the helpers Date: Mon, 28 Aug 2023 14:45:43 +0800 Message-ID: <20230828064546.2383857-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230827_234608_714849_DC0672A2 X-CRM114-Status: UNSURE ( 9.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared and enabled clocks") provides a new helper function to prepare and enable a clock which keeps prepared (or enabled) during the whole lifetime of the driver. Use devm_request_irq() to request the interrupt, so we can avoid having to manually clean this up. Use the dev_err_probe() helper to simplify error handling during probe. This also handle scenario, when EDEFER is returned and useless error is printed. changes in v3: - Take the last remove free_irq() and add it to be the first devm managed. - Not going any longer than 80 chars than is necessary. Changes in v2: - Also use devm_request_irq() and dev_err_probe() to clean up the at91_adc. - Split the at91_adc patch out to be a new patch set. Jinjie Ruan (3): iio: adc: at91_adc: Use devm_request_irq() helper function iio: adc: at91_adc: Use devm_clk_get_enabled() helper function iio: adc: at91_adc: Simplify with dev_err_probe() drivers/iio/adc/at91_adc.c | 108 +++++++++++++------------------------ 1 file changed, 37 insertions(+), 71 deletions(-)