[0/5] imx-lcdif modeset changes

Message

Lucas Stach Sept. 20, 2023, 10:31 a.m. UTC

This changes the modeset flow in the imx-lcdif driver to work
better with runtime PM and get rid of duplicate hardware setup.

This series is a result of looking a bit more into the issue and
feedback received on some earlier patches [1].

Regards,
Lucas

[1] https://lore.kernel.org/all/[e-mail]/

Lucas Stach (5):
  drm: lcdif: improve burst size configuration comment
  drm: lcdif: move controller enable into atomic_flush
  drm: lcdif: remove superfluous setup of framebuffer DMA address
  drm: lcdif: move pitch setup to plane atomic update
  drm: lcdif: force modeset when FB format changes

 drivers/gpu/drm/mxsfb/lcdif_drv.c | 18 +++++++-
 drivers/gpu/drm/mxsfb/lcdif_kms.c | 68 +++++++++++++++++--------------
 2 files changed, 55 insertions(+), 31 deletions(-)

Comments

Liu Ying Sept. 21, 2023, 6:55 a.m. UTC | #1

Hi Lucas,

Thank you for the patch series.

On Wednesday, September 20, 2023 6:31 PM Lucas Stach <[e-mail]> wrote:
> This changes the modeset flow in the imx-lcdif driver to work
> better with runtime PM and get rid of duplicate hardware setup.

I'm assuming the duplicate hardware setup is calling
lcdif_plane_primary_atomic_update() in lcdif_crtc_atomic_enable()
as I mentioned in [1].  If that's the case, it looks like the call is
inevitable due to CRTC/bridge enablement sequence.  See detail
comments for patch 2/5.

Regards,
Liu Ying

>
> This series is a result of looking a bit more into the issue and
> feedback received on some earlier patches [1].
>
> Regards,
> Lucas
>
> [1]
> https://lore.k/
> ernel.org%2Fall%2FCAOcKUNWMU6tjWwtnU%2BCOggrr--G19EvZaHrxAp0-
> 0i5dK394jg%40mail.gmail.com%2F&data=05%7C01%7Cvictor.liu%40nxp.com
> %7C3dedd482af2a4a3d9d3f08dbb9c4bfe8%7C686ea1d3bc2b4c6fa92cd99c5c
> 301635%7C0%7C0%7C638308026921385573%7CUnknown%7CTWFpbGZsb3d
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> D%7C3000%7C%7C%7C&sdata=%2BxMk6cO%2Fxpoip2xChoFcHtkhLWNmi%2
> FngtNm%2BBu2kr6M%3D&reserved=0
>
> Lucas Stach (5):
>   drm: lcdif: improve burst size configuration comment
>   drm: lcdif: move controller enable into atomic_flush
>   drm: lcdif: remove superfluous setup of framebuffer DMA address
>   drm: lcdif: move pitch setup to plane atomic update
>   drm: lcdif: force modeset when FB format changes
>
>  drivers/gpu/drm/mxsfb/lcdif_drv.c | 18 +++++++-
>  drivers/gpu/drm/mxsfb/lcdif_kms.c | 68 +++++++++++++++++--------------
>  2 files changed, 55 insertions(+), 31 deletions(-)
>
> --
> 2.39.2