From patchwork Wed Oct 18 05:42:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13426379 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A306CDB47E for ; Wed, 18 Oct 2023 05:42:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Qq+RLW2Pfexak6vqxQicdG/GeXk31ILcwGg7gIypzYk=; b=S1y9yTu0atfqdL vmkoSo3Zn73PWlMJUj3grkmykjzYc23oFgwA8oSdrgiJIeSjaBhET7TGhErcnqBo0bBcSrBLxtsEH c4NqI8AfDlC2f8ZQkIjBSeut3bcHxQgfo4jhfZ13UJHPCgVsbyVNgjia30j+LaNkDzIedT1G01rP3 LQg1riLssFIHnfzIiQR0pgOBz4JE2NM4IAuHAq5917bnF1y5/roRV6G3dZes7W620nCxQBpwTNBqA DVimx+PS7sRy2hgrDq+dctFR9fuoA+2GMKr8UqwGJx91HwP585WmY6hW1+awpN3ACfdCRq9XesX9F M15gndgTFIBCHCOqOcIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qszK7-00DqUw-1b; Wed, 18 Oct 2023 05:42:27 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qszK4-00DqUT-2T; Wed, 18 Oct 2023 05:42:26 +0000 Received: from umang.jainideasonboard.com (unknown [103.251.226.39]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1FC74741; Wed, 18 Oct 2023 07:42:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1697607736; bh=/EyFN8/bdjJajsbpQvuQvWRlcHT4qLY5CfmEYT+KqDE=; h=From:To:Cc:Subject:Date:From; b=NebgRnPZGBTnECnRTLYVfNLbS28w9JH0QDAeQ+uCctDWy6lCeGq8sUr80a7S+/2K0 cqoTO4og0RKPfFqj2L1TMQat12P3BTPzNJi38v7dNAuNYO4DAOFPfIIRAXpdpCU0ne vr/0q5U9rTydxgnKggvLi0CNcP24+xmmfqGd/Mo4= From: Umang Jain To: linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Umang Jain Subject: [PATCH v2 0/3] vc04_services: Tweak module autoloading support Date: Wed, 18 Oct 2023 11:12:11 +0530 Message-Id: <20231018054214.824296-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231017_224224_967416_C5646980 X-CRM114-Status: UNSURE ( 6.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As explained by Greg KH in [1], we should not be using MODULE_ALIAS to auto load modules within VC04. Drop that, in favour of MODULE_DEVICE_TABLE. This series addresses the suggestion. Patch 1/3 adds vchiq_bus_device_id and supporting entries in script/mod/file2alias.c Patch 2/3 drops MODULE_ALIAS from bcm2835-audio in favour of MODULE_DEVICE_TABLE. Patch 3/3 drops MODULE_ALIAS from bcm2835-camera in favour of MODULE_DEVICE_TABLE. [1]: https://lore.kernel.org/linux-media/2023100955-stunt-equate-c6fa@gregkh/ --- Changes in v2: - NULL terminate device_id_table arrays (in 2/3 and 3/3) Umang Jain (3): staging: vc04_services: Support module autoloading using MODULE_DEVICE_TABLE staging: vc04_services: bcm2835-audio: Drop MODULE_ALIAS staging: vc04_services: bcm2835-camera: Drop MODULE_ALIAS drivers/staging/vc04_services/bcm2835-audio/bcm2835.c | 8 +++++++- .../vc04_services/bcm2835-camera/bcm2835-camera.c | 8 +++++++- .../vc04_services/interface/vchiq_arm/vchiq_bus.c | 2 +- .../vc04_services/interface/vchiq_arm/vchiq_bus.h | 3 +++ include/linux/mod_devicetable.h | 4 ++++ scripts/mod/devicetable-offsets.c | 3 +++ scripts/mod/file2alias.c | 9 +++++++++ 7 files changed, 34 insertions(+), 3 deletions(-) base-commit: a2fc3e8215313c8e4e42d4b2062830aaf1ef49c0