From patchwork Thu Oct 19 09:01:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13428498 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BCDDCDB465 for ; Thu, 19 Oct 2023 09:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=NbEZ7wv/7gycV17IbJPwoPh8riSBp9dc8e3alR9xkWw=; b=zUpZKOjQTQZsPO l8ltp6vBmMHsJgBHmMOjR+djES54qn7SGZq83aN5dICV6DML9qupBcC5jcHQ8tTOV0xiZwsmVlcdb ucB/kDGf4zDxPc1hEOwgo3u34PNRnUWQ5bM2Rcrvs141QtF2ELLDtF/C+DUooCBWj5j+S21MwEGed 7rs1ednWrb6csDkVcKSzgbtOMwA+ANdRP7GBEiW848b7mPKir6rGWk9baxbXSfXn3on8OmDTRfkBx yMjx+wweBBXn7HtaYkEzxmLXagCYDIxFevuHpcU5BlHoEk5J6LWavT23YVbnIN1NDjsfldPniv4H/ QXi/JDUqxP9T0DjH1v4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtOuV-00Gn79-0r; Thu, 19 Oct 2023 09:01:43 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtOuS-00Gn6k-2x; Thu, 19 Oct 2023 09:01:42 +0000 Received: from umang.jainideasonboard.com (unknown [103.251.226.1]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B88F276; Thu, 19 Oct 2023 11:01:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1697706091; bh=0IdmhEotctmPef8qb+I8G8sMyOBhKaSYmTmYqHHKNRg=; h=From:To:Cc:Subject:Date:From; b=Eb7cq8pmZknptTqC5uWgzTE+VmpOXWwt4fT7qEvSwQm4ocLhLRI13IqDDzuqQDj28 MtVGidYlOzDza+lv/xUgs4q56oLuLYJB5gLsQGkePvaskW+/jNHTP69DdMA0Tx3tZ8 eFBtIWUdAvJsQuWP7mtIMBwhCcjsTUmjZUTij6qc= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Umang Jain Subject: [PATCH v3 0/3] staging: vc04_services: Tweak module autoloading support Date: Thu, 19 Oct 2023 14:31:25 +0530 Message-Id: <20231019090128.430297-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231019_020141_120268_F33EB7FC X-CRM114-Status: UNSURE ( 7.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As explained by Greg KH in [1], we should not be using MODULE_ALIAS to auto load modules within VC04. Drop that, in favour of MODULE_DEVICE_TABLE. This series addresses the suggestion. Patch 1/3 adds vchiq_bus_device_id and supporting entries in script/mod/file2alias.c Patch 2/3 drops MODULE_ALIAS from bcm2835-audio in favour of MODULE_DEVICE_TABLE. Patch 3/3 drops MODULE_ALIAS from bcm2835-camera in favour of MODULE_DEVICE_TABLE. [1]: https://lore.kernel.org/linux-media/2023100955-stunt-equate-c6fa@gregkh/ Reviewed-by: Kieran Bingham --- Changes in v3: - Drop "_bus" suffix from all patches (and commit message) as pointed out in v2 review Changes in v2: - NULL terminate device_id_table arrays (in 2/3 and 3/3) Umang Jain (3): staging: vc04_services: Support module autoloading using MODULE_DEVICE_TABLE staging: vc04_services: bcm2835-audio: Drop MODULE_ALIAS staging: vc04_services: bcm2835-camera: Drop MODULE_ALIAS drivers/staging/vc04_services/bcm2835-audio/bcm2835.c | 8 +++++++- .../vc04_services/bcm2835-camera/bcm2835-camera.c | 8 +++++++- .../vc04_services/interface/vchiq_arm/vchiq_bus.c | 2 +- .../vc04_services/interface/vchiq_arm/vchiq_bus.h | 3 +++ include/linux/mod_devicetable.h | 4 ++++ scripts/mod/devicetable-offsets.c | 3 +++ scripts/mod/file2alias.c | 9 +++++++++ 7 files changed, 34 insertions(+), 3 deletions(-)