mbox series

[0/3] staging: vc04: Smatch analysis fixes

Message ID 20231102210603.1201311-1-umang.jain@ideasonboard.com (mailing list archive)
Headers show
Series staging: vc04: Smatch analysis fixes | expand

Message

Umang Jain Nov. 2, 2023, 9:06 p.m. UTC 
low-hanging fruits series that solve a few of the warnings exposed by
smatch analysis. See individual patch for details.

Umang Jain (3):
  staging: vc04_services: vchiq_core: Log through struct vchiq_instance
  staging: vc04_services: Log using pr_err() when vchiq_state is unset
  staging: vc04_services: bcm2835-camera: Remove redundant null check

 .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c  | 7 ++-----
 .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c  | 6 ++----
 .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 6 +++---
 .../staging/vc04_services/interface/vchiq_arm/vchiq_dev.c  | 7 +++----
 4 files changed, 10 insertions(+), 16 deletions(-)


base-commit: a4000df5300fdbe10d84e3b70e2d6a98686310a9

Comments

Ricardo B. Marliere Nov. 3, 2023, 3:11 p.m. UTC | #1 
On 23/11/02 05:06PM, Umang Jain wrote:
> low-hanging fruits series that solve a few of the warnings exposed by
> smatch analysis. See individual patch for details.
> 
> Umang Jain (3):
>   staging: vc04_services: vchiq_core: Log through struct vchiq_instance
>   staging: vc04_services: Log using pr_err() when vchiq_state is unset
>   staging: vc04_services: bcm2835-camera: Remove redundant null check
> 
>  .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c  | 7 ++-----
>  .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c  | 6 ++----
>  .../staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 6 +++---
>  .../staging/vc04_services/interface/vchiq_arm/vchiq_dev.c  | 7 +++----
>  4 files changed, 10 insertions(+), 16 deletions(-)
> 
> 
> base-commit: a4000df5300fdbe10d84e3b70e2d6a98686310a9
> -- 
> 2.41.0
> 

Whole series is

Reviewed-by: Ricardo B. Marliere <ricardo@marliere.net>

Thank you,
-	Ricardo