From patchwork Sat Nov 4 12:43:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13445510 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF141C4332F for ; Sat, 4 Nov 2023 12:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:MIME-Version:Message-Id:Date: Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ZR1tcJyPUV2qVSSkh9FIdtwjQ/HFarVJhz8T15+ZP1Y=; b=VOxb+Msrtd4dfN MulDjTxF/05pql28IUa5K6Fdn9+x3pbVmD0dSW3eBTzj74M+bt2r8E7TpUPZt779mVhjCAEsU6vAE APhMOOBddDIubVQDOzYPjSv8GqjyN0y16C9RRCUAXnzm9cwdfzneSxHpArL2SGqWiw9OCbJ3lD5QL cFDGNClcqSB5al8dv747uzul4W200MoJZqD2omIMuYIj5riXRnNtjmiTZBfQHa2Lg5MoECTgmYwio LwM3hMWy4T3sF3P+KlBNncqlV8KVpv6mvA2ZWZPX23ro85VPvuQlI9VxXrWiqZit8yyD4GRKM1HGV viFffrRWO7GoVEAGLaOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qzG0K-00DPH1-0o; Sat, 04 Nov 2023 12:43:56 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qzG0H-00DPFb-0d for linux-arm-kernel@lists.infradead.org; Sat, 04 Nov 2023 12:43:54 +0000 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-507a29c7eefso3720973e87.1 for ; Sat, 04 Nov 2023 05:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699101830; x=1699706630; darn=lists.infradead.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=ewDHm+e+GImvvqfDodwPgmnoPkNl83AA+pDa6pnzAe0=; b=twNAWWQA4X6H4zm3hbqMLzhT3jGxumMAaybW1uF7bFKWVMlDqKVofaZozDmKHWjqQ/ yORAn8J99VCUSYimiquwJ9MzQ15Bjpkn5yDt+vmVzUOtBdmXQnlqFv9C3fiugeDpr0/6 3u+BvAgG4zf6Q9QPTUbf6Z48FhiQQBS0TBXPm2aJIgBcEijyiSjdA2gdJeqCkE23iD/H PXlPjTV9CtAAAdnju445bbyaT0g6fMcKtaDj08sCaVw42s1EQ/trw/y/y8oXdeesUaRN WCgbCpQePgn7WRqTf3XfiFWQsWalv/JLUcNetRYOPTZzMwDxEaWeVewg93+qH1j5MMm3 N2dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699101830; x=1699706630; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ewDHm+e+GImvvqfDodwPgmnoPkNl83AA+pDa6pnzAe0=; b=jgM+LMvEwMFoZsEdU0fYjuAu8ECmjKxfwcT1R+1HOjdUYrcucQ2CAqX89W27x8Xeu2 /sLacRDyD/eNmN9+eK+xQ0YzCJFyoi2KFSjklYq2oAranTz5TsjIyIxeThNJk8heWUNw bm5M+WpsZBLAEhTy/xlmRCkF4MFEGIJrHK7uJo9p+q7aEf9pZfsTKMIRszO+d8P5qmKS vH4k8IBBTqaqZ4M7jvX9s54EOCsiUn6qYyT1GVS7mWqyKA3bv1Z5nM36UDgzHQ9hWtzs aRtZ43WmABkaSkWjdEocFQuCaHgT7bjUO2ntef+pQxl7AZCVtPSI1MAtlX6q1sd1vmR6 fOVQ== X-Gm-Message-State: AOJu0YxLqcfRpVLhHSfhDbnMRhX+Cb1FGeFY6XgJWSMfw3pAA+uU2g45 vLXGq7Ltk8Eler6ETDaNqeqaMg== X-Google-Smtp-Source: AGHT+IGGlkissxY+vBqmlLfCOeMTVSLvbUU0DrUKYcegqlRg5AhwssW3duvhu257rrYlLalqYiXfyA== X-Received: by 2002:a05:6512:132a:b0:509:4559:27a9 with SMTP id x42-20020a056512132a00b00509455927a9mr7370477lfu.8.1699101829828; Sat, 04 Nov 2023 05:43:49 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u22-20020ac24c36000000b005093312f66fsm496100lfq.124.2023.11.04.05.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Nov 2023 05:43:49 -0700 (PDT) From: Linus Walleij Subject: [PATCH net 0/4] Fix large frames in the Gemini ethernet driver Date: Sat, 04 Nov 2023 13:43:47 +0100 Message-Id: <20231104-gemini-largeframe-fix-v1-0-9c5513f22f33@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAIM8RmUC/x2MwQqDMBAFf0X27IIblRZ/pXiI8Zku1Fg2Ugriv xs8zsDMQRmmyDRUBxl+mnVLBaSuKLx9imCdC5NrXCvSdByxalL+eItYzK/gRf8cpGtnFx5PmXo q7ddQ9P19UcJO43lejY1NxGwAAAA= To: Hans Ulli Kroll , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= , Vladimir Oltean Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231104_054353_282667_A86DCBC3 X-CRM114-Status: UNSURE ( 9.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is the result of a bug hunt for a problem with the RTL8366RB DSA switch leading me wrong all over the place. I am indebted to Vladimir Oltean who as usual pointed out where the real problem was, many thanks! Tryig to actually use big ("jumbo") frames on this hardware uncovered the real bugs. Then I tested it on the DSA switch and it indeed fixes the issue. Signed-off-by: Linus Walleij --- Linus Walleij (4): net: ethernet: cortina: Fix MTU max setting net: ethernet: cortina: Fix max RX frame define net: ethernet: cortina: Protect against oversized frames net: ethernet: cortina: Handle large frames drivers/net/ethernet/cortina/gemini.c | 32 ++++++++++++++++++++++++++------ drivers/net/ethernet/cortina/gemini.h | 10 +++++----- 2 files changed, 31 insertions(+), 11 deletions(-) --- base-commit: 90b0c2b2edd1adff742c621e246562fbefa11b70 change-id: 20231104-gemini-largeframe-fix-c143d2c781b5 Best regards,