From patchwork Tue Nov 7 16:55:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13449119 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0CA2C4167B for ; Tue, 7 Nov 2023 16:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=EuPERIHZjFhy3NaH3iDai5413eRSIW8J6nx80yC6rhU=; b=382ahypFdLmsRR x2n6Yd0tGVRqTqMF1Yj5JEOQGx5NopMcn2j7sntWs1CS3o+CgRi6HdWoI6HdDQvR8jqqQQFROLwJ6 0GMhTxHyrkt5wBn5BzZKkeU9wq8LneBpGQSvMlinNuVrZnXfeY1X+mV06K6kOKYuBbKS0JT1YoL1Q FNZuSOg2qkplpOi3HI1RTHhAcHtr1ZJRFR4gjOkk6AvNsHxo8REjlsDp683JVVVmQDrCJOFduWzkt NwW2enD6uImLlg2hhJDcrc4m54apGDNtwfP2UfW9fDUNy4g211knUOk0v9iv83Nk5Sc88BeBnK8+h I9H4zsiApWcp8kCyszxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0PMd-0022nz-1A; Tue, 07 Nov 2023 16:55:43 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0PMa-0022lY-08; Tue, 07 Nov 2023 16:55:41 +0000 Received: from umang.jain (unknown [103.251.226.96]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BA6C6552; Tue, 7 Nov 2023 17:55:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1699376111; bh=fZdOsLuOsy4l3gpxjmBOY1RfLY8nQistmx8GqH4SDdM=; h=From:To:Cc:Subject:Date:From; b=QHb/qcPZp5UgTZdUC69scZdyVDuUyyjlZEcYsji+2vqOyOvumb1oI2/kwje+DCtbh hytaUzumG67USOAslUpSCUMIZllz7oKX0D2IwrbZwUSGIVJvtnDeUfkNUMKtsgqyL0 b4id0MGBTcFxoX6zkj9WaO8d52/scDNpYGeUOt2Y= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Dave Stevenson , Phil Elwell , "Ricardo B . Marliere" , Umang Jain Subject: [PATCH 0/2] staging: vc04_services: Use %p to log pointer Date: Tue, 7 Nov 2023 11:55:21 -0500 Message-ID: <20231107165523.638555-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_085540_241098_47804252 X-CRM114-Status: UNSURE ( 7.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org %lx is used to print the unmodified pointer address for debugging. %p will print the hashed pointer address to avoid leaking information about kernel memory layout to userspace. But when `no_hash_pointers` is passed as kernel parameter, unmodified pointer address will be printed. Hence, drop %lx in favour of %p. For debugging purposes, one can easily depend on `no_hash_pointers`. This also solves the following smatch warnings: service_callback() warn: argument 7 to %lx specifier is cast from pointer service_callback() warn: argument 11 to %lx specifier is cast from pointer service_callback() warn: argument 12 to %lx specifier is cast from pointer service_callback() warn: argument 13 to %lx specifier is cast from pointer vchiq_release() warn: argument 7 to %lx specifier is cast from pointer Umang Jain (2): staging: vc04_services: Use %p to log pointer address staging: vc04_services: Use %p to log pointer address .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 +++---- .../staging/vc04_services/interface/vchiq_arm/vchiq_dev.c | 4 ++-- 2 files changed, 5 insertions(+), 6 deletions(-)