From patchwork Mon Nov 13 18:56:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 13454337 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40328C4332F for ; Mon, 13 Nov 2023 18:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=reclaLeJLpXaPBatBL4lVdMYK1LS9xUHAvEuoVaTMgs=; b=GMN l7J7o68SgrN/rCFVenj9ThnvPhH9+EXat8Zo1jkAOkZawgc5AOCHSltthvZItmru8DEOlE1RHVX1n jy/WLDK8ySAIWBRzaw6uUwtIUvPrUTJG8qOTxi45ZJL2m2pHKMOteMv1k0NWd6N6CZj0gYHlUiQL+ BsDRqVcYDWA9C1g/T4Ek4UfA+t72AwHz0XF3lBejy53TJr0f1N9don5nHnnHEfCJXYNEIW9Ur0avQ bERmE9nIx9lvDKUu2uNGMDbvKX7i9sHsr+JQc8FgoUjbywAuwcX70/DzfnJQ2t5mrZqSOg5NlZaEC Ygt2+2+I/o0ePIi9NclJiDoFOpI0gRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r2c6d-00EWVm-3D; Mon, 13 Nov 2023 18:56:20 +0000 Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r2c6a-00EWUI-0Q for linux-arm-kernel@lists.infradead.org; Mon, 13 Nov 2023 18:56:18 +0000 Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-3b5aee410f2so2115599b6e.1 for ; Mon, 13 Nov 2023 10:56:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1699901773; x=1700506573; darn=lists.infradead.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a8jMIVx3gr9uHuVRBzzA94Cv2dT4DrJadIKRukwTDu4=; b=Xc5n4S3kuLC9vnAN6YanRZceieMaYdNXElwIbju2CxzRs9NhKaR37vqT6h+YQvYDSX bFOvez4hoFJPnBRNJgXs9Oo9ALU2L0rlKaUfP6M3kOSe/DDfUJRPBcMlJSC4jM/KIwdr DipjH5xQRiC2yISbGNfe6+r6ug6An57MZpNvc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699901773; x=1700506573; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a8jMIVx3gr9uHuVRBzzA94Cv2dT4DrJadIKRukwTDu4=; b=sYB7dpOvvebgJx9iVU3yLbk/cgjXeF4NT169RZzXca+DDp4PpauT+CAsUN3fkLAWG0 b/pC5TUL2NKMxCokzkyYNOSZlL1pMK/oIZ7pv8Xn3OxJupt3parWU1GEexYlU2qzo8eH Bj5nCxnTpbADl+YjGJxbzaZFIfXx6SVIvjCNmh9QXI78CSyADQOyBCE6KOrIYLuBcIui NpZdOmx0g3KnlAZYNVSkNRCEOBD8n0f34RwEYQ9PmYsbn9cH6/WbOhV4r7cG6oOPnnnd MpiitfmAAyXNIjZZiOUNmvtGJVFlPbKPnY7UdFettkrdjOSb7PWDZ2UdrOsdNMjeRX0o uEfQ== X-Gm-Message-State: AOJu0YxtdsUO3tkkPrdSm3snjaaa8nMVbanMYUOIJQY/3KpPk4pQxmEk yoEGFIGOJSt+rWkv0ATbbe1deg== X-Google-Smtp-Source: AGHT+IFS5SasBmECJ/tk7P+h1ZRJrAbM3+XK567jgpWI5zJCovVrs3bsSyr2+G3mVh0uP3aB3TaoHQ== X-Received: by 2002:a05:6808:1413:b0:3b2:dc66:1673 with SMTP id w19-20020a056808141300b003b2dc661673mr9286135oiv.9.1699901773160; Mon, 13 Nov 2023 10:56:13 -0800 (PST) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id b187-20020a6334c4000000b0056b27af8715sm4366421pga.43.2023.11.13.10.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 10:56:12 -0800 (PST) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Conor Dooley , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), Florian Fainelli , Jim Quinlan , Krzysztof Kozlowski , =?utf-8?q?Krzyszto?= =?utf-8?q?f_Wilczy=C5=84ski?= , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), Lorenzo Pieralisi , Rob Herring Subject: [PATCH v8 0/2] PCI: brcmstb: Configure appropriate HW CLKREQ# mode Date: Mon, 13 Nov 2023 13:56:04 -0500 Message-Id: <20231113185607.1756-1-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231113_105616_560892_F0262529 X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org V8 -- Un-advertise L1SS capability when in "no-l1ss" mode (Bjorn) -- Squashed last two commits of v7 (Bjorn) -- Fix DT binding description text wrapping (Bjorn) -- Fix incorrect Spec reference (Bjorn) s/PCIe Spec/PCIe Express Mini CEM 2.1 specification/ -- Text substitutions (Bjorn) s/WRT/With respect to/ s/Tclron/T_CLRon/ v7 -- Manivannan Sadhasivam suggested (a) making the property look like a network phy-mode and (b) keeping the code simple (not counting clkreq signal appearances, un-advertising capabilites, etc). This is what I have done. The property is now "brcm,clkreq-mode" and the values may be one of "safe", "default", and "no-l1ss". The default setting is to employ the most capable power savings mode. v6 -- No code has been changed. -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril) -- Changed sign-off and author email address for all commits. This was due to a change in Broadcom's upstreaming policy. v5 -- Remove DT property "brcm,completion-timeout-us" from "DT bindings" commit. Although this error may be reported as a completion timeout, its cause was traced to an internal bus timeout which may occur even when there is no PCIe access being processed. We set a timeout of four seconds only if we are operating in "L1SS CLKREQ#" mode. -- Correct CEM 2.0 reference provided by HW engineer, s/3.2.5.2.5/3.2.5.2.2/ (Bjorn) -- Add newline to dev_info() string (Stefan) -- Change variable rval to unsigned (Stefan) -- s/implementaion/implementation/ (Bjorn) -- s/superpowersave/powersupersave/ (Bjorn) -- Slightly modify message on "PERST#" commit. -- Rebase to torvalds master v4 -- New commit that asserts PERST# for 2711/RPi SOCs at PCIe RC driver probe() time. This is done in Raspian Linux and its absence may be the cause of a failing test case. -- New commit that removes stale comment. v3 -- Rewrote commit msgs and comments refering panics if L1SS is enabled/disabled; the code snippet that unadvertises L1SS eliminates the panic scenario. (Bjorn) -- Add reference for "400ns of CLKREQ# assertion" blurb (Bjorn) -- Put binding names in DT commit Subject (Bjorn) -- Add a verb to a commit's subject line (Bjorn) -- s/accomodat(\w+)/accommodat$1/g (Bjorn) -- Rewrote commit msgs and comments refering panics if L1SS is enabled/disabled; the code snippet that unadvertises L1SS eliminates the panic scenario. (Bjorn) v2 -- Changed binding property 'brcm,completion-timeout-msec' to 'brcm,completion-timeout-us'. (StefanW for standard suffix). -- Warn when clamping timeout value, and include clamped region in message. Also add min and max in YAML. (StefanW) -- Qualify description of "brcm,completion-timeout-us" so that it refers to PCIe transactions. (StefanW) -- Remvove mention of Linux specifics in binding description. (StefanW) -- s/clkreq#/CLKREQ#/g (Bjorn) -- Refactor completion-timeout-us code to compare max and min to value given by the property (as opposed to the computed value). v1 -- The current driver assumes the downstream devices can provide CLKREQ# for ASPM. These commits accomodate devices w/ or w/o clkreq# and also handle L1SS-capable devices. -- The Raspian Linux folks have already been using a PCIe RC property "brcm,enable-l1ss". These commits use the same property, in a backward-compatible manner, and the implementaion adds more detail and also automatically identifies devices w/o a clkreq# signal, i.e. most devices plugged into an RPi CM4 IO board. Jim Quinlan (2): dt-bindings: PCI: brcmstb: Add property "brcm,clkreq-mode" PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device .../bindings/pci/brcm,stb-pcie.yaml | 18 ++++ drivers/pci/controller/pcie-brcmstb.c | 96 +++++++++++++++++-- 2 files changed, 104 insertions(+), 10 deletions(-) base-commit: 305230142ae0637213bf6e04f6d9f10bbcb74af8 Tested-by: Cyril Brulebois