From patchwork Mon Nov 27 15:43:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13469867 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DC94C0755A for ; Mon, 27 Nov 2023 15:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:MIME-Version:Message-Id:Date: Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=er5HrIsLvrXH6qWr6ldeYkMaRN1DItRwmSn46CbXcfg=; b=WN+T8j/YrBgi39 nCiM5Kar0y4YQ1ki0WNo7B6LDVvK+/eWj9oZobSE/0XluqhNER82In0gfha9jpkm0iF6r0+6q5ZAy R5pay1fYrAlzfVz27DXMyjYfWQcB8/QW0rGn/rQzXBe3jnQQMPdqwrE73pdImKHG2KZNA7MuSUMqK RqwJyVEUGR9Gzl0Pcn5hyiK6O5xcbej9y1TR+AkIRANF93ekJ3k58PRNCFVMW9a9dL6aTWuetdTQn nxsd1/wZ303RwZtvnkCVh937ANh+acm5HBRYQFFbKZW9q5V48gux0z3XoPcaRqRciw02sMFDIZq+w meVKHikZP+8JPQGSWtAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7dlf-002qul-0F; Mon, 27 Nov 2023 15:43:27 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7dlW-002qqx-1f for linux-arm-kernel@lists.infradead.org; Mon, 27 Nov 2023 15:43:20 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-50aab20e828so6243205e87.2 for ; Mon, 27 Nov 2023 07:43:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701099793; x=1701704593; darn=lists.infradead.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=6eKSI20Q0D7jXzWoo9HzJDMIqRNEtaSE30aXGr8DziA=; b=l0BVOSw+iqG0YVI8FBNwDSd9lxpaGL6Gy+Yre2jqJ5ciL6LsP12+/jFq0+p4BlLFif GU72R3C33PDs2cvU77Ub3etYiAWKdwwuLvOIWfXXZGigZh8xc23MU0vA0bNYNo4Lo4VZ LlOsB6ilKHGQAyEnayCyJ05NPmT52+O7Ofi9IhogeExNvhiJ3/bVAKmncmb0HHOGaO41 IaDLkWsIjjUyBG6tRSy2bwNEKjVd8cLOj5P3iOBdMWkhlaH3Tx5WOwH6bzp+YRIc2CsL rc6jGR1BYeBjJI81XsDRCP5yh4jHakSHBBmZOvnpUYkvK19v4lixsKcWtRxMZbgKpzdh 3ABw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701099793; x=1701704593; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6eKSI20Q0D7jXzWoo9HzJDMIqRNEtaSE30aXGr8DziA=; b=hVuWc1GiEF/sHky4g76gfD/w2dOR7J52YFZUF4yrDpuLQ7zJY+ihNlPurgaXpneZpn k40CZAkDhdR/ewPdjV5lUTTvUuTGoGl6BYq7DLSxYPz86GRgvq6WrgElybAV3QSgAj8+ oiJgu9NTI67voJpg0HejyRCLmqgrVjdhEkCENYXY/yyOhVQqYrIWgAp46UbLo9mi0BXH RFwJ8775GKRBGn+5i1HE/tCHPYwYJDUhX4lnuNnvUEI2hkXvRK7EHkRngYlKe0s64yoT iInJhkr/28IEiljJlJNIJQTN4uSRiDEYdF+k3t+RiUGx+mRpyfQ/T8q7uSRlQzeAgrqP 2Rrg== X-Gm-Message-State: AOJu0YzcJh4zKXhvalwZYV9odnQSp1vDQ6vDJ7qH3cItROOlVbzS/QPj XQxuf/QF+Mt1YfrtU2bC8aO8hg== X-Google-Smtp-Source: AGHT+IGy3Wqhh/1y9K43w7Cyu6fyQ5q8zbBpGEJRrqy0jjJp9msb/yS9xwFFWICWk19kmr7GKnf8dw== X-Received: by 2002:a05:6512:15aa:b0:50b:a823:6213 with SMTP id bp42-20020a05651215aa00b0050ba8236213mr6962935lfb.52.1701099792426; Mon, 27 Nov 2023 07:43:12 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id v28-20020ac2559c000000b0050ab86037d8sm1505049lfg.205.2023.11.27.07.43.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 07:43:11 -0800 (PST) From: Linus Walleij Subject: [PATCH net-next v9 0/5] Create a binding for the Marvell MV88E6xxx DSA switches Date: Mon, 27 Nov 2023 16:43:03 +0100 Message-Id: <20231127-marvell-88e6152-wan-led-v9-0-272934e04681@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAAe5ZGUC/43RTWrDMBAF4KsErauif4266j1KF5I1TgSuHWSjp gTfvYq7qIux6fIxzDfw5k5GzAlH8nK6k4wljWnoa3BPJ9JcfH9GmmLNRDAhOWNAP3wu2HUUAA3 Xgn76nnYYa26UDLaNoo2kbl8ztum2yG+kx4n2eJvIe51c0jgN+Ws5Wfgy/9G53NULp4wyy0Xwz oG2zWuXep+H5yGfF7SINaT2IVEh2zaeQTAAym0guYbMPiQrJKGJSrnYBq43kFpD+8UV9YAQWWO sBBlwA+kVJA460o+OEITTgnHt7QYya+igI1Mh56QPzCknldpA9p+QrZAAUw1rnI18A8EvxI++B hXSrD7MKm4cD3+geZ6/Ae/ZyjHIAgAA To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?utf-8?q?Marek_Beh=C3=BAn?= Cc: Christian Marangi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Linus Walleij , Rob Herring , Florian Fainelli , Krzysztof Kozlowski , Vladimir Oltean X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231127_074318_555078_79BEAACB X-CRM114-Status: GOOD ( 25.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Marvell switches are lacking DT bindings. I need proper schema checking to add LED support to the Marvell switch. Just how it is, it can't go on like this. Some Device Tree fixes are included in the series, these remove the major and most annoying warnings fallout noise: some warnings remain, and these are of more serious nature, such as missing phy-mode. They can be applied individually, or to the networking tree with the rest of the patches. Thanks to Andrew Lunn, Vladimir Oltean and Russell King for excellent review and feedback! This latest version employs special compatibles in the odd ABI device trees. Signed-off-by: Linus Walleij --- Changes in v9: - Drop all the per-platform device tree fixes, instead send these separately for Marvell and NXP platform trees to be applied through the SoC tree. - This means the bindings will yield robotized warnings. Ignore these, and rely on platform maintainers to deal with the fallout. Patches exists for the majority of the problems, see v8. - Link to v8: https://lore.kernel.org/r/20231114-marvell-88e6152-wan-led-v8-0-50688741691b@linaro.org Changes in v8: - Restore ALL original switch node names in the Turris Mox, not just the top one. Put a comment above each not to change the node name. - Add a special compatible for the Turris Mox switches, so that we can apply special rules for these ABI nodes. - Add quirks to the bindings to deal with the special node names so we don't get unsolicited warnings about them from the checks. This is done so that people will not come and "fix the DTS files" so they break. We only have serious warnings after this. - Add the quirks and updates to the nodes into separate patches for review. - Link to v7: https://lore.kernel.org/r/20231024-marvell-88e6152-wan-led-v7-0-2869347697d1@linaro.org Changes in v7: - Fix the elaborate spacing to satisfy yamllint in the ports/ethernet-ports requirement. - Link to v6: https://lore.kernel.org/r/20231024-marvell-88e6152-wan-led-v6-0-993ab0949344@linaro.org Changes in v6: - Fix ports/ethernet-ports requirement with proper indenting (hopefully). - Link to v5: https://lore.kernel.org/r/20231023-marvell-88e6152-wan-led-v5-0-0e82952015a7@linaro.org Changes in v5: - Consistently rename switch@n to ethernet-switch@n in all cleanup patches - Consistently rename ports to ethernet-ports in all cleanup patches - Consistently rename all port@n to ethernet-port@n in all cleanup patches - Consistently rename all phy@n to ethernet-phy@n in all cleanup patches - Restore the nodename on the Turris MOX which has a U-Boot binary using the nodename as ABI, put in a blurb warning about this so no-one else tries to change it in the future. - Drop dsa.yaml direct references where we reference dsa.yaml#/$defs/ethernet-ports - Replace the conjured MV88E6xxx example by a better one based on imx6qdl plus strictly named nodes and added reset-gpios for a more complete example, and another example using the interrupt controller based on armada-381-netgear-gs110emx.dts - Bump lineage to 2008 as Vladimir says the code was developed starting 2008. - Link to v4: https://lore.kernel.org/r/20231018-marvell-88e6152-wan-led-v4-0-3ee0c67383be@linaro.org Changes in v4: - Rebase the series on top of Rob's series "dt-bindings: net: Child node schema cleanups" (or the hex numbered ports will not work) - Fix up a whitespacing error corrupting v3... - Add a new patch making the generic DSA binding require ports or ethernet-ports in the switch node. - Drop any corrections of port@a in the patches. - Drop oneOf in the compatible enum for mv88e6xxx - Use ethernet-switch, ethernet-ports and ethernet-phy in the examples - Transclude the dsa.yaml#/$defs/ethernet-ports define for ports - Move the DTS and binding fixes first, before the actual bindings, so they apply without (too many) warnings as fallout. - Drop stray colon in text. - Drop example port in the mveusb binding. - Link to v3: https://lore.kernel.org/r/20231016-marvell-88e6152-wan-led-v3-0-38cd449dfb15@linaro.org Changes in v3: - Fix up a related mvusb example in a different binding that the scripts were complaining about. - Fix up the wording on internal vs external MDIO buses in the mv88e6xxx binding document. - Remove pointless label and put the right rev-mii into the MV88E6060 schema. - Link to v2: https://lore.kernel.org/r/20231014-marvell-88e6152-wan-led-v2-0-7fca08b68849@linaro.org Changes in v2: - Break out a separate Marvell MV88E6060 binding file. I stand corrected. - Drop the idea to rely on nodename mdio-external for the external MDIO bus, keep the compatible, drop patch for the driver. - Fix more Marvell DT mistakes. - Fix NXP DT mistakes in a separate patch. - Fix Marvell ARM64 mistakes in a separate patch. - Link to v1: https://lore.kernel.org/r/20231013-marvell-88e6152-wan-led-v1-0-0712ba99857c@linaro.org --- Linus Walleij (5): dt-bindings: net: dsa: Require ports or ethernet-ports dt-bindings: net: mvusb: Fix up DSA example dt-bindings: net: ethernet-switch: Accept special variants dt-bindings: marvell: Rewrite MV88E6xxx in schema dt-bindings: marvell: Add Marvell MV88E6060 DSA schema Documentation/devicetree/bindings/net/dsa/dsa.yaml | 6 + .../bindings/net/dsa/marvell,mv88e6060.yaml | 88 ++++++ .../bindings/net/dsa/marvell,mv88e6xxx.yaml | 337 +++++++++++++++++++++ .../devicetree/bindings/net/dsa/marvell.txt | 109 ------- .../devicetree/bindings/net/ethernet-switch.yaml | 23 +- .../devicetree/bindings/net/marvell,mvusb.yaml | 7 +- MAINTAINERS | 3 +- 7 files changed, 458 insertions(+), 115 deletions(-) --- base-commit: b85ea95d086471afb4ad062012a4d73cd328fa86 change-id: 20231008-marvell-88e6152-wan-led-88c43b7fd2fd Best regards,