| Message ID | 20231128201926.489269-1-umang.jain@ideasonboard.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | staging: vc04_services: Drop custom logging | expand |
Hi Umang, Am 28.11.23 um 21:19 schrieb Umang Jain: > This series also removes the vchiq_log_* macro and makes use of dev_dbg() > directly. sorry, i didn't had the time to follow the logging discussion, but the following commits: staging: vc04: Convert vchiq_log_error() to use dynamic debug staging: vc04: Convert vchiq_log_warning() to use dynamic debug staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic debug changed the logging behavior. I don't think it's intended to move everything to dev_dbg. I would expected the following mapping: vchiq_log_error -> dev_err vchiq_log_warning -> dev_warn vchiq_log_info -> dev_info > > Patch 1/5 is fix. It prevents passing NULL to one of vchiq_log_error(). > The function there in question, does not have any users as of > now. However, it is going to be used by the vc-sm-cma and bcm2835-isp > drivers (posted on list for review [1]). There was discussion on v1, > whether I should drop and add the function later, however, didn't > conclude. > > Patch 2/5 removes vchiq_log_error() macro > Patch 3/5 removes vchiq_log_warning() macro > Patch 4/5 removes vchiq_log_trace() macro > Patch 5/5 removes vchiq_log_debug() macro > > This completes the following TODO item: > > ``` > * Cleanup logging mechanism > > The driver should probably be using the standard kernel logging mechanisms > such as dev_info, dev_dbg, and friends. > ``` > > [1]: https://lore.kernel.org/linux-media/20231109210309.638594-1-umang.jain@ideasonboard.com/ > > Changes in v2: > - Separate out one fixup patch from v1 (Patch 1/9)and send separately > - Drop usage of log_type() and log_category() helpers. Directly use > dev_dbg() as suggested by Greg KH. > - Drop __func__ annotation from all logs. Dynamic debug has 'f' > decorator flag which can be used instead of manual __func__ > - Reword commit messages. > > Umang Jain (5): > staging: vc04_services: Do not pass NULL to vchiq_log_error() > staging: vc04_services: Drop vchiq_log_error() in favour of dev_dbg > staging: vc04_services: Drop vchiq_log_warning() in favour of dev_dbg > staging: vc04_services: Drop vchiq_log_trace() in favour of dev_dbg > staging: vc04_services: Drop vchiq_log_debug() in favour of dev_dbg > > drivers/staging/vc04_services/interface/TODO | 5 - > .../interface/vchiq_arm/vchiq_arm.c | 176 ++++---- > .../interface/vchiq_arm/vchiq_connected.c | 8 +- > .../interface/vchiq_arm/vchiq_connected.h | 4 +- > .../interface/vchiq_arm/vchiq_core.c | 402 +++++++++--------- > .../interface/vchiq_arm/vchiq_core.h | 38 -- > .../interface/vchiq_arm/vchiq_dev.c | 92 ++-- > 7 files changed, 315 insertions(+), 410 deletions(-) >
Hi Stefan, On 11/29/23 4:56 AM, Stefan Wahren wrote: > Hi Umang, > > Am 28.11.23 um 21:19 schrieb Umang Jain: >> This series also removes the vchiq_log_* macro and makes use of >> dev_dbg() >> directly. > sorry, i didn't had the time to follow the logging discussion, but the > following commits: > > staging: vc04: Convert vchiq_log_error() to use dynamic debug > staging: vc04: Convert vchiq_log_warning() to use dynamic debug > staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic debug > > changed the logging behavior. I don't think it's intended to move > everything to dev_dbg. > > I would expected the following mapping: > vchiq_log_error -> dev_err > vchiq_log_warning -> dev_warn For this I agree, > vchiq_log_info -> dev_info However, I think vchiq_log_info and vchiq_log_debug should be moved to dev_dbg. Otherwise, I think they'll spew a ton of information to dmesg by default. >> >> Patch 1/5 is fix. It prevents passing NULL to one of vchiq_log_error(). >> The function there in question, does not have any users as of >> now. However, it is going to be used by the vc-sm-cma and bcm2835-isp >> drivers (posted on list for review [1]). There was discussion on v1, >> whether I should drop and add the function later, however, didn't >> conclude. >> >> Patch 2/5 removes vchiq_log_error() macro >> Patch 3/5 removes vchiq_log_warning() macro >> Patch 4/5 removes vchiq_log_trace() macro >> Patch 5/5 removes vchiq_log_debug() macro >> >> This completes the following TODO item: >> >> ``` >> * Cleanup logging mechanism >> >> The driver should probably be using the standard kernel logging >> mechanisms >> such as dev_info, dev_dbg, and friends. >> ``` >> >> [1]: >> https://lore.kernel.org/linux-media/20231109210309.638594-1-umang.jain@ideasonboard.com/ >> >> Changes in v2: >> - Separate out one fixup patch from v1 (Patch 1/9)and send separately >> - Drop usage of log_type() and log_category() helpers. Directly use >> dev_dbg() as suggested by Greg KH. >> - Drop __func__ annotation from all logs. Dynamic debug has 'f' >> decorator flag which can be used instead of manual __func__ >> - Reword commit messages. >> >> Umang Jain (5): >> staging: vc04_services: Do not pass NULL to vchiq_log_error() >> staging: vc04_services: Drop vchiq_log_error() in favour of dev_dbg >> staging: vc04_services: Drop vchiq_log_warning() in favour of dev_dbg >> staging: vc04_services: Drop vchiq_log_trace() in favour of dev_dbg >> staging: vc04_services: Drop vchiq_log_debug() in favour of dev_dbg >> >> drivers/staging/vc04_services/interface/TODO | 5 - >> .../interface/vchiq_arm/vchiq_arm.c | 176 ++++---- >> .../interface/vchiq_arm/vchiq_connected.c | 8 +- >> .../interface/vchiq_arm/vchiq_connected.h | 4 +- >> .../interface/vchiq_arm/vchiq_core.c | 402 +++++++++--------- >> .../interface/vchiq_arm/vchiq_core.h | 38 -- >> .../interface/vchiq_arm/vchiq_dev.c | 92 ++-- >> 7 files changed, 315 insertions(+), 410 deletions(-) >> >
Hi Umang, Am 05.12.23 um 07:39 schrieb Umang Jain: > Hi Stefan, > > On 11/29/23 4:56 AM, Stefan Wahren wrote: >> Hi Umang, >> >> Am 28.11.23 um 21:19 schrieb Umang Jain: >>> This series also removes the vchiq_log_* macro and makes use of >>> dev_dbg() >>> directly. >> sorry, i didn't had the time to follow the logging discussion, but the >> following commits: >> >> staging: vc04: Convert vchiq_log_error() to use dynamic debug >> staging: vc04: Convert vchiq_log_warning() to use dynamic debug >> staging: vc04: Convert(and rename) vchiq_log_info() to use dynamic debug >> >> changed the logging behavior. I don't think it's intended to move >> everything to dev_dbg. >> >> I would expected the following mapping: >> vchiq_log_error -> dev_err >> vchiq_log_warning -> dev_warn > > For this I agree, >> vchiq_log_info -> dev_info > > However, I think vchiq_log_info and vchiq_log_debug should be moved to > dev_dbg. > > Otherwise, I think they'll spew a ton of information to dmesg by default. generally i agree. Unfortunately we need to double check every log message, because some of them are unnecessary. >>> >>> Patch 1/5 is fix. It prevents passing NULL to one of vchiq_log_error(). >>> The function there in question, does not have any users as of >>> now. However, it is going to be used by the vc-sm-cma and bcm2835-isp >>> drivers (posted on list for review [1]). There was discussion on v1, >>> whether I should drop and add the function later, however, didn't >>> conclude. >>> >>> Patch 2/5 removes vchiq_log_error() macro >>> Patch 3/5 removes vchiq_log_warning() macro >>> Patch 4/5 removes vchiq_log_trace() macro >>> Patch 5/5 removes vchiq_log_debug() macro >>> >>> This completes the following TODO item: >>> >>> ``` >>> * Cleanup logging mechanism >>> >>> The driver should probably be using the standard kernel logging >>> mechanisms >>> such as dev_info, dev_dbg, and friends. >>> ``` >>> >>> [1]: >>> https://lore.kernel.org/linux-media/20231109210309.638594-1-umang.jain@ideasonboard.com/ >>> >>> Changes in v2: >>> - Separate out one fixup patch from v1 (Patch 1/9)and send separately >>> - Drop usage of log_type() and log_category() helpers. Directly use >>> dev_dbg() as suggested by Greg KH. >>> - Drop __func__ annotation from all logs. Dynamic debug has 'f' >>> decorator flag which can be used instead of manual __func__ >>> - Reword commit messages. >>> >>> Umang Jain (5): >>> staging: vc04_services: Do not pass NULL to vchiq_log_error() >>> staging: vc04_services: Drop vchiq_log_error() in favour of dev_dbg >>> staging: vc04_services: Drop vchiq_log_warning() in favour of >>> dev_dbg >>> staging: vc04_services: Drop vchiq_log_trace() in favour of dev_dbg >>> staging: vc04_services: Drop vchiq_log_debug() in favour of dev_dbg >>> >>> drivers/staging/vc04_services/interface/TODO | 5 - >>> .../interface/vchiq_arm/vchiq_arm.c | 176 ++++---- >>> .../interface/vchiq_arm/vchiq_connected.c | 8 +- >>> .../interface/vchiq_arm/vchiq_connected.h | 4 +- >>> .../interface/vchiq_arm/vchiq_core.c | 402 >>> +++++++++--------- >>> .../interface/vchiq_arm/vchiq_core.h | 38 -- >>> .../interface/vchiq_arm/vchiq_dev.c | 92 ++-- >>> 7 files changed, 315 insertions(+), 410 deletions(-) >>> >> > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel