From patchwork Tue Nov 28 20:19:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13471728 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4706AC4167B for ; Tue, 28 Nov 2023 20:20:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=mJv0F49T3aNUP6drywF+zRXNYuClmDonpQOgi6nkPFo=; b=EeQdUUkGifkZWK YOgt4MRa0BFg65DA5ENCUVnRzKJccE1jmSMx/VyEEAIj6ah5XCucA66FhF9gAkDjhq9GgYENNhRKN fIciqMK9BMv0GmFaqmcY5iXBlTDeGYqIKlYruuTvY8jdm0VZ5vJhryZBaig6OIP6BegoydUXMvYEi VlFMAI4Jj4HWSZTF5WQfDrJmyt0sQ4ltxKaPpsSkpjriaDBsYQRZMPzQyHaKaHH02AnFO2h/AxyxH hXerulIk26SaV4OGFNfSSwx6NqG79QM3C+EuYP7Fmzn5BIk3U2OonTXjhWpOSMLbTzN+h/DIA5pDs hMRWGWBM3CD9SK1U4i0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r84YU-006FEZ-1w; Tue, 28 Nov 2023 20:19:38 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r84YR-006FDB-0m; Tue, 28 Nov 2023 20:19:36 +0000 Received: from umang.jain (unknown [103.238.109.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A1A16BEB; Tue, 28 Nov 2023 21:18:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701202738; bh=BYZnM8Xk87PhsS1AGfDd/LqFrgG9aXvrXv8so0BrbZo=; h=From:To:Cc:Subject:Date:From; b=sgneeDHbIQ2civmHWobsP+4TS7bjIePcEmPPjyH8m5Ebf5oghyomE2Qz0gzw4KdkV 1LJtKZKthA8UHOz612xAcoCofVhnOKoWv4Sho7n4ESDdI6meCnMaJAb4F50ITCYNMc yAtY7IZ/WEsktCXkwxRE5UxZJo3ahJbMmh77/PFg= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Dave Stevenson , "Ricardo B . Marliere" , Umang Jain Subject: [PATCH v2 0/5] staging: vc04_services: Drop custom logging Date: Wed, 29 Nov 2023 01:49:21 +0530 Message-ID: <20231128201926.489269-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231128_121935_420598_3BC12440 X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series also removes the vchiq_log_* macro and makes use of dev_dbg() directly. Patch 1/5 is fix. It prevents passing NULL to one of vchiq_log_error(). The function there in question, does not have any users as of now. However, it is going to be used by the vc-sm-cma and bcm2835-isp drivers (posted on list for review [1]). There was discussion on v1, whether I should drop and add the function later, however, didn't conclude. Patch 2/5 removes vchiq_log_error() macro Patch 3/5 removes vchiq_log_warning() macro Patch 4/5 removes vchiq_log_trace() macro Patch 5/5 removes vchiq_log_debug() macro This completes the following TODO item: ``` * Cleanup logging mechanism The driver should probably be using the standard kernel logging mechanisms such as dev_info, dev_dbg, and friends. ``` [1]: https://lore.kernel.org/linux-media/20231109210309.638594-1-umang.jain@ideasonboard.com/ Changes in v2: - Separate out one fixup patch from v1 (Patch 1/9)and send separately - Drop usage of log_type() and log_category() helpers. Directly use dev_dbg() as suggested by Greg KH. - Drop __func__ annotation from all logs. Dynamic debug has 'f' decorator flag which can be used instead of manual __func__ - Reword commit messages. Umang Jain (5): staging: vc04_services: Do not pass NULL to vchiq_log_error() staging: vc04_services: Drop vchiq_log_error() in favour of dev_dbg staging: vc04_services: Drop vchiq_log_warning() in favour of dev_dbg staging: vc04_services: Drop vchiq_log_trace() in favour of dev_dbg staging: vc04_services: Drop vchiq_log_debug() in favour of dev_dbg drivers/staging/vc04_services/interface/TODO | 5 - .../interface/vchiq_arm/vchiq_arm.c | 176 ++++---- .../interface/vchiq_arm/vchiq_connected.c | 8 +- .../interface/vchiq_arm/vchiq_connected.h | 4 +- .../interface/vchiq_arm/vchiq_core.c | 402 +++++++++--------- .../interface/vchiq_arm/vchiq_core.h | 38 -- .../interface/vchiq_arm/vchiq_dev.c | 92 ++-- 7 files changed, 315 insertions(+), 410 deletions(-)