From patchwork Tue Nov 28 20:20:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13471734 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5839BC4167B for ; Tue, 28 Nov 2023 20:20:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=24CYSo/tO9q/R1NUB22HmUk6douufJDFO7rjIFLx2KU=; b=xGcJ/0Ajo1duet AupjfNUeycorzEES5VLXV7/yLDqhhvzf0N+JymokUZr2ghtD3SbfKFaCLUMe57dMmhmXY8+/p3anB Yd1NRd3/JcnTZLfCt5O3rZf76omW1KEuPxBj1Xbc0ha9h9df2w6dzlgMhPuttLzGV41Pe94BMbdjg rRFSkKe5IrnHclhiXN6qBMi/CXbFWf+hljvg/sMhf4aTobnM8DmPDdOsWTJmXcnFoFwj6s5pV/I99 sRa1VR+WG8tmnkjpxjQzMZ9HB4rhTjzSy1VPY/9Xejtd1+NLJV7m61FsMmCmmL2Pg121Hu1T0WtMk bYtvYtaeRQcuIHLt5/+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r84ZG-006FYp-0q; Tue, 28 Nov 2023 20:20:26 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r84Z7-006FTK-0J; Tue, 28 Nov 2023 20:20:18 +0000 Received: from umang.jain (unknown [103.238.109.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AE172BEB; Tue, 28 Nov 2023 21:19:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701202780; bh=V86/cbCbHiagWTupbqgzreO3inz+r/czMmxJcGbc2mM=; h=From:To:Cc:Subject:Date:From; b=VprCKMsqvT63+6msl38ZysoN4X/EfMIyq9TBEG3Ew/jUNxMKDH5p45EURCHjs0zkQ EXKDkJWkMv8AIwGzi2BSuXVZQOiLfE4ghoewDSUupwNCLcv7RDatMOG1ihjkpkkLEZ qwBuOb0rDy+zyRpT/8uxGDef18wIQi8AGtvNoMbE= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Dave Stevenson , "Ricardo B . Marliere" , Umang Jain Subject: [PATCH v2 0/2] staging: vc04_services: Use %p to log pointer Date: Wed, 29 Nov 2023 01:50:05 +0530 Message-ID: <20231128202007.489294-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231128_122017_272251_03CDB678 X-CRM114-Status: UNSURE ( 8.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org %lx is used to print the unmodified pointer address for debugging. %p will print the hashed pointer address to avoid leaking information about kernel memory layout to userspace. But when `no_hash_pointers` is passed as kernel parameter, unmodified pointer address will be printed. Hence, drop %lx in favour of %p. For debugging purposes, one can easily depend on `no_hash_pointers`. This also solves the following smatch warnings: service_callback() warn: argument 7 to %lx specifier is cast from pointer service_callback() warn: argument 11 to %lx specifier is cast from pointer service_callback() warn: argument 12 to %lx specifier is cast from pointer service_callback() warn: argument 13 to %lx specifier is cast from pointer vchiq_release() warn: argument 7 to %lx specifier is cast from pointer Changes in v2: - Built/Rebased on top of: [PATCH v2 0/5] staging: vc04_services: Drop custom logging Umang Jain (2): staging: vc04_services: Use %p to log pointer address staging: vc04_services: Use %p to log pointer address .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 7 +++---- .../staging/vc04_services/interface/vchiq_arm/vchiq_dev.c | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-)