| Message ID | 20231128213536.3764212-1-sjoerd@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Moxtet bus fixes | expand |
Hello Marek and Sjoerd, > It seems the moxtet bus support was broken since 21aad8ba615e ("arm64: > dts: armada-3720-turris-mox: Add missing interrupt for RTC") for two > reasons: > * The moxtet irq isn't marked as shared so the driver fails to load if > the rtc driver gets set up first. > * The dts change didn't set the IRQ type, so in case the rtc driver got > probed first irq setup ended up wrong (rising instead of falling edge). > > On top of that the moxtet module isn't auto-loading due to a missing spi > table > > Changes in v2: > - Add cover letter > - Add patch to set the irq type > > Sjoerd Simons (3): > bus: moxtet: Mark the irq as shared > bus: moxtet: Add spi device table > arm64: dts: armada-3720-turris-mox: set irq type for RTC I only received the previous patch in my inbox, I plan to apply it. But what about the 2 other patches ? Marek will you do a pull request with these 2 patches or do you expect that I take them also ? Regards, Gregory > > arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +- > drivers/bus/moxtet.c | 9 ++++++++- > 2 files changed, 9 insertions(+), 2 deletions(-) > > -- > 2.43.0 >
On Fri, 08 Dec 2023 15:51:20 +0100 Gregory CLEMENT <gregory.clement@bootlin.com> wrote: > Hello Marek and Sjoerd, > > > It seems the moxtet bus support was broken since 21aad8ba615e ("arm64: > > dts: armada-3720-turris-mox: Add missing interrupt for RTC") for two > > reasons: > > * The moxtet irq isn't marked as shared so the driver fails to load if > > the rtc driver gets set up first. > > * The dts change didn't set the IRQ type, so in case the rtc driver got > > probed first irq setup ended up wrong (rising instead of falling edge). > > > > On top of that the moxtet module isn't auto-loading due to a missing spi > > table > > > > Changes in v2: > > - Add cover letter > > - Add patch to set the irq type > > > > Sjoerd Simons (3): > > bus: moxtet: Mark the irq as shared > > bus: moxtet: Add spi device table > > arm64: dts: armada-3720-turris-mox: set irq type for RTC > > I only received the previous patch in my inbox, I plan to apply it. But > what about the 2 other patches ? Marek will you do a pull request with > these 2 patches or do you expect that I take them also ? > > Regards, > > Gregory Gregory, as of yet I've never done a pull request. If you are willing to take all 3 patches now, please do. In the future I would like to start doing it for Turris stuff, if you are OK with it. Marek
Marek Behún <kabel@kernel.org> writes: > On Fri, 08 Dec 2023 15:51:20 +0100 > Gregory CLEMENT <gregory.clement@bootlin.com> wrote: > >> Hello Marek and Sjoerd, >> >> > It seems the moxtet bus support was broken since 21aad8ba615e ("arm64: >> > dts: armada-3720-turris-mox: Add missing interrupt for RTC") for two >> > reasons: >> > * The moxtet irq isn't marked as shared so the driver fails to load if >> > the rtc driver gets set up first. >> > * The dts change didn't set the IRQ type, so in case the rtc driver got >> > probed first irq setup ended up wrong (rising instead of falling edge). >> > >> > On top of that the moxtet module isn't auto-loading due to a missing spi >> > table >> > >> > Changes in v2: >> > - Add cover letter >> > - Add patch to set the irq type >> > >> > Sjoerd Simons (3): >> > bus: moxtet: Mark the irq as shared >> > bus: moxtet: Add spi device table >> > arm64: dts: armada-3720-turris-mox: set irq type for RTC >> >> I only received the previous patch in my inbox, I plan to apply it. But >> what about the 2 other patches ? Marek will you do a pull request with >> these 2 patches or do you expect that I take them also ? >> >> Regards, >> >> Gregory > > Gregory, as of yet I've never done a pull request. If you are willing > to take all 3 patches now, please do. In the future I would like to OK I applied them on mvebu/driver. > start doing it for Turris stuff, if you are OK with it. No pb, just tell me when you are going to doing it. Gregory > > Marek
On Fri, 2023-12-15 at 15:47 +0100, Gregory CLEMENT wrote: > Marek Behún <kabel@kernel.org> writes: > > > On Fri, 08 Dec 2023 15:51:20 +0100 > > Gregory CLEMENT <gregory.clement@bootlin.com> wrote: > > > > Gregory, as of yet I've never done a pull request. If you are > > willing > > to take all 3 patches now, please do. In the future I would like to > > OK I applied them on mvebu/driver. Thanks both for moving this patches forward; Gregory looks like you only applied two of the three patches (missing the dt patch), are you expect that to flow through a different tree or ? Regards,
Sjoerd Simons <sjoerd@collabora.com> writes: > On Fri, 2023-12-15 at 15:47 +0100, Gregory CLEMENT wrote: >> Marek Behún <kabel@kernel.org> writes: >> >> > On Fri, 08 Dec 2023 15:51:20 +0100 >> > Gregory CLEMENT <gregory.clement@bootlin.com> wrote: >> > >> > Gregory, as of yet I've never done a pull request. If you are >> > willing >> > to take all 3 patches now, please do. In the future I would like to >> >> OK I applied them on mvebu/driver. > > Thanks both for moving this patches forward; Gregory looks like you > only applied two of the three patches (missing the dt patch), are you > expect that to flow through a different tree or ? The device tree patch is applied on mvebu/dt64, I've just pushed the updated branch, but it was already in the for-next branch. Gregory > > > Regards, > -- > Sjoerd Simons > Collabora Ltd.
It seems the moxtet bus support was broken since 21aad8ba615e ("arm64: dts: armada-3720-turris-mox: Add missing interrupt for RTC") for two reasons: * The moxtet irq isn't marked as shared so the driver fails to load if the rtc driver gets set up first. * The dts change didn't set the IRQ type, so in case the rtc driver got probed first irq setup ended up wrong (rising instead of falling edge). On top of that the moxtet module isn't auto-loading due to a missing spi table Changes in v2: - Add cover letter - Add patch to set the irq type Sjoerd Simons (3): bus: moxtet: Mark the irq as shared bus: moxtet: Add spi device table arm64: dts: armada-3720-turris-mox: set irq type for RTC arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 2 +- drivers/bus/moxtet.c | 9 ++++++++- 2 files changed, 9 insertions(+), 2 deletions(-)