[v5,00/10] dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards

Message

Josua Mayer Jan. 4, 2024, 5:48 p.m. UTC

Dear Maintainers,

The initially merged device-tree for Clearfog GTR devices contained
various subtle mistakes and omissions:

- missing board-specific compatible strings
- missing pinctrl entries
- missing second sfp connector
- invalid sfp loss-of-signal gpio
- mismatch of labels between dsa ports and enclosure

Most notably this had caused functional issues with the sfp connectors.

This patch-set first converts the existing armada-38x dt-bindings to
yaml, replacing invalid soc-only compatibles with specific boards that
already exist in tree and represent the three SoCs (380,385,388).

Secondly for clearfog gtr pinctrl nodes are added for all referenced
gpios for independence from bootloader defaults. U-Boot is shared
between armada-388 clearfog and armada-385 clearfog gtr.

Further remove an invalid io from the first sfp connector description,
and add descriptions for the secondary sfp connector which is driven
by dsa switch port number 9.

Finally labels of dsa switch ports were updated to match the enclosure.
That patch is not suitable for stable.

Signed-off-by: Josua Mayer <[e-mail]>
---
Changes in v5:
- remove empty lines between description and items yaml entries
  (reported by Krzysztof Kozlowski <[e-mail]>)
- bindings text to yaml conversion is now single commit
  (reported by Krzysztof Kozlowski <[e-mail]>)
- added bindings for some existing a380, a385 and a388 boards
- removed code from commit description
  (reported by Krzysztof Kozlowski <[e-mail]>)
- Link to v4: https://lore.kernel.org/r/[e-mail]

Changes in v4:
- dropped invalid soc-only armada-38x (txt) bindings
  (reported by Krzysztof Kozlowski <[e-mail]>)
- add bindings for armada 388 helios-4
- updated yaml whitespace indentation count
  (reported by Rob Hering's bot)
- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:
- armada-38x.yaml: removed '|', no need to prerserve formatting
  (reported by Conor Dooley [e-mail])
- update commit descriptions to clarify confusing board names and
  compatible strings
  (reported by Krzysztof Kozlowski <[e-mail]>)
- send to all relevant lists
  (reported by Krzysztof Kozlowski <[e-mail]>)
- remove duplicate binding for clearfog / clearfog
- Link to v2 (patches 0-2):
  https://lore.kernel.org/r/[e-mail]
- Link to v2 (patches 3-8):
  https://lore.kernel.org/r/[e-mail]

Changes in v2:
- removed changes changes to gpio numbers because they were wrong
- added bindings documentation
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Josua Mayer (10):
      dt-bindings: marvell: a38x: convert soc compatibles to yaml
      dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards
      dt-bindings: marvell: a38x: add kobol helios-4 board
      dt-bindings: marvell: a38x: add solidrun armada 385 clearfog gtr boards
      arm: dts: marvell: clearfog: add pro variant compatible in legacy dts
      arm: dts: marvell: clearfog-gtr: add board-specific compatible strings
      arm: dts: marvell: clearfog-gtr: sort pinctrl nodes alphabetically
      arm: dts: marvell: clearfog-gtr: add missing pinctrl for all used gpios
      arm: dts: marvell: clearfog-gtr-l8: add support for second sfp connector
      arm: dts: marvell: clearfog-gtr-l8: align port numbers with enclosure

 .../devicetree/bindings/arm/marvell/armada-38x.txt | 27 -------
 .../bindings/arm/marvell/armada-38x.yaml           | 70 ++++++++++++++++++
 .../dts/marvell/armada-385-clearfog-gtr-l8.dts     | 38 +++++++---
 .../dts/marvell/armada-385-clearfog-gtr-s4.dts     |  2 +
 .../boot/dts/marvell/armada-385-clearfog-gtr.dtsi  | 84 ++++++++++++++++------
 arch/arm/boot/dts/marvell/armada-388-clearfog.dts  |  5 +-
 6 files changed, 167 insertions(+), 59 deletions(-)
---
base-commit: 861deac3b092f37b2c5e6871732f3e11486f7082
change-id: 20231226-support-clearfog-gtr-l8-sfp-d87ae715a787

Sincerely,

Comments

Gregory CLEMENT Feb. 27, 2024, 4:25 p.m. UTC | #1

Hello Josua Mayer,

> Dear Maintainers,
>
> The initially merged device-tree for Clearfog GTR devices contained
> various subtle mistakes and omissions:
>
> - missing board-specific compatible strings
> - missing pinctrl entries
> - missing second sfp connector
> - invalid sfp loss-of-signal gpio
> - mismatch of labels between dsa ports and enclosure
>
> Most notably this had caused functional issues with the sfp connectors.
>
> This patch-set first converts the existing armada-38x dt-bindings to
> yaml, replacing invalid soc-only compatibles with specific boards that
> already exist in tree and represent the three SoCs (380,385,388).
>
> Secondly for clearfog gtr pinctrl nodes are added for all referenced
> gpios for independence from bootloader defaults. U-Boot is shared
> between armada-388 clearfog and armada-385 clearfog gtr.
>
> Further remove an invalid io from the first sfp connector description,
> and add descriptions for the secondary sfp connector which is driven
> by dsa switch port number 9.
>
> Finally labels of dsa switch ports were updated to match the enclosure.
> That patch is not suitable for stable.
>
> Signed-off-by: Josua Mayer <[e-mail]>


Rebased on v6.8-rc1, fixed merge conflict and applied on mvebu/dt

Thanks,

Gregory

> ---
> Changes in v5:
> - remove empty lines between description and items yaml entries
>   (reported by Krzysztof Kozlowski <[e-mail]>)
> - bindings text to yaml conversion is now single commit
>   (reported by Krzysztof Kozlowski <[e-mail]>)
> - added bindings for some existing a380, a385 and a388 boards
> - removed code from commit description
>   (reported by Krzysztof Kozlowski <[e-mail]>)
> - Link to v4: https://lore.kernel.org/r/[e-mail]
>
> Changes in v4:
> - dropped invalid soc-only armada-38x (txt) bindings
>   (reported by Krzysztof Kozlowski <[e-mail]>)
> - add bindings for armada 388 helios-4
> - updated yaml whitespace indentation count
>   (reported by Rob Hering's bot)
> - Link to v3: https://lore.kernel.org/r/[e-mail]
>
> Changes in v3:
> - armada-38x.yaml: removed '|', no need to prerserve formatting
>   (reported by Conor Dooley [e-mail])
> - update commit descriptions to clarify confusing board names and
>   compatible strings
>   (reported by Krzysztof Kozlowski <[e-mail]>)
> - send to all relevant lists
>   (reported by Krzysztof Kozlowski <[e-mail]>)
> - remove duplicate binding for clearfog / clearfog
> - Link to v2 (patches 0-2):
>   https://lore.kernel.org/r/[e-mail]
> - Link to v2 (patches 3-8):
>   https://lore.kernel.org/r/[e-mail]
>
> Changes in v2:
> - removed changes changes to gpio numbers because they were wrong
> - added bindings documentation
> - Link to v1: https://lore.kernel.org/r/[e-mail]
>
> ---
> Josua Mayer (10):
>       dt-bindings: marvell: a38x: convert soc compatibles to yaml
>       dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards
>       dt-bindings: marvell: a38x: add kobol helios-4 board
>       dt-bindings: marvell: a38x: add solidrun armada 385 clearfog gtr boards
>       arm: dts: marvell: clearfog: add pro variant compatible in legacy dts
>       arm: dts: marvell: clearfog-gtr: add board-specific compatible strings
>       arm: dts: marvell: clearfog-gtr: sort pinctrl nodes alphabetically
>       arm: dts: marvell: clearfog-gtr: add missing pinctrl for all used gpios
>       arm: dts: marvell: clearfog-gtr-l8: add support for second sfp connector
>       arm: dts: marvell: clearfog-gtr-l8: align port numbers with enclosure
>
>  .../devicetree/bindings/arm/marvell/armada-38x.txt | 27 -------
>  .../bindings/arm/marvell/armada-38x.yaml           | 70 ++++++++++++++++++
>  .../dts/marvell/armada-385-clearfog-gtr-l8.dts     | 38 +++++++---
>  .../dts/marvell/armada-385-clearfog-gtr-s4.dts     |  2 +
>  .../boot/dts/marvell/armada-385-clearfog-gtr.dtsi  | 84 ++++++++++++++++------
>  arch/arm/boot/dts/marvell/armada-388-clearfog.dts  |  5 +-
>  6 files changed, 167 insertions(+), 59 deletions(-)
> ---
> base-commit: 861deac3b092f37b2c5e6871732f3e11486f7082
> change-id: 20231226-support-clearfog-gtr-l8-sfp-d87ae715a787
>
> Sincerely,
> -- 
> Josua Mayer <[e-mail]>
>