| Message ID | 20240211-add-am64-som-v5-0-790ed7121249@solid-run.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: dts: add description for solidrun am642 som and hummingboard evb | expand |
Hi Josua, On 11/02/24 20:37, Josua Mayer wrote: > This series adds DT bindings and dts descriptions for SolidRun AM642 > based SoM and Hummingboard EVB. > > Additionally a commit from downstream vendor kernel are included, > enhancing support for pru based ethernet. > I wasn't sure how to properly annotate it in commit description / > signed-off area ...: > > 1. add description for "Industrial Ethernet Peripherals" (IEP) to am64 > https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/arch/arm64/boot/dts/ti/k3-am64-main.dtsi?h=ti-linux-6.1.y-cicd&id=5afb73d82a014b59462162d960b350b8c58e5ae6 > IEP is already supported in-tree by a driver, and used in > k3-am65-main.dtsi. > > Unfortunately dtbs_check reported many problems, I put some remarks: > > - 'mux-controller' does not match any of the regexes > The expectation seems to be that a mux-controller at minimum has an > address, something to put behind an @. However this is a gpio mux, not > sure how to name it better. > I don't see this warning locally. Are you using updated dt-schema? reg is not necessary gpio-mux as per gpio-mux.yaml > - unevaluated properties: interrupts, interrupt-parent > sensors and flash yaml are missing interrupt descriptions, but these > parts definitely have an interrupt signal in this solidrun board. > Please add them to appropriate schema as necessary > - wrong names for pinctrl nodes > Other TI DTSs consistently end with *-pins-default. Should a different > naming convention be used? > No, pinctrl nodes need to end in -pins. All TI boards have been updated to new schema [0] and sysconfig tool on dev.ti.com/sysconfig generates appropriately. Please fix > - cdns,phy-type required property > inherited from k3-am64-main.dtsi > there is a PHY_NONE value in dt-bindings/phy/phy.h, > but not allowed in phy-cadence-torrent.yaml > Sorry, I didnt get what's the issue wrt cdns,phy-type ? Note, I really don't want to accept patches that add new dtbs_check issues especially for nodes that already have YAML bindings. Please update the .yaml files as necessary. [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a49568115143435390f20965902809471b6f830c
Hi Vignesh, Am 12.02.24 um 05:10 schrieb Vignesh Raghavendra: > Hi Josua, > > On 11/02/24 20:37, Josua Mayer wrote: >> This series adds DT bindings and dts descriptions for SolidRun AM642 >> based SoM and Hummingboard EVB. >> >> Additionally a commit from downstream vendor kernel are included, >> enhancing support for pru based ethernet. >> I wasn't sure how to properly annotate it in commit description / >> signed-off area ...: >> >> 1. add description for "Industrial Ethernet Peripherals" (IEP) to am64 >> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/arch/arm64/boot/dts/ti/k3-am64-main.dtsi?h=ti-linux-6.1.y-cicd&id=5afb73d82a014b59462162d960b350b8c58e5ae6 >> IEP is already supported in-tree by a driver, and used in >> k3-am65-main.dtsi. >> >> Unfortunately dtbs_check reported many problems, I put some remarks: >> >> - 'mux-controller' does not match any of the regexes >> The expectation seems to be that a mux-controller at minimum has an >> address, something to put behind an @. However this is a gpio mux, not >> sure how to name it better. >> > I don't see this warning locally. Are you using updated dt-schema? pip3 install dtschema --upgrade Defaulting to user installation because normal site-packages is not writeable Requirement already satisfied: dtschema in ~/.local/lib/python3.11/site-packages (2023.11) Re-Tested on 6.8-rc1 > reg > is not necessary gpio-mux as per gpio-mux.yaml The error is not about reg property, it is about the node name: mux-controller { compatible = "gpio-mux"; ... }; DTC_CHK arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dtb .../arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dtb: syscon@43000000: 'mux-controller' does not match any of the regexes: '^chipid@[0-9a-f]+$', '^clock-controller@[0-9a-f]+$', '^mux-controller@[0-9a-f]+$', 'phy@[0-9a-f]+$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/mfd/ti,j721e-system-controller.yaml# > >> - unevaluated properties: interrupts, interrupt-parent >> sensors and flash yaml are missing interrupt descriptions, but these >> parts definitely have an interrupt signal in this solidrun board. >> > Please add them to appropriate schema as necessary Okay. Looks like it is only two: .../arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dtb: humidity-sensor@41: 'interrupt-parent', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/iio/humidity/ti,hdc2010.yaml# .../arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dtb: flash@0: Unevaluated properties are not allowed ('interrupt-parent', 'interrupts' were unexpected) from schema $id: http://devicetree.org/schemas/mtd/jedec,spi-nor.yaml# > >> - wrong names for pinctrl nodes >> Other TI DTSs consistently end with *-pins-default. Should a different >> naming convention be used? >> > No, pinctrl nodes need to end in -pins. All TI boards have been updated > to new schema [0] and sysconfig tool on dev.ti.com/sysconfig generates > appropriately. Please fix Okay, will do ... > > >> - cdns,phy-type required property >> inherited from k3-am64-main.dtsi >> there is a PHY_NONE value in dt-bindings/phy/phy.h, >> but not allowed in phy-cadence-torrent.yaml >> > Sorry, I didnt get what's the issue wrt cdns,phy-type ? There were two issues, but they both disappeared as per 6.8-rc1 :) > > > Note, I really don't want to accept patches that add new dtbs_check > issues especially for nodes that already have YAML bindings. Please > update the .yaml files as necessary. I have succeeded locally getting rid of all but one, the node name of mux-controller mentioned above. Will include yaml patches in next version. > > [0] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a49568115143435390f20965902809471b6f830c > >
On 2/12/24 10:39 AM, Josua Mayer wrote: > Hi Vignesh, > > Am 12.02.24 um 05:10 schrieb Vignesh Raghavendra: >> Hi Josua, >> >> On 11/02/24 20:37, Josua Mayer wrote: >>> This series adds DT bindings and dts descriptions for SolidRun AM642 >>> based SoM and Hummingboard EVB. >>> >>> Additionally a commit from downstream vendor kernel are included, >>> enhancing support for pru based ethernet. >>> I wasn't sure how to properly annotate it in commit description / >>> signed-off area ...: >>> >>> 1. add description for "Industrial Ethernet Peripherals" (IEP) to am64 >>> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/arch/arm64/boot/dts/ti/k3-am64-main.dtsi?h=ti-linux-6.1.y-cicd&id=5afb73d82a014b59462162d960b350b8c58e5ae6 >>> IEP is already supported in-tree by a driver, and used in >>> k3-am65-main.dtsi. >>> >>> Unfortunately dtbs_check reported many problems, I put some remarks: >>> >>> - 'mux-controller' does not match any of the regexes >>> The expectation seems to be that a mux-controller at minimum has an >>> address, something to put behind an @. However this is a gpio mux, not >>> sure how to name it better. >>> >> I don't see this warning locally. Are you using updated dt-schema? > pip3 install dtschema --upgrade > Defaulting to user installation because normal site-packages is not writeable > Requirement already satisfied: dtschema in ~/.local/lib/python3.11/site-packages (2023.11) > > Re-Tested on 6.8-rc1 > >> reg >> is not necessary gpio-mux as per gpio-mux.yaml > The error is not about reg property, it is about the node name: > > mux-controller { > compatible = "gpio-mux"; > ... > }; > > DTC_CHK arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dtb > .../arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dtb: syscon@43000000: 'mux-controller' does not match any of the regexes: '^chipid@[0-9a-f]+$', '^clock-controller@[0-9a-f]+$', '^mux-controller@[0-9a-f]+$', 'phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/mfd/ti,j721e-system-controller.yaml# This is an existing issue that we are working to fix. Nothing you can do about it, all boards that include k3-am64-main.dtsi will have this warning currently. Andrew >> >>> - unevaluated properties: interrupts, interrupt-parent >>> sensors and flash yaml are missing interrupt descriptions, but these >>> parts definitely have an interrupt signal in this solidrun board. >>> >> Please add them to appropriate schema as necessary > Okay. > Looks like it is only two: > .../arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dtb: humidity-sensor@41: 'interrupt-parent', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/iio/humidity/ti,hdc2010.yaml# > .../arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dtb: flash@0: Unevaluated properties are not allowed ('interrupt-parent', 'interrupts' were unexpected) > from schema $id: http://devicetree.org/schemas/mtd/jedec,spi-nor.yaml# >> >>> - wrong names for pinctrl nodes >>> Other TI DTSs consistently end with *-pins-default. Should a different >>> naming convention be used? >>> >> No, pinctrl nodes need to end in -pins. All TI boards have been updated >> to new schema [0] and sysconfig tool on dev.ti.com/sysconfig generates >> appropriately. Please fix > Okay, will do ... >> >> >>> - cdns,phy-type required property >>> inherited from k3-am64-main.dtsi >>> there is a PHY_NONE value in dt-bindings/phy/phy.h, >>> but not allowed in phy-cadence-torrent.yaml >>> >> Sorry, I didnt get what's the issue wrt cdns,phy-type ? > There were two issues, but they both disappeared as per 6.8-rc1 :) >> >> >> Note, I really don't want to accept patches that add new dtbs_check >> issues especially for nodes that already have YAML bindings. Please >> update the .yaml files as necessary. > I have succeeded locally getting rid of all but one, the node name of mux-controller mentioned above. > Will include yaml patches in next version. >> >> [0] >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a49568115143435390f20965902809471b6f830c >> >>
On 12/02/24 22:09, Josua Mayer wrote: > Hi Vignesh, > > Am 12.02.24 um 05:10 schrieb Vignesh Raghavendra: >> Hi Josua, >> >> On 11/02/24 20:37, Josua Mayer wrote: >>> This series adds DT bindings and dts descriptions for SolidRun AM642 >>> based SoM and Hummingboard EVB. >>> >>> Additionally a commit from downstream vendor kernel are included, >>> enhancing support for pru based ethernet. >>> I wasn't sure how to properly annotate it in commit description / >>> signed-off area ...: >>> >>> 1. add description for "Industrial Ethernet Peripherals" (IEP) to am64 >>> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/arch/arm64/boot/dts/ti/k3-am64-main.dtsi?h=ti-linux-6.1.y-cicd&id=5afb73d82a014b59462162d960b350b8c58e5ae6 >>> IEP is already supported in-tree by a driver, and used in >>> k3-am65-main.dtsi. >>> >>> Unfortunately dtbs_check reported many problems, I put some remarks: >>> >>> - 'mux-controller' does not match any of the regexes >>> The expectation seems to be that a mux-controller at minimum has an >>> address, something to put behind an @. However this is a gpio mux, not >>> sure how to name it better. >>> >> I don't see this warning locally. Are you using updated dt-schema? > pip3 install dtschema --upgrade > Defaulting to user installation because normal site-packages is not writeable > Requirement already satisfied: dtschema in ~/.local/lib/python3.11/site-packages (2023.11) > > Re-Tested on 6.8-rc1 > >> reg >> is not necessary gpio-mux as per gpio-mux.yaml > The error is not about reg property, it is about the node name: > > mux-controller { > compatible = "gpio-mux"; > ... > }; > > DTC_CHK arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dtb > .../arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dtb: syscon@43000000: 'mux-controller' does not match any of the regexes: '^chipid@[0-9a-f]+$', '^clock-controller@[0-9a-f]+$', '^mux-controller@[0-9a-f]+$', 'phy@[0-9a-f]+$', 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/mfd/ti,j721e-system-controller.yaml# This warning exists not because of gpio-mux but because of SoC level (k3-am64-main.dtsi) dtsi issue. There is a separate series to fix the same. So this should be okay to ignore for now. >> >>> - unevaluated properties: interrupts, interrupt-parent >>> sensors and flash yaml are missing interrupt descriptions, but these >>> parts definitely have an interrupt signal in this solidrun board. >>> >> Please add them to appropriate schema as necessary > Okay. > Looks like it is only two: > .../arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dtb: humidity-sensor@41: 'interrupt-parent', 'interrupts' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/iio/humidity/ti,hdc2010.yaml# > .../arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dtb: flash@0: Unevaluated properties are not allowed ('interrupt-parent', 'interrupts' were unexpected) > from schema $id: http://devicetree.org/schemas/mtd/jedec,spi-nor.yaml# Yup, thanks! you could post a cut down version of the dts with all the problematic nodes removed until yaml updates are merged, so as to get the basic support in. >> >>> - wrong names for pinctrl nodes >>> Other TI DTSs consistently end with *-pins-default. Should a different >>> naming convention be used? >>> >> No, pinctrl nodes need to end in -pins. All TI boards have been updated >> to new schema [0] and sysconfig tool on dev.ti.com/sysconfig generates >> appropriately. Please fix > Okay, will do ... >> >> >>> - cdns,phy-type required property >>> inherited from k3-am64-main.dtsi >>> there is a PHY_NONE value in dt-bindings/phy/phy.h, >>> but not allowed in phy-cadence-torrent.yaml >>> >> Sorry, I didnt get what's the issue wrt cdns,phy-type ? > There were two issues, but they both disappeared as per 6.8-rc1 :) >> That's nice!
Hi [...] On 11/02/24 20:37, Josua Mayer wrote: > --- > Josua Mayer (4): > dt-bindings: arm: ti: Add bindings for SolidRun AM642 HummingBoard-T > dt-bindings: rtc: abx80x: convert to yaml 2/5 needs to go via RTC subsystem tree. Could you split it out into its own series when you respin Rest will go via TI K3 arch tree. > arm64: dts: add description for solidrun am642 som and evaluation board > arm64: dts: ti: hummingboard-t: add overlays for m.2 pci-e and usb-3 > > Suman Anna (1): > arm64: dts: ti: k3-am64-main: Add ICSSG IEP nodes > > Documentation/devicetree/bindings/arm/ti/k3.yaml | 7 + > .../devicetree/bindings/rtc/abracon,abx80x.txt | 31 -- > .../devicetree/bindings/rtc/abracon,abx80x.yaml | 79 +++ > arch/arm64/boot/dts/ti/Makefile | 7 + > arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 24 + > .../boot/dts/ti/k3-am642-hummingboard-t-pcie.dtso | 45 ++ > .../boot/dts/ti/k3-am642-hummingboard-t-usb3.dtso | 44 ++ > arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dts | 292 ++++++++++ > arch/arm64/boot/dts/ti/k3-am642-sr-som.dtsi | 594 +++++++++++++++++++++ > 9 files changed, 1092 insertions(+), 31 deletions(-) > --- > base-commit: 798d1ee1675be84d5c7eb639480aab33f2c8791e > change-id: 20240101-add-am64-som-51a1ca47edf3 > > Sincerely,
Am 13.02.24 um 07:12 schrieb Vignesh Raghavendra: > Hi > > [...] > > On 11/02/24 20:37, Josua Mayer wrote: >> --- >> Josua Mayer (4): >> dt-bindings: arm: ti: Add bindings for SolidRun AM642 HummingBoard-T > >> dt-bindings: rtc: abx80x: convert to yaml >> dt-bindings: iio: humidity: hdc20x0: add optional interrupts property >> dt-bindings: mtd: spi-nor: add optional interrupts property > 2/5 needs to go via RTC subsystem tree. Could you split it out into its > own series when you respin Only rtc, or should I split out the other two as well? > > Rest will go via TI K3 arch tree. > > >> arm64: dts: add description for solidrun am642 som and evaluation board >> arm64: dts: ti: hummingboard-t: add overlays for m.2 pci-e and usb-3 >> >> Suman Anna (1): >> arm64: dts: ti: k3-am64-main: Add ICSSG IEP nodes >> >> Documentation/devicetree/bindings/arm/ti/k3.yaml | 7 + >> .../devicetree/bindings/rtc/abracon,abx80x.txt | 31 -- >> .../devicetree/bindings/rtc/abracon,abx80x.yaml | 79 +++ >> arch/arm64/boot/dts/ti/Makefile | 7 + >> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 24 + >> .../boot/dts/ti/k3-am642-hummingboard-t-pcie.dtso | 45 ++ >> .../boot/dts/ti/k3-am642-hummingboard-t-usb3.dtso | 44 ++ >> arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dts | 292 ++++++++++ >> arch/arm64/boot/dts/ti/k3-am642-sr-som.dtsi | 594 +++++++++++++++++++++ >> 9 files changed, 1092 insertions(+), 31 deletions(-) >> --- >> base-commit: 798d1ee1675be84d5c7eb639480aab33f2c8791e >> change-id: 20240101-add-am64-som-51a1ca47edf3 >> >> Sincerely,
Hi, On 18/02/24 19:48, Josua Mayer wrote: > Am 13.02.24 um 07:12 schrieb Vignesh Raghavendra: >> Hi >> >> [...] >> >> On 11/02/24 20:37, Josua Mayer wrote: >>> --- >>> Josua Mayer (4): >>> dt-bindings: arm: ti: Add bindings for SolidRun AM642 >>> HummingBoard-T This goes via TI K3 arch tree >> >>> dt-bindings: rtc: abx80x: convert to yaml >>> dt-bindings: iio: humidity: hdc20x0: add optional interrupts >>> property >>> dt-bindings: mtd: spi-nor: add optional interrupts property >> 2/5 needs to go via RTC subsystem tree. Could you split it out into its >> own series when you respin > Only rtc, or should I split out the other two as well? Split others too. RTC, IIO and SPI-NOR related bindings should go via respective trees. Please post them individually to appropriate lists. Regards Vignesh
This series adds DT bindings and dts descriptions for SolidRun AM642 based SoM and Hummingboard EVB. Additionally a commit from downstream vendor kernel are included, enhancing support for pru based ethernet. I wasn't sure how to properly annotate it in commit description / signed-off area ...: 1. add description for "Industrial Ethernet Peripherals" (IEP) to am64 https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/arch/arm64/boot/dts/ti/k3-am64-main.dtsi?h=ti-linux-6.1.y-cicd&id=5afb73d82a014b59462162d960b350b8c58e5ae6 IEP is already supported in-tree by a driver, and used in k3-am65-main.dtsi. Unfortunately dtbs_check reported many problems, I put some remarks: - 'mux-controller' does not match any of the regexes The expectation seems to be that a mux-controller at minimum has an address, something to put behind an @. However this is a gpio mux, not sure how to name it better. - unevaluated properties: interrupts, interrupt-parent sensors and flash yaml are missing interrupt descriptions, but these parts definitely have an interrupt signal in this solidrun board. - wrong names for pinctrl nodes Other TI DTSs consistently end with *-pins-default. Should a different naming convention be used? - cdns,phy-type required property inherited from k3-am64-main.dtsi there is a PHY_NONE value in dt-bindings/phy/phy.h, but not allowed in phy-cadence-torrent.yaml Signed-off-by: Josua Mayer <josua@solid-run.com> --- Changes in v5: - abracon,abx80x.yaml: - reworded 'compatible' description - removed $ref to interrupts.yaml - nested example in fake i2c - changed maintainer to rtc list (reported by Conor Dooley <conor@kernel.org>) - patch 4/5 dts: - re-added status properties for sdhci nodes k3-am64-main.dtsi has been changed in-tree since v1 such that sdhci nodes are explicitly status disabled now. - picked up reviewed-by (reported by Andrew Davis <afd@ti.com>) - Link to v4: https://lore.kernel.org/r/20240202-add-am64-som-v4-0-5f8b12af5e71@solid-run.com Changes in v4: - abracon,abx80x.yaml: fixed dtc error in example irq reference - Link to v3: https://lore.kernel.org/r/20240202-add-am64-som-v3-0-2f44023d50e9@solid-run.com Changes in v3: - removed lots more status properties, double-checked against soc dtsi (reported by Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>) (reported by Andrew Davis <afd@ti.com>) - removed intentionally-disabled pcie node from dts - rewrote yaml bindings to use enum instead of anyof+const+description (reported by Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>) - abracon yaml - added missing maintainer - added diode type property type - added example (reported by Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>) - added reference to /schemas/interrupts.yaml# - use generic name for pru ethernet controller node (reported by Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>) - removed unnamed dmas from pru ethernet controller node - moved pcie/usb3 features to dtb overlays - Link to v2: https://lore.kernel.org/r/20240112-add-am64-som-v2-0-1385246c428c@solid-run.com Changes in v2: - reordered patchset to drop separate patch adding iep handle to som - moved dtbs_check warnings to cover letter - converted abracon abx80x rtc bindings to yaml - updated dts: - remove unnecessary status properties - changed non-generic node names - use color property for led descriptions, they have no default function on evaluation board - drop earlycon bootargs from chosen node (reported by Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>) - converted charger node to comment, part not assembled, has no bindings - picked up acked-by on board bindings patch - Link to v1: https://lore.kernel.org/r/20240103-add-am64-som-v1-0-dda1f9227aef@solid-run.com --- Josua Mayer (4): dt-bindings: arm: ti: Add bindings for SolidRun AM642 HummingBoard-T dt-bindings: rtc: abx80x: convert to yaml arm64: dts: add description for solidrun am642 som and evaluation board arm64: dts: ti: hummingboard-t: add overlays for m.2 pci-e and usb-3 Suman Anna (1): arm64: dts: ti: k3-am64-main: Add ICSSG IEP nodes Documentation/devicetree/bindings/arm/ti/k3.yaml | 7 + .../devicetree/bindings/rtc/abracon,abx80x.txt | 31 -- .../devicetree/bindings/rtc/abracon,abx80x.yaml | 79 +++ arch/arm64/boot/dts/ti/Makefile | 7 + arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 24 + .../boot/dts/ti/k3-am642-hummingboard-t-pcie.dtso | 45 ++ .../boot/dts/ti/k3-am642-hummingboard-t-usb3.dtso | 44 ++ arch/arm64/boot/dts/ti/k3-am642-hummingboard-t.dts | 292 ++++++++++ arch/arm64/boot/dts/ti/k3-am642-sr-som.dtsi | 594 +++++++++++++++++++++ 9 files changed, 1092 insertions(+), 31 deletions(-) --- base-commit: 798d1ee1675be84d5c7eb639480aab33f2c8791e change-id: 20240101-add-am64-som-51a1ca47edf3 Sincerely,