From patchwork Mon Feb 19 20:42:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13563102 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED584C48BC3 for ; Mon, 19 Feb 2024 20:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Z6SKrSM+yEizjGWqpjK9aEe8t04WUKzD/bYgx3cqrfo=; b=qJBmtqFBToRoEy vFDhigZjiQ7BrnRtyrpCKtwjTNREGOtUagUzIXw+qMMDy2KlmTturj/AR3eL67da+fGY+hA03lQ62 RRUk3UaWYN3C/Ad7+Tzp9aT8XgdismptzrEx9ub0krz5/QW79kzYYTzzZUJASeM8Byxp6haX+KMT0 Q/GzDd/xoUwHtXDWt42x1iyVrvbn5gA+NF7Z6wmVV4i+oXQqAuvM/D8OaUp0Ow5PekEwbz2oDN82/ zCJqZF8BaMadpIgtAPA9JrmC8uyKGuP6tWg3c5jkD873qMokGCVJL0zGP+pAan4z305FBGNWUBuf7 BSwQAIWnKvAxp8KrxAPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcATR-0000000C8Pa-3vKm; Mon, 19 Feb 2024 20:42:49 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcATM-0000000C8NQ-3zso for linux-arm-kernel@lists.infradead.org; Mon, 19 Feb 2024 20:42:47 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-41268a88cdaso7668175e9.2 for ; Mon, 19 Feb 2024 12:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708375363; x=1708980163; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ERoEI/NO8GsC7AqMmtpwujEtptTiedrdKCGQP6wCaeg=; b=M9L+UBs8c53C6ZSXxh8PlrPxU0RCpZxzq+zhloMXrL/IGuDKy2ZsvccQElXxtSqWvu 0QPmPvMpfILYgOvEWtWE5OhVK6iep4c9cZ4EjDarDM8RVwjkpVTBO4BY9KqVc1mWccIz ERgjhZcEAQUhr7UtXXqjLC00h7JBkQ4XDgNe0InXD+0f+WTF1bHDhjhAUHJfVL3rqb/F jK8tv/7oNOBEW/+HuzHw50zcV7nfnbA50aIB/nZzdhNi8T2Y27ZVEH3P9uSF9Zh2h6j6 Os5CeoPit74Axo3p8564Fj02v/MmfA74aETuUrvVWtIgIxQKO7qV4Zkc00rbajI0neTJ 4OUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708375363; x=1708980163; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ERoEI/NO8GsC7AqMmtpwujEtptTiedrdKCGQP6wCaeg=; b=tuFHpxTrqaWT2YpUpY66StRi5LUD8vpqu8in+hqBsw1andKs7sRoa9ltptX7Kf9se7 GMPdr+ZefDVGIDyVzz61fKFn0XEmGKlku+em5A85wphxdycY/9Gpg7D/VBdoMcaXn/1X M25Cx5yIxx3GfaZ7k7SWLkgHTyQvaCkNjp/A2++UF0JOIOor+hUTmFLwmiUonbC0NMZg H9ZN26ElTlgN8rmuudYMAWijFy8tS3QwR5azs9PLUPQ4BcIXRN8lJ9/iyHYCycRpf/XR iB9IPj/pzT/Hur3940gahO9nJNbkP/AB1phXHbsLz+3IDOAlJBBFFUQ8p2KvvV8sFH1S pLfQ== X-Forwarded-Encrypted: i=1; AJvYcCWNh9FSYEsxf5ffB0GJIxpv+mpjL+G33JR65VQ0y2uFHZMD3ZNaDHZmXnN2n4BsaV2n5iMD+3ppeUQXRVhIwqWzYOKYb3Sa3T7a2fiXj60uuNa4s7k= X-Gm-Message-State: AOJu0YwkPIi43k7iPOztfSV91zydniasMtaigi0HyW/WnIoGn34aR8Ch yLA7idkJoAK9FGmPP0w7ba1zmqJ3MX3r4spIf3WA6grFtz9zkHAZgWBPezDNLoc= X-Google-Smtp-Source: AGHT+IHjYYqpFzy+A3s2vMSjtgnWhnkjzjVccOtu/hMYrbwPJtVzvye2GGPfVXk3FAFAnD1YkEj4Rg== X-Received: by 2002:adf:ecd1:0:b0:33d:22f4:75d5 with SMTP id s17-20020adfecd1000000b0033d22f475d5mr5374456wro.12.1708375362796; Mon, 19 Feb 2024 12:42:42 -0800 (PST) Received: from gpeter-l.lan (host-92-18-74-232.as13285.net. [92.18.74.232]) by smtp.gmail.com with ESMTPSA id bx15-20020a5d5b0f000000b0033d202abf01sm10561000wrb.28.2024.02.19.12.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 12:42:42 -0800 (PST) From: Peter Griffin To: arnd@arndb.de, krzysztof.kozlowski@linaro.org, linux@roeck-us.net, wim@linux-watchdog.org, alim.akhtar@samsung.com, jaewon02.kim@samsung.com, semen.protsenko@linaro.org Cc: alexey.klimov@linaro.org, kernel-team@android.com, peter.griffin@linaro.org, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, linux-fsd@tesla.com, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH v5 0/2] Add regmap support to exynos-pmu for protected PMU regs Date: Mon, 19 Feb 2024 20:42:36 +0000 Message-ID: <20240219204238.356942-1-peter.griffin@linaro.org> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240219_124245_181199_94148785 X-CRM114-Status: GOOD ( 15.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi folks, This is a v5 of the series to add support for protected PMU registers found on gs101 and derivative SoCs. In v2 and later it was re-worked to be based on a regmap abstraction that I think leads to a much neater overall solution. The advantage of the regmap abstraction is that most leaf drivers that read/write PMU registers need minimal changes. Example of Exynos drivers that require PMU register access are: * watchdog * usb phy * mipi phy * ufs phy This series has been tested on Pixel 6 Oriole / gs101 (by me), exynos850 (by Sam) and odroid xu3 (exynos 5422) by Alexey. That confirms that both the regmap mmio parts and regmap SMC parts are working correctly. The expectation is this series would be merged via Krzysztofs Samsung Exynos tree. regards, Peter Changes since v4: - Use same argument names as in struct regmap_config - Remove inline keyword and rely on compiler - Update kerneldoc wording - property -> propname argument rename - reverse Xmas tree - Only call of_node_put() when of_parse_phandle() is called - Collect tags Changes since v3: - Fix PMUALIVE_MASK - Add TENSOR_ prefix - clear SET_BITS bits on each loop iteration - change set_bit to set_bits func name - Fix some alignment - Add missing return on dev_err_probe - Reduce indentation in loop Changes since v2 - Add select REGMAP to Kconfig - Add constant for SET/CLEAR bits - Replace kerneldoc with one line comment - Fix kerneldoc for EXPORT_SYMBOL_GPL funcs - remove superflous extern keyword - dev_err_probe() on probe error - shorten regmcfg name - no compatibles inside probe, use match data - don't mix declarations with/without initializations - tensor_sec_reg_read() use mmio to avoid access restrictions - Collect up Reviewed-by - const for regmap_config structs Changes since v1: - Refactor to use custom regmap to abstract SMC register access (Sam / Guenter) - Add deferred probing support (Saravana / Krzysztof) v4 lore: https://lore.kernel.org/all/20240208161700.268570-1-peter.griffin@linaro.org/ v3 lore: https://lore.kernel.org/all/20240202145731.4082033-1-peter.griffin@linaro.org/ v2 lore: https://lore.kernel.org/lkml/20240129211912.3068411-1-peter.griffin@linaro.org/ v1 lore: https://lore.kernel.org/all/20240122225710.1952066-1-peter.griffin@linaro.org/ Peter Griffin (2): soc: samsung: exynos-pmu: Add regmap support for SoCs that protect PMU regs watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for PMU regs drivers/soc/samsung/Kconfig | 1 + drivers/soc/samsung/exynos-pmu.c | 235 ++++++++++++++++++++++++- drivers/soc/samsung/exynos-pmu.h | 1 + drivers/watchdog/Kconfig | 1 - drivers/watchdog/s3c2410_wdt.c | 8 +- include/linux/soc/samsung/exynos-pmu.h | 11 +- 6 files changed, 249 insertions(+), 8 deletions(-)