| Message ID | 20240220115012.471689-1-peter.griffin@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | mfd syscon and altera-sysmgr cleanup | expand |
On Tue, 20 Feb 2024 11:50:09 +0000, Peter Griffin wrote: > Whilst implementing a driver similar to altera-sysmgr for exynos > it was noticed during the review feedback that we should only call > of_node_put() if the property is provided otherwise nothing has > taken a reference on the node. Both syscon and altera-sysmgr also > have the same issue which this series fixes. > > Another piece of review feedback was not to use extern keyword in > the header file, so I also cleaned that up whilst being here. > > [...] Applied, thanks! [1/3] mfd: syscon: call of_node_put() only when of_parse_phandle() takes a ref commit: d2b0680cf3b05490b579e71b0df6e07451977745 [2/3] mfd: syscon: remove extern from function prototypes commit: 0db017f8edd9b9af818bc1d68ba578df1b4c4628 [3/3] mfd: altera-sysmgr: call of_node_put() only when of_parse_phandle() takes a ref commit: e28c28a34ee9fa2ea671a20e5e7064e6220d55e7 -- Lee Jones [李琼斯]
Hi, Whilst implementing a driver similar to altera-sysmgr for exynos it was noticed during the review feedback that we should only call of_node_put() if the property is provided otherwise nothing has taken a reference on the node. Both syscon and altera-sysmgr also have the same issue which this series fixes. Another piece of review feedback was not to use extern keyword in the header file, so I also cleaned that up whilst being here. regards, Peter. Peter Griffin (3): mfd: syscon: call of_node_put() only when of_parse_phandle() takes a ref mfd: syscon: remove extern from function prototypes mfd: altera-sysmgr: call of_node_put() only when of_parse_phandle() takes a ref drivers/mfd/altera-sysmgr.c | 4 +++- drivers/mfd/syscon.c | 4 +++- include/linux/mfd/syscon.h | 25 +++++++++++-------------- 3 files changed, 17 insertions(+), 16 deletions(-)