[v7,0/4] StarFive's StarLink PMU Support

Message

Ji Sheng Teoh Feb. 29, 2024, 7:27 a.m. UTC

Changes since v6:
- Address comments from Will
  - Add "COMPILE_TEST" to STARFIVE_STARLINK_PMU Kconfig dependency.
  - Fix incorrect bitmask with BIT_ULL().
  - Drop kfree() which is not needed in devm_kzalloc() allocation.

Changes since v5:
- Add entry to MAINTAINERS and mark the driver as "Maintained".

Changes since v4:
- Add Reviewed-by tag from Conor to dt-bindings.
- Add Documentation/admin-guide/perf/starfive_starlink_pmu.rst.
- Rework starfive_starlink_pmu.c based on Jonathan's comment.
  - Use <linux/mod_devicetable.h> in place of <linux/of_device.h>.
  - Prefix CYCLES to STARLINK_CYCLES.
  - Fixup error handling, remove unnecessary comma after NULL and
    comments.

Changes since v3:
- Change dt-bindings filename along with the compatible field to
   "starfive,jh8100-starlink-pmu" with SOC specific naming
   convention.
- Drop unused label defined in examples section in dt-bindings.
- Update compatible field in starfive_starlink_pmu.c to the
  aforementioned.

Changes since v2:
- Change compatible field from generic "starfive,starlink-pmu"
   to "starfive,starlink-500-pmu" with specific IP versioning
   in bindings and driver.
- Fix warning '-Wmissing-prototypes' reported by kernel test robot,
   by appending static to starlink_pmu_set_event_period() in
   starfive_starlink_pmu.c.

Changes since v1:
- Change 'depends on SOC_STARFIVE' to 'depends on ARCH_STARFIVE'
   in Kconfig

----

This patch series adds support for StarFive's StarLink Performance
Monitor Unit(PMU).
StarFive's StarLink PMU integrates one or more CPU cores with
a shared L3 memory system. The PMU supports overflow interrupt,
up to 16 programmable 64bit event counters, and an independent
64bit cycle counter.
StarLink PMU is accessed via MMIO.

Example Perf stat output:
[root@user]# perf stat -a -e /starfive_starlink_pmu/cycles/ \
        -e /starfive_starlink_pmu/read_miss/ \
        -e /starfive_starlink_pmu/read_hit/ \
        -e /starfive_starlink_pmu/release_request/  \
        -e /starfive_starlink_pmu/write_hit/ \
        -e /starfive_starlink_pmu/write_miss/ \
        -e /starfive_starlink_pmu/write_request/ \
        -e /starfive_starlink_pmu/writeback/ \
        -e /starfive_starlink_pmu/read_request/ \
        -- openssl speed rsa2048
Doing 2048 bits private rsa's for 10s: 5 2048 bits private RSA's in
2.84s
Doing 2048 bits public rsa's for 10s: 169 2048 bits public RSA's in
2.42s
version: 3.0.11
built on: Tue Sep 19 13:02:31 2023 UTC
options: bn(64,64)
CPUINFO: N/A
                  sign    verify    sign/s verify/s
rsa 2048 bits 0.568000s 0.014320s      1.8     69.8
/////////
 Performance counter stats for 'system wide':

         649991998      starfive_starlink_pmu/cycles/
           1009690      starfive_starlink_pmu/read_miss/
           1079750      starfive_starlink_pmu/read_hit/
           2089405      starfive_starlink_pmu/release_request/
               129      starfive_starlink_pmu/write_hit/
                70      starfive_starlink_pmu/write_miss/
               194      starfive_starlink_pmu/write_request/
            150080      starfive_starlink_pmu/writeback/
           2089423      starfive_starlink_pmu/read_request/

      27.062755678 seconds time elapsed

Ji Sheng Teoh (4):
  perf: starfive: Add StarLink PMU support
  dt-bindings: perf: starfive: Add JH8100 StarLink PMU
  docs: perf: Add description for StarFive's StarLink PMU
  MAINTAINERS: Add entry for StarFive StarLink PMU

 Documentation/admin-guide/perf/index.rst      |   1 +
 .../perf/starfive_starlink_pmu.rst            |  46 ++
 .../perf/starfive,jh8100-starlink-pmu.yaml    |  46 ++
 MAINTAINERS                                   |   7 +
 drivers/perf/Kconfig                          |   9 +
 drivers/perf/Makefile                         |   1 +
 drivers/perf/starfive_starlink_pmu.c          | 642 ++++++++++++++++++
 7 files changed, 752 insertions(+)
 create mode 100644 Documentation/admin-guide/perf/starfive_starlink_pmu.rst
 create mode 100644 Documentation/devicetree/bindings/perf/starfive,jh8100-starlink-pmu.yaml
 create mode 100644 drivers/perf/starfive_starlink_pmu.c

Comments

Will Deacon March 4, 2024, 3:17 p.m. UTC | #1

On Thu, 29 Feb 2024 15:27:16 +0800, Ji Sheng Teoh wrote:
> Changes since v6:
> - Address comments from Will
>   - Add "COMPILE_TEST" to STARFIVE_STARLINK_PMU Kconfig dependency.
>   - Fix incorrect bitmask with BIT_ULL().
>   - Drop kfree() which is not needed in devm_kzalloc() allocation.
> 
> Changes since v5:
> - Add entry to MAINTAINERS and mark the driver as "Maintained".
> 
> [...]

Applied to will (for-next/perf), thanks!

[1/4] perf: starfive: Add StarLink PMU support
      https://git.kernel.org/will/c/c2b24812f7bc
[2/4] dt-bindings: perf: starfive: Add JH8100 StarLink PMU
      https://git.kernel.org/will/c/66461b43b0c0
[3/4] docs: perf: Add description for StarFive's StarLink PMU
      https://git.kernel.org/will/c/49925c1c5a6c
[4/4] MAINTAINERS: Add entry for StarFive StarLink PMU
      https://git.kernel.org/will/c/b9f71ab2152e

Cheers,