mbox series

[v3,0/4] auxdisplay: 7 segment LED display

Message ID 20240301014203.2033844-1-chris.packham@alliedtelesis.co.nz (mailing list archive)
Headers show
Series auxdisplay: 7 segment LED display | expand

Message

Chris Packham March 1, 2024, 1:41 a.m. UTC 
This series adds a driver for a 7 segment LED display.

I haven't had a chance to look at the gpio changes that'd be required to
have multiple characters as subnodes. I wanted to get the code that
addressed Andy and Rob's comments out before my weekend.
--
[1] - https://lore.kernel.org/lkml/2a8d19ee-b18b-4b7c-869f-7d601cea30b6@alliedtelesis.co.nz/

Chris Packham (4):
  auxdisplay: Add 7-segment LED display driver
  dt-bindings: auxdisplay: Add bindings for generic 7-segment LED
  ARM: dts: marvell: Add 7-segment LED display on x530
  ARM: dts: marvell: Indicate USB activity on x530

 .../bindings/auxdisplay/gpio-7-segment.yaml   |  42 ++++++
 .../boot/dts/marvell/armada-385-atl-x530.dts  |  22 +++-
 drivers/auxdisplay/Kconfig                    |  10 ++
 drivers/auxdisplay/Makefile                   |   1 +
 drivers/auxdisplay/seg-led-gpio.c             | 122 ++++++++++++++++++
 5 files changed, 196 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/auxdisplay/gpio-7-segment.yaml
 create mode 100644 drivers/auxdisplay/seg-led-gpio.c

Comments

Andy Shevchenko March 1, 2024, 6:31 p.m. UTC | #1 
On Fri, Mar 01, 2024 at 02:41:59PM +1300, Chris Packham wrote:
> This series adds a driver for a 7 segment LED display.
> 
> I haven't had a chance to look at the gpio changes that'd be required to
> have multiple characters as subnodes. I wanted to get the code that
> addressed Andy and Rob's comments out before my weekend.

Thank you for the update!
Almost fine, one more iteration needed for some minor fixes.