From patchwork Thu Mar 7 09:55:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Th=C3=A9o_Lebrun?= X-Patchwork-Id: 13585304 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EC5CC54E49 for ; Thu, 7 Mar 2024 09:55:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:MIME-Version:Message-Id:Date: Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=vS/dVlumVazQ8Yp1V5j/vZHfhMfJ0j+eXpfeA+n4WqU=; b=RKYesEACpSb6I+ nTS5Zdzq5BY2s317jSTp2BRmO5OB3PuAAu4iijkO1VaonMeL28m8K3T1OIZ55XFnX7EPoPCME4gmh OFQwq9ZnZ7PaguWrQQ6+a+nxfL9BtohE2XmKdHiUC0DOdEwiJdBIMwBs2NXllMQ9SUK8eFQ1d1NWd ibw5RnbEKaZot2Ia9dauXyustxPXFTh/P+gp7X6IIa0kGbpoOm8lRGnDYxsAxd6/EQtzBVsikcnhw OMwTXfVpBLYbmGVSpluJbX1uZh6MQppvojK73ruFyIOEJVMmk149e5x8mozi5rOSzQ46MLTUAH6za yNi9Yh5T5epOVQQu1N/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riATD-00000003wqt-12QX; Thu, 07 Mar 2024 09:55:23 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riAT3-00000003wit-27Li for linux-arm-kernel@lists.infradead.org; Thu, 07 Mar 2024 09:55:16 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id C43F81C000D; Thu, 7 Mar 2024 09:55:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709805309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FrpwCNaPpyNVsE9fXv374zUizJeKHMMetWPo1eTKKX8=; b=k/yUmt4KXSwbxveB9wpW16SJznSJ9mRn6kLa8aaHoW4mozDs/f0A5uTGDym04VWj41AMI3 rzF0rmTpqAKPJMNXffFVGi33HJ5K44JM1ZB5JNFnKMIFUthFq2GklqZfFblwxSJNhjFX8H DLxcvcS6cS+z/SfdE5fgP/vMtJ6/GMnYJRFZo5vceWJZYJPuZ7k75JqxzLe6eT7ywuRsdP lrlZMbPuv/KDqSzoH2hURhAHMtpc9u1V54PYCrby7e+hrmZC8sTZNEWJepZG4x478cGi3D 4FUrENZksqXUPl5MJt7tuH3BqXRCl0pthrQc5Ka3g3DEWLrgDdxzgUFyEDfkmw== From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: [PATCH v4 0/9] usb: cdns: fix suspend on J7200 by assuming reset-on-resume Date: Thu, 07 Mar 2024 10:55:01 +0100 Message-Id: <20240307-j7200-usb-suspend-v4-0-5ec7615431f3@bootlin.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAPaO6WUC/33OSwrCMBCA4atI1kbmEWl15T3ERZpONaJNadqil N7dVBAUxeU/MN/MqKK0XqLaLkbVyuCjD3UKs1wod7L1UbQvUysCYkRkfc4IQPex0LGPjdSlJmu yiihHAaPSXtNK5W9Pc39IffKxC+39eWLAefpPG1CDtiWKZGhyXrtdEUJ38fXKhauavYHeDIJfB iUDOHeZGMtlZb4NfhkGiH7+wckoDLpNvmGLDJ/GNE0PLxdAZDwBAAA= To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Roger Quadros , Peter Chen , Pawel Laszczak , Nishanth Menon , Vignesh Raghavendra , Tero Kristo Cc: Thomas Petazzoni , =?utf-8?q?Gr=C3=A9gory_?= =?utf-8?q?Clement?= , Kevin Hilman , Alan Stern , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, =?utf-8?q?Th=C3=A9o_Lebrun?= X-Mailer: b4 0.13.0 X-GND-Sasl: theo.lebrun@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240307_015513_938862_56C6B678 X-CRM114-Status: GOOD ( 14.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Here is a new revision of the J7200 USB suspend fix. It is currently broken on the platform, leading to a kernel panic at resume. Patches are tested on a J7200 evaluation board, both s2idle and suspend-to-RAM. This revision only changes dt-bindings and DTS stuff. We fix the current situation (as discussed previously [0]) and add our J7200 compatible. Have a nice day, Théo [0]: https://lore.kernel.org/lkml/20240223-j7200-usb-suspend-v3-1-b41c9893a130@bootlin.com/ --- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com Signed-off-by: Théo Lebrun --- Changes in v4: - dt-bindings: usb: ti,j721e-usb: - Remove ti,am64-usb single compatible entry. - Reverse ordering of compatible pair j721e + am64 (becoming am64 + j721e). - Add j7200 + j721e compatible pair (versus only j7200). It is the same thing as am64: only the integration differs with base j721e compatible. - NOT taking trailers from Conor as patches changed substantially. - arm64: dts: ti: j3-j7200: - Use j7200 + j721e compatible pair (versus only j7200 previously). - arm64: dts: ti: j3-am64: - Fix to use am64 + j721e compatible pair (versus only am64). This is a new patch. - Link to v3: https://lore.kernel.org/r/20240223-j7200-usb-suspend-v3-0-b41c9893a130@bootlin.com Changes in v3: - dt-bindings: use an enum to list compatibles instead of the previous odd construct. This is done in a separate patch from the one adding J7200 compatible. - dt-bindings: dropped Acked-by Conor as the changes were modified a lot. - Add runtime PM back. Put the init sequence in ->runtime_resume(). It gets called at probe for all compatibles and at resume for J7200. - Introduce a cdns_ti_match_data struct rather than rely on compatible from code. - Reorder code changes. Add infrastructure based on match data THEN add compatible and its match data. - DTSI: use only J7200 compatible rather than both J7200 then J721E. - Link to v2: https://lore.kernel.org/r/20231120-j7200-usb-suspend-v2-0-038c7e4a3df4@bootlin.com Changes in v2: - Remove runtime PM from cdns3-ti; it brings nothing. That means our cdns3-ti suspend/resume patch is simpler; there is no need to handle runtime PM at suspend/resume. - Do not add cdns3 host role suspend/resume callbacks; they are not needed as core detects reset on resume & calls cdns_drd_host_on when needed. - cdns3-ti: Move usb2_refclk_rate_code assignment closer to the value computation. - cdns3/host.c: do not pass XHCI_SUSPEND_RESUME_CLKS quirk to xHCI; it is unneeded on our platform. - Link to v1: https://lore.kernel.org/r/20231113-j7200-usb-suspend-v1-0-ad1ee714835c@bootlin.com --- Théo Lebrun (9): dt-bindings: usb: ti,j721e-usb: fix compatible list dt-bindings: usb: ti,j721e-usb: add ti,j7200-usb compatible usb: cdns3-ti: move reg writes from probe into ->runtime_resume() usb: cdns3-ti: support reset-on-resume behavior usb: cdns3-ti: pass auxdata from match data to of_platform_populate() usb: cdns3: add quirk to platform data for reset-on-resume usb: cdns3-ti: add J7200 support with reset-on-resume behavior arm64: dts: ti: k3-j7200: use J7200-specific USB compatible arm64: dts: ti: k3-am64: add USB fallback compatible to J721E .../devicetree/bindings/usb/ti,j721e-usb.yaml | 6 +- arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 2 +- drivers/usb/cdns3/cdns3-ti.c | 125 ++++++++++++++++----- drivers/usb/cdns3/core.h | 1 + drivers/usb/cdns3/host.c | 3 + 6 files changed, 105 insertions(+), 34 deletions(-) --- base-commit: 1871c27e3539e5b812d50ec6ccad7567ec5414f2 change-id: 20231113-j7200-usb-suspend-2a47f2281e04 Best regards,