[v9,0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support

Message

Peng Fan April 12, 2024, 12:21 a.m. UTC

This patchset is a rework from Oleksii's RFC v5 patchset
https://lore.kernel.org/all/[e-mail]/

This patchset introduces some changes based on RFC v5:
- introduce helper get_max_msg_size
- support compatible string
- iterate the id_table
- Support multiple configs in one command
- Added i.MX support
- Patch 5 firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support
  is almost same as RFCv5 expect multiple configs support.
- Patch 4 the dt-bindings includes compatible string to support i.MX
- Rebased on 2023-12-15 linux-next/master

If any comments from RFC v5 are missed, I am sorry in advance.

This PINCTRL Protocol is following Version 3.2 SCMI Spec Beta release.

On ARM-based systems, a separate Cortex-M based System Control Processor
(SCP) provides control on pins, as well as with power, clocks, reset
controllers. So implement the driver to support such cases.

The i.MX95 Example as below:

Configuration:
The scmi-pinctrl driver can be configured using DT bindings.
For example:
/ {
	sram0: sram@445b1000 {
		compatible = "mmio-sram";
		reg = <0x0 0x445b1000 0x0 0x400>;

		#address-cells = <1>;
		#size-cells = <1>;
		ranges = <0x0 0x0 0x445b1000 0x400>;

		scmi_buf0: scmi-sram-section@0 {
			compatible = "arm,scmi-shmem";
			reg = <0x0 0x80>;
		};

		scmi_buf1: scmi-sram-section@80 {
			compatible = "arm,scmi-shmem";
			reg = <0x80 0x80>;
		};
	};

	firmware {
		scmi {
			compatible = "arm,scmi";
			mboxes = <&mu2 5 0>, <&mu2 3 0>, <&mu2 3 1>;
			shmem = <&scmi_buf0>, <&scmi_buf1>;
			#address-cells = <1>;
			#size-cells = <0>;

			scmi_iomuxc: protocol@19 {
				compatible = "fsl,imx95-scmi-pinctrl";
				reg = <0x19>;
			};
		};
	};
};

&scmi_iomuxc {
	pinctrl_tpm3: tpm3grp {
		fsl,pins = <
			IMX95_PAD_GPIO_IO12__TPM3_CH2(0x51e)
		>;
	};
};

This patchset has been tested on i.MX95-19x19-EVK board.

Signed-off-by: Peng Fan <[e-mail]>
---
Changes in v9:
- Rebased to next-20240410
- Because "pinctrl: pinconf-generic: check error value EOPNOTSUPP" was
  applied, so pinctrl-scmi.c not convert to err return value for
  'pinctrl_ops->settings_get_one()'.
- Add R-b for patch [1,2,4]/4 from Dhruva Gole
- Link to v8: https://lore.kernel.org/r/[e-mail]

Changes in v8:
- For the devm_x, I still keep as it is to follow current SCMI style. In
future we may follow cleanup.h, but it is not this patchset's goal.
- Apply Cristian's change, and add tag
- _pin -> pin to drop underscore
- Add headers per Andy's comments
- Drop casting for func->groups
- Minor update for coding style
- Link to v7: https://lore.kernel.org/r/[e-mail]

Changes in v7:
- Hope I not miss any comments. If any missed, please forgive. Since
  i.MX95 SCMI firmware not support all the pinctrl features, I could only
  do limited test.
- Version set to 0x10000
- Drop scmi_msg_func_set
- Use get_all to replace flag[0,1], not support flag 2 as of now.
- Add settings_get_one and settings_get_all ops to support get_all[false, true]
- PINCTRL_SET_PERMISSIONS is not included in this patchset
- Bail out if nr_pins is 0
- Add check nr_functions and nr_groups if they are 0.
- ext_name_flag changed to bool type
- Drop unrelated comment
- Use a central function for pin request and free
- Coding style optimization
- Use pinfunction to replace scmi_pinctrl_funcs
- For the devm_x APIs comments from Andy, I not update in the x/arm_scmi/pinctrl.c,
  because it is correct usage.
- For included headers, I keep not change. I try to follow 80 max chars
  for scmi driver, but with a few lines still exceed.
- Link to v6: https://lore.kernel.org/r/[e-mail]

Changes in v6:
- Update pinctrl driver following ARM SCMI 3.2 public release
- Addressed Dan's comments, and followed Dan's suggestions, thanks.
- Dropped R-b/T-b in patch 3/4 and patch 4/4,
- Link to v5: https://lore.kernel.org/r/[e-mail]

Changes in v5:
- Rebased to linux-next next-20240313
- Link to v4: https://lore.kernel.org/r/[e-mail]

Changes in v4:
- Rebased to next-20240222
- Drop pinctrl-scmi-imx and compatible patches in V3
- Add T-b and R-b collected from v3
- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:
- Add R-b for dt-binding patch
- Use 80 chars per line to align with other scmi drivers
- Add pinctrl_scmi_alloc_configs pinctrl_scmi_free_configs to replace
  driver global config_value and config_type array to avoid in parrell
  access issue. When num_configs is larger than 4, use alloc, else use
  stack.
- Drop the separate MAITAINERS entry for firmware scmi pinctrl
- Use enum type, not u8 when referring the scmi or generic pin conf type
- Drop scmi_pinctrl_config_get_all which is not used at all for now.
- Update copyright year to 2024
- Move the enum scmi_pinctrl_conf_type above pinctrl_proto_ops for consistency
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
 Added comments, and added R-b for Patch 1
 Moved the compatile string and i.MX patch to the end, marked NOT APPLY
 Patchset based on lore.kernel.org/all/[e-mail]/
 Addressed the binding doc issue, dropped i.MX content.
 For the firmware pinctrl scmi driver, addressed the comments from Cristian
 For the pinctrl scmi driver, addressed comments from Cristian

 For the i.MX95 OEM stuff, I not have good idea, expect using compatbile
 string. Maybe the firmware public an protocol attribute to indicate it is
 VENDOR stuff or NXP use a new protocol id, not 0x19. But I think
 current pinctrl-scmi.c not able to support OEM config, should we extend
 it with some method? Anyway if patch 1-4 is good enough, they could
 be picked up first.

 Since I am only able to test the patch on i.MX95 which not support
 geneirc pinconf, only OEM configs are tested in my side.

---
Peng Fan (4):
      firmware: arm_scmi: introduce helper get_max_msg_size
      dt-bindings: firmware: arm,scmi: support pinctrl protocol
      firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support
      pinctrl: Implementation of the generic scmi-pinctrl driver

 .../devicetree/bindings/firmware/arm,scmi.yaml     |  50 ++
 MAINTAINERS                                        |   1 +
 drivers/firmware/arm_scmi/Makefile                 |   3 +-
 drivers/firmware/arm_scmi/driver.c                 |  17 +
 drivers/firmware/arm_scmi/pinctrl.c                | 916 +++++++++++++++++++++
 drivers/firmware/arm_scmi/protocols.h              |   3 +
 drivers/pinctrl/Kconfig                            |  11 +
 drivers/pinctrl/Makefile                           |   1 +
 drivers/pinctrl/pinctrl-scmi.c                     | 564 +++++++++++++
 include/linux/scmi_protocol.h                      |  84 ++
 10 files changed, 1649 insertions(+), 1 deletion(-)
---
base-commit: 0a6816a29018d80d15e3adfac7c444aa20eeb87d
change-id: 20231215-pinctrl-scmi-4c5b0374f4c6

Best regards,

Comments

Andy Shevchenko April 12, 2024, 6:12 a.m. UTC | #1

On Fri, Apr 12, 2024 at 3:13 AM Peng Fan (OSS) <[e-mail]> wrote:

> ---
> Changes in v9:
> - Rebased to next-20240410

> - Because "pinctrl: pinconf-generic: check error value EOPNOTSUPP" was
>   applied, so pinctrl-scmi.c not convert to err return value for
>   'pinctrl_ops->settings_get_one()'.

Because it's there it does not mean we want it right now. I pinged
Linus about it again.

> - Add R-b for patch [1,2,4]/4 from Dhruva Gole
> - Link to v8: https://lore.kernel.org/r/[e-mail]

Peng Fan April 12, 2024, 7:01 a.m. UTC | #2

> Subject: Re: [PATCH v9 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
> protocol basic support
> 
> On Fri, Apr 12, 2024 at 3:13 AM Peng Fan (OSS) <[e-mail]>
> wrote:
> 
> > ---
> > Changes in v9:
> > - Rebased to next-20240410
> 
> > - Because "pinctrl: pinconf-generic: check error value EOPNOTSUPP" was
> >   applied, so pinctrl-scmi.c not convert to err return value for
> >   'pinctrl_ops->settings_get_one()'.
> 
> Because it's there it does not mean we want it right now. I pinged Linus about
> it again.

ok, let me include the diff[1], is this ok for you?

[1]https://lore.kernel.org/all/[e-mail]/

Thanks,
Peng.

> 
> > - Add R-b for patch [1,2,4]/4 from Dhruva Gole
> > - Link to v8:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore
> > .kernel.org%2Fr%2F20240405-pinctrl-scmi-v8-0-
> 5fc8e33871bf%40nxp.com&da
> >
> ta=05%7C02%7Cpeng.fan%40nxp.com%7Cc08ad5f378464914b33808dc5ab7
> a2ca%7C6
> >
> 86ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638484991957613078
> %7CUnknown
> > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJ
> >
> XVCI6Mn0%3D%7C0%7C%7C%7C&sdata=Y%2BjjY4hLZHim77ScIIag8CCRtOFN
> lL4XIKaiX
> > tPLeSo%3D&reserved=0
> 
> 
> --
> With Best Regards,
> Andy Shevchenko

Andy Shevchenko April 12, 2024, 1:37 p.m. UTC | #3

On Fri, Apr 12, 2024 at 10:01 AM Peng Fan <[e-mail]> wrote:
> > Subject: Re: [PATCH v9 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
> > protocol basic support
> > On Fri, Apr 12, 2024 at 3:13 AM Peng Fan (OSS) <[e-mail]>
> > wrote:

...

> > > - Because "pinctrl: pinconf-generic: check error value EOPNOTSUPP" was
> > >   applied, so pinctrl-scmi.c not convert to err return value for
> > >   'pinctrl_ops->settings_get_one()'.
> >
> > Because it's there it does not mean we want it right now. I pinged Linus about
> > it again.
>
> ok, let me include the diff[1], is this ok for you?
>
> [1]https://lore.kernel.org/all/[e-mail]/

Yes.