From patchwork Mon Apr 15 16:36:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Marussi X-Patchwork-Id: 13630318 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC41BC4345F for ; Mon, 15 Apr 2024 16:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=sDceRKew5ATL0hu65f41IjiYczRHTzVhwvs5YAvxIN4=; b=t5UwbegaHNDeCN GCZF9LIKT29do6c26QQbcfcInxq1zdywW3AX7eb7eOtIZVutqvVW//H/b4jvRpGLJUKIo26wgHOgj oJLD26aOwRObMCk6RLLFjOmgzvPErluIHa+LeIWNhGP7SnNjgV2800C+RW/HmuvOXW0cB0lOpmpmu HjqpwZCUdDIl0xIBri++kNPAuZusNrSmtNXezmRud+hcxHz8VYAkinPafQN5j/NkjPXbG1CA3Vjm+ 9gGwzTqV0fK7lh122NXBPj0doWoLSdm/gb6jkaUKbzq2dPPtCN+rPJPdhRA/xuQYdznrJZDiYgRkN j8dVsRd05rREFizL/mOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwPKO-000000096J6-0ndl; Mon, 15 Apr 2024 16:37:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwPKL-000000096Hl-1s64 for linux-arm-kernel@lists.infradead.org; Mon, 15 Apr 2024 16:37:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D01642F4; Mon, 15 Apr 2024 09:37:32 -0700 (PDT) Received: from pluto.fritz.box (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2C9DB3F64C; Mon, 15 Apr 2024 09:37:02 -0700 (PDT) From: Cristian Marussi To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, quic_nkela@quicinc.com, souvik.chakravarty@arm.com, mturquette@baylibre.com, sboyd@kernel.org, Cristian Marussi Subject: [PATCH v3 0/5] Rework SCMI Clock driver clk_ops setup procedure Date: Mon, 15 Apr 2024 17:36:44 +0100 Message-ID: <20240415163649.895268-1-cristian.marussi@arm.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_093705_550091_C5713725 X-CRM114-Status: GOOD ( 11.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, a small series to review how the SCMI Clock driver chooses and sets up the CLK operations to associate to a clock when registering with CLK framework. SCMI clocks exposed by the platform sports a growing number of clock properties since SCMI v3.2: discovered SCMI clocks could be restricted in terms of capability to set state/rate/parent/duty_cycle and the platform itself can have a varying support in terms of atomic support. Knowing upfront which operations are NOT allowed on some clocks helps avoiding needless message exchanges. As a result, the SCMI Clock driver, when registering resources with the CLK framework, aims to provide only the specific clk_ops as known to be certainly supported by the specific SCMI clock resource. Using static pre-compiled clk_ops structures to fulfill all the possible (and possibly growing) combinations of clock features is cumbersome and error-prone (there are 32 possible combinations as of now to account for the above mentioned clock features variation). This rework introduces a dynamic allocation mechanism to be able to configure the required clk_ops at run-time when the SCMI clocks are enumerated. Only one single clk_ops is generated (per driver instance) for each of the features combinations effectively found in the set of returned SCMI resources. Once this preliminary rework is done in 1/5, the following patches use this new clk_ops schema to introduce a number of restricted clk_ops depending on the specific retrieved SCMI clocks characteristics. Based on v6.9-rc1 Thanks, Cristian v2 -> v3 - moving scmi_clk_ops_db from being global to a per-instance/per-probe structure to avoid sharing devm_ allocated clk_ops between different driver instances. - using bits.h macros - fixed a few dox comments - explicit unit in atomic_threshold_us - added a runtime size-check before accessing scmi_clk_ops_db using feats_key - reworked scmi_clk_ops_alloc call to reduce nesting - using transport_is_atomic instead of is_atomic to be clearer - using SCMI__SUPPORTED instead of SCMI_FORBIDDEN v1 -> V2 - rebased on v6.9-rc1 Cristian Marussi (5): clk: scmi: Allocate CLK operations dynamically clk: scmi: Add support for state control restricted clocks clk: scmi: Add support for rate change restricted clocks clk: scmi: Add support for re-parenting restricted clocks clk: scmi: Add support for get/set duty_cycle operations drivers/clk/clk-scmi.c | 249 +++++++++++++++++++++++++++++++++-------- 1 file changed, 201 insertions(+), 48 deletions(-) Reviewed-by: Sudeep Holla