mbox series

[v2,0/2] arm64: dts: rockchip: Add Radxa ROCK 3C

Message ID 20240428123618.72170-1-amadeus@jmu.edu.cn (mailing list archive)
Headers show
Series arm64: dts: rockchip: Add Radxa ROCK 3C | expand

Message

Chukun Pan April 28, 2024, 12:36 p.m. UTC 
Changes in v2:
  Collected Acked-by.
  Drop cd-gpios for sdhci.
  Add mmc-hs200-1_8v to eMMC.
  Correct the spi max frequency.
  Update model name and compatible.
  Update regulator according to the schematic.

Chukun Pan (2):
  dt-bindings: arm: rockchip: add Radxa ROCK 3C
  arm64: dts: rockchip: Add Radxa ROCK 3C

 .../devicetree/bindings/arm/rockchip.yaml     |   5 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3566-rock-3c.dts      | 750 ++++++++++++++++++
 3 files changed, 756 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts

Comments

Rob Herring (Arm) April 29, 2024, 2:41 p.m. UTC | #1 
On Sun, 28 Apr 2024 20:36:16 +0800, Chukun Pan wrote:
> Changes in v2:
>   Collected Acked-by.
>   Drop cd-gpios for sdhci.
>   Add mmc-hs200-1_8v to eMMC.
>   Correct the spi max frequency.
>   Update model name and compatible.
>   Update regulator according to the schematic.
> 
> Chukun Pan (2):
>   dt-bindings: arm: rockchip: add Radxa ROCK 3C
>   arm64: dts: rockchip: Add Radxa ROCK 3C
> 
>  .../devicetree/bindings/arm/rockchip.yaml     |   5 +
>  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>  .../boot/dts/rockchip/rk3566-rock-3c.dts      | 750 ++++++++++++++++++
>  3 files changed, 756 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
> 
> --
> 2.25.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y rockchip/rk3566-rock-3c.dtb' for 20240428123618.72170-1-amadeus@jmu.edu.cn:

arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dtb: pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', 'clock-names', 'clocks', 'codec' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml#
Heiko Stuebner May 3, 2024, 11:38 a.m. UTC | #2 
On Sun, 28 Apr 2024 20:36:16 +0800, Chukun Pan wrote:
> Changes in v2:
>   Collected Acked-by.
>   Drop cd-gpios for sdhci.
>   Add mmc-hs200-1_8v to eMMC.
>   Correct the spi max frequency.
>   Update model name and compatible.
>   Update regulator according to the schematic.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: arm: rockchip: add Radxa ROCK 3C
      commit: c0c153e341d2a82241bf0a0b78117ceeb29be3eb
[2/2] arm64: dts: rockchip: Add Radxa ROCK 3C
      commit: ee219017ddb50be14c60d3cbe3e51ac0b2008d40

Best regards,
Heiko Stuebner May 3, 2024, 12:53 p.m. UTC | #3 
Am Freitag, 3. Mai 2024, 13:38:19 CEST schrieb Heiko Stuebner:
> On Sun, 28 Apr 2024 20:36:16 +0800, Chukun Pan wrote:
> > Changes in v2:
> >   Collected Acked-by.
> >   Drop cd-gpios for sdhci.
> >   Add mmc-hs200-1_8v to eMMC.
> >   Correct the spi max frequency.
> >   Update model name and compatible.
> >   Update regulator according to the schematic.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/2] dt-bindings: arm: rockchip: add Radxa ROCK 3C
>       commit: c0c153e341d2a82241bf0a0b78117ceeb29be3eb
> [2/2] arm64: dts: rockchip: Add Radxa ROCK 3C
>       commit: ee219017ddb50be14c60d3cbe3e51ac0b2008d40

Forgot to add, I've dropped the rk809-sound node, as well as the sound-related
properties from the rk809 pmic that got flagged by the binding check
and which I could reproduce here too.

So please submit these as follow up patches, once the necessary changes
to the pmic to allow its codec use are merged.


Thanks
Heiko