From patchwork Sun Apr 28 14:29:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: PeterYin X-Patchwork-Id: 13646062 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47F5BC4345F for ; Sun, 28 Apr 2024 14:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=hNZljW1VCNCq4NbpkC98QZ1JMRwFpIwTImQl35H0ANQ=; b=0zfyzlYdeuZ+0h RynrFRkfSV1IkczxpSO6QKiECj4aaNbzXC9cJ369r85dUXIg4jIaHiAlzhEFGYUp+S0xUWiDhKkgZ YoS2+qbrWOvG0hf7fRkLSI6bHNcwH47OLhkpodF9qFPZgTPn+QQr7tl2xFsL0/udMoqiQQU5dlwPx zsJuLWRwliAxYmeRZeGt5DV463KlPdtXn/HrCWhForRjBlgP8oZJFzfExPiS5cnQr+Csfj4mA/CJv 4sugA5brZk1xWl/2Z/8w7wkRZejDQYEtglJ4RL42PYnepmmZaEbRXAg/8YGu3+nR46qRzePc4Rwkf 3v84arM7GgEPur3NZI7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s15ZH-000000007hX-3vm8; Sun, 28 Apr 2024 14:31:51 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s15ZE-000000007fN-0ijq for linux-arm-kernel@lists.infradead.org; Sun, 28 Apr 2024 14:31:50 +0000 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6f26588dd5eso3102031b3a.0 for ; Sun, 28 Apr 2024 07:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714314701; x=1714919501; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=59EuPpmQZ2ij22OGvTjuvfEIHIx/+kEAdk6lJgaolM0=; b=VLWl12AHBVj/86TsLZN+cK4WdGijSA8L613fs28QdHsuM3YLYeb/WEEK4Ajjq2at1l NgO+oooe6QArSiNzLWa+RJSgk/Mm8Yv6eQwUDAhF1yx9zuQCty3Ft9KxrHX/wnUu+6Rk pAVbiYmeLflr1OzpCIRbfJbs5ONK9IrJJc0R3uJavn633Hux+vYNI6nhh4tw2y2V7NQf XxuDCOvtRPRf8y2wwxZ+KHFPGN44/dm2VrFl4xmhR3zjmDGIUZUqi7WErzaws3vaSLBY PcLSr6LMbf/zACW8nA8Fjx8PaOcaE1l1GF0VHehr0n2UWpTqg8q3A73zXg8U8r2962/A viRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714314701; x=1714919501; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=59EuPpmQZ2ij22OGvTjuvfEIHIx/+kEAdk6lJgaolM0=; b=iuyzPMjSzF1Y35IpmACOrTOToNsE0XRgHDy3DWWoI9Y0sX/8PjGG4uorWk9kTQSR9t 0+qAev8bHv8PFnTy4l6/zpDOxvWFzOO/ZrSpwqRfUl/GCzukQ3ryX/2Eoo0SyXSH4RPP QKGi05eOtZsmCVsh7D9PGu1rM35z1hUsX5tVxCevad9pIlIVJPjlc4pQi64EHBRHadmB mG11phYV8dDwmWeu3cRtOlLMyT54kexNAKdWPVmOLe+LFMCloo0jryL5qy9ny5tW8h5x B9yJ2CMWnWCs7gHfFad1tVMyKr9HJuaZTPCHpcof/AK2sVt3r5eFml1wqJ99zCJJS3R2 hKKw== X-Forwarded-Encrypted: i=1; AJvYcCUTK8ZoM0gJhlKjCN9clZoGbRPbtNa+Fhgma9H1sBV+vEHyWdJhjvbm5PRq4gGUDVz0riA9z/oa51I/HcNftpta/g6SiKU88XgD0q27fVUFByOFrPE= X-Gm-Message-State: AOJu0YzjKlrNFPjyYVeeTc5yl7YtAkXpuMT5MwrQNOYoX1I/Y6PLN0yr 1q1vp2E0nkO83cOTSdNahLzBVR+NkqIOpomjcSqMnam3nzc9g635UGyDSw== X-Google-Smtp-Source: AGHT+IF8P9xi3Y/OKCRwo4517T0rc2kzeu7K9T9yHbVaapsQ6rwWWUZLFHeMRWJrF/Apg+3rTcbhgA== X-Received: by 2002:a05:6a20:5528:b0:1aa:a421:4239 with SMTP id ko40-20020a056a20552800b001aaa4214239mr6779394pzb.15.1714314700978; Sun, 28 Apr 2024 07:31:40 -0700 (PDT) Received: from peter-bmc.dhcpserver.bu9bmc.local (1-34-21-66.hinet-ip.hinet.net. [1.34.21.66]) by smtp.gmail.com with ESMTPSA id h6-20020a636c06000000b00612dc2ec375sm1034834pgc.16.2024.04.28.07.31.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Apr 2024 07:31:40 -0700 (PDT) From: Peter Yin To: patrick@stwcx.xyz, Wim Van Sebroeck , Guenter Roeck , Joel Stanley , Andrew Jeffery , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 0/1] drivers: watchdog: revise watchdog bootstatus Date: Sun, 28 Apr 2024 22:29:35 +0800 Message-Id: <20240428142937.785925-1-peteryin.openbmc@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240428_073148_239582_41C30E53 X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Regarding the AST2600 specification, the WDTn Timeout Status Register (WDT10) has bit 1 reserved. Bit 1 of the status register indicates on ast2500 if the boot was from the second boot source. It does not indicate that the most recent reset was triggered by the watchdog. The code should just be changed to set WDIOF_CARDRESET if bit 0 of the status register is set. However, this bit can be clear when watchdog register 0x0c bit1(Reset System after timeout) is enabled. Thereforce include SCU register to veriy WDIOF_EXTERN1 and WDIOF_CARDRESET in ast2600 SCU74 or ast2400/ast2500 SCU3C. Change Log: v7 -> v8 - Simplify the code. v6 -> v7 - To use syscon_regmap_lookup_by_compatibleys to get scu base - Power on reset is set when triggered by AC or SRSRST. Thereforce, we clear flag to ensure next boot cause is a real watchdog case. We use the external reset flag to determine if it is an external reset or card reset. v5 -> v6 - Fixed missing WDT_TIMEOUT_STATUS_EVENT. v4 -> v5 - Revert indentation. v3 -> v4 - Add error handling for syscon_regmap_lookup_by_phandle and regmap_read. v2 -> v3 - Fixed WDIOF_CARDRESET status bit check and added support for WDIOF_EXTERN1 on ast2500 and ast2600. v1 -> v2 - Add comment and support WDIOF_CARDRESET in ast2600 v1 - Patch 0001 - Add WDIOF_EXTERN1 bootstatus --- drivers/watchdog/aspeed_wdt.c | 109 ++++++++++++++++++++++++++++++++-- 1 file changed, 103 insertions(+), 6 deletions(-)