mbox series

[v2,0/2] firmware: arm_scmi: add notification completion channel

Message ID 20240510-scmi-notify-v2-0-e994cf14ef86@nxp.com (mailing list archive)
Headers show
Series firmware: arm_scmi: add notification completion channel | expand

Message

Peng Fan (OSS) May 10, 2024, 3:19 a.m. UTC 
Per spec:
Completion interrupts This transport supports polling or interrupt driven
modes of communication. In interrupt mode, when the callee completes
processing a message, it raises an interrupt to the caller. Hardware
support for completion interrupts is optional.

i.MX95 SCMI firmware is fully interrupt driven, so Platform expects
completion interrupt for Platform to Agent(P2A) notifictions.

Add another optional mailbox channel for Agent to notify Platform that
notification message has been accepted

After notification channel status become freed, Agent will use the
new mailbox channel to send completion interrupt to Platform.

Add shmem_channel_intr_enabled to check channel flags.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Changes in v2:
- Support bidirectional channel and update commit log to include
  bidirectional channel in patch 2.
- Link to v1: https://lore.kernel.org/r/20240507-scmi-notify-v1-0-1fdefc984d53@nxp.com

---
Peng Fan (2):
      dt-bindings: firmware: arm,scmi: Support notification completion channel
      firmware: arm_scmi: mailbox: support P2A channel completion

 .../devicetree/bindings/firmware/arm,scmi.yaml     | 12 +++--
 drivers/firmware/arm_scmi/common.h                 |  1 +
 drivers/firmware/arm_scmi/mailbox.c                | 60 +++++++++++++++++++---
 drivers/firmware/arm_scmi/shmem.c                  |  5 ++
 4 files changed, 68 insertions(+), 10 deletions(-)
---
base-commit: 9221b2819b8a4196eecf5476d66201be60fbcf29
change-id: 20240507-scmi-notify-07e87a8b9a23

Best regards,

Comments

Sudeep Holla June 17, 2024, 9:54 a.m. UTC | #1 
On Fri, 10 May 2024 11:19:46 +0800, Peng Fan (OSS) wrote:
> Per spec:
> Completion interrupts This transport supports polling or interrupt driven
> modes of communication. In interrupt mode, when the callee completes
> processing a message, it raises an interrupt to the caller. Hardware
> support for completion interrupts is optional.
>
> i.MX95 SCMI firmware is fully interrupt driven, so Platform expects
> completion interrupt for Platform to Agent(P2A) notifictions.
>
> [...]

Applied to sudeep.holla/linux (for-next/scmi/updates), thanks!

[1/2] dt-bindings: firmware: arm,scmi: Support notification completion channel
      https://git.kernel.org/sudeep.holla/c/d0398f51ffb3
[2/2] firmware: arm_scmi: mailbox: support P2A channel completion
      https://git.kernel.org/sudeep.holla/c/fa8b28ba22d9
--
Regards,
Sudeep