From patchwork Tue Jun 11 03:09:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 13692809 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B172C27C55 for ; Tue, 11 Jun 2024 03:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Qa4XZTVfGtL32X62C1zsF25s+1m54YFFrHIqQzx7uQM=; b=4pS4mZIkJEZvlV 7Ak56QghaApTbm7e9wi9i7KJ33V5ZkHO22puLPvIw+5YUS7ood2pw7IuBAjmSYODOihkVKkv1saLD iAaXampO+5d5NgcY+446SfIP1f9XNd0OXpssg1sW8o7lMBhZkKVqRskA+Qi2vGxhSVq6Vq2yMe0uv hMnzlfCVSw5c+Yjq2RdQkAjN7DQh+2DAINMvGoF0mtNoa5XaNm8G0aScn6bESG6Qss8KZNe3tGRVk UvVUSLvSAtZyVx/Gu+t5Ur0I+T9PxwBta65ji5lSN5StaxiIABxF9LRKVDNLUqu0dywZcL7m1KAyu I2Esk7VpCHF3cg7Bsqng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGs0q-00000007ExP-2S3d; Tue, 11 Jun 2024 03:17:32 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGs0k-00000007Etu-3pIm; Tue, 11 Jun 2024 03:17:28 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C009FCE01BC; Tue, 11 Jun 2024 03:17:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A354C4AF1A; Tue, 11 Jun 2024 03:17:23 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97) (envelope-from ) id 1sGs0v-00000001JgD-3KfX; Mon, 10 Jun 2024 23:17:37 -0400 Message-ID: <20240611030934.162955582@goodmis.org> User-Agent: quilt/0.68 Date: Mon, 10 Jun 2024 23:09:34 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Jonathan Corbet , Catalin Marinas , Will Deacon , Guo Ren , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" Subject: [PATCH 0/2] function_graph: ftrace_graph_ret_addr(); there can be only one! X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_201727_146666_D9044DA3 X-CRM114-Status: UNSURE ( 9.01 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I noticed a slight bug in ftrace_graph_ret_addr() for when HAVE_FUNCTION_GRAPH_RET_ADDR_PTR was defined and fixed it up. I then noticed it was buggy when not defined. Looking for an architecture that did not have it defined, I couldn't find any. So I removed it. Steven Rostedt (Google) (2): function_graph: Fix up ftrace_graph_ret_addr() function_graph: Everyone uses HAVE_FUNCTION_GRAPH_RET_ADDR_PTR, remove it ---- Documentation/trace/ftrace-design.rst | 12 ------- arch/arm64/include/asm/ftrace.h | 11 ------- arch/csky/include/asm/ftrace.h | 2 -- arch/loongarch/include/asm/ftrace.h | 1 - arch/powerpc/include/asm/ftrace.h | 2 -- arch/riscv/include/asm/ftrace.h | 1 - arch/s390/include/asm/ftrace.h | 1 - arch/x86/include/asm/ftrace.h | 2 -- include/linux/ftrace.h | 2 -- kernel/trace/fgraph.c | 61 ++++++++++++----------------------- 10 files changed, 20 insertions(+), 75 deletions(-)