mbox series

[v3,0/2] Add interconnect support for stmmac driver.

Message ID 20240703-icc_bw_voting_from_ethqos-v3-0-8f9148ac60a3@quicinc.com (mailing list archive)
Headers show
Series Add interconnect support for stmmac driver. | expand

Message

Sagar Cheluvegowda July 3, 2024, 10:15 p.m. UTC
Interconnect is a software framework to access NOC bus topology
of the system, this framework is designed to provide a standard
kernel interface to control the settings of the interconnects on
an SoC.
The interconnect support is now being added to the stmmac driver
so that any vendors who wants to use this feature can just
define corresponging dtsi properties according to their
NOC bus topologies. 

Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>
---
Changes in v3:
- Drop the patch:
	[PATCH v2 3/3] net: stmmac: Bring down the clocks to lower frequencies when mac link goes down.
- Modify the dt-bindings property names from "axi" and "ahb" to "mac-mem" and
  "cpu-mac" respectively.
- Link to v2: https://lore.kernel.org/r/20240625-icc_bw_voting_from_ethqos-v2-0-eaa7cf9060f0@quicinc.com

Changes in v2:
- Edit the cover letter to give a big picture of this change.
- Move the interconnect changes from ethqos driver to stmmac driver.
- Reorder the the patches to place bindings patch on the top.
- Remove "_icc_path" redundant string from the "interconnect-names" property.
- Link to v1: https://lore.kernel.org/r/20240619-icc_bw_voting_from_ethqos-v1-0-6112948b825e@quicinc.com

---
Sagar Cheluvegowda (2):
      dt-bindings: net: qcom: ethernet: Add interconnect properties
      net: stmmac: Add interconnect support

 Documentation/devicetree/bindings/net/qcom,ethqos.yaml |  8 ++++++++
 drivers/net/ethernet/stmicro/stmmac/stmmac.h           |  1 +
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c      |  8 ++++++++
 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c  | 12 ++++++++++++
 include/linux/stmmac.h                                 |  2 ++
 5 files changed, 31 insertions(+)
---
base-commit: 8a92980606e3585d72d510a03b59906e96755b8a
change-id: 20240610-icc_bw_voting_from_ethqos-12f5c6ed46c2

Best regards,

Comments

Andrew Lunn July 3, 2024, 10:21 p.m. UTC | #1
On Wed, Jul 03, 2024 at 03:15:20PM -0700, Sagar Cheluvegowda wrote:
> Interconnect is a software framework to access NOC bus topology
> of the system, this framework is designed to provide a standard
> kernel interface to control the settings of the interconnects on
> an SoC.
> The interconnect support is now being added to the stmmac driver
> so that any vendors who wants to use this feature can just
> define corresponging dtsi properties according to their
> NOC bus topologies. 
> 
> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>

Thanks for the rework.

It is normal to have a user of a new feature. Please could you patch a
few .dts files with these new properties.

Thanks
	Andrew
---
pw-bot: cr
Sagar Cheluvegowda July 8, 2024, 9:28 p.m. UTC | #2
On 7/3/2024 3:21 PM, Andrew Lunn wrote:
> On Wed, Jul 03, 2024 at 03:15:20PM -0700, Sagar Cheluvegowda wrote:
>> Interconnect is a software framework to access NOC bus topology
>> of the system, this framework is designed to provide a standard
>> kernel interface to control the settings of the interconnects on
>> an SoC.
>> The interconnect support is now being added to the stmmac driver
>> so that any vendors who wants to use this feature can just
>> define corresponging dtsi properties according to their
>> NOC bus topologies. 
>>
>> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>
> 
> Thanks for the rework.
> 
> It is normal to have a user of a new feature. Please could you patch a
> few .dts files with these new properties.
> 
> Thanks
> 	Andrew
> ---
> pw-bot: cr

I should have referenced corresponding dtsi patch in this series,
i am going to post a Version 4 patch updating the cover letter
with a link to the dtsi patch which is enabling interconnect support on
SA8775P ethernet device.

Regards,
Sagar