mbox series

[0/5] Add some features and bugfix for kunpeng_hccs

Message ID 20240718071134.31155-1-lihuisong@huawei.com (mailing list archive)
Headers show
Series Add some features and bugfix for kunpeng_hccs | expand

Message

Huisong Li July 18, 2024, 7:11 a.m. UTC
This series are intended to support the low power feature for specified
HCCS and add used HCCS type sysfs. In addition, fix a PCC typo and add the
verification for die and port number.

Huisong Li (5):
  soc: hisilicon: kunpeng_hccs: fix a PCC typo
  soc: hisilicon: kunpeng_hccs: return failure on having not die or port
    information
  soc: hisilicon: kunpeng_hccs: add used HCCS type sysfs on platform
  soc: hisilicon: kunpeng_hccs: support low power feature for specified
    HCCS
  doc: soc: hisilicon: kunpeng_hccs: add low power interface description
    for HCCS

 .../sysfs-devices-platform-kunpeng_hccs       |  26 +
 drivers/soc/hisilicon/Kconfig                 |   7 +-
 drivers/soc/hisilicon/kunpeng_hccs.c          | 489 +++++++++++++++++-
 drivers/soc/hisilicon/kunpeng_hccs.h          |  29 ++
 4 files changed, 545 insertions(+), 6 deletions(-)

Comments

Huisong Li Aug. 23, 2024, 3:10 a.m. UTC | #1
This series are intended to support the low power feature for specified
HCCS and add used HCCS types sysfs. In addition, fix some bugfix and
enhance some codes.

---
 v2:
  - remove "this patch" words in commit log suggested by Krzyszto.
  - use for_each_set_bit to replace the cycle scanning all HCCS IP.
  - add a patch to rename the 'lane_mode' to 'max_lane_num' to make it
    easy to see.
  - add doc description into the code patch.
  - rename the name of the low power interface.
  - adjust the increasing and decreasing lane interface description.
  - do not create available_inc_dec_lane_types when no HCCS type support
    low power.
---

Huisong Li (6):
  soc: hisilicon: kunpeng_hccs: Fix a PCC typo
  soc: hisilicon: kunpeng_hccs: Return failure on having not die or port
    information
  soc: hisilicon: kunpeng_hccs: Add the check for base address and size
    of shared memory
  soc: hisilicon: kunpeng_hccs: Fix the 'lane_mode' field name in port
    info structure to 'max_lane_num'
  soc: hisilicon: kunpeng_hccs: Add used HCCS types sysfs
  soc: hisilicon: kunpeng_hccs: Support low power feature for the
    specified HCCS type

 .../sysfs-devices-platform-kunpeng_hccs       |  45 ++
 drivers/soc/hisilicon/Kconfig                 |   7 +-
 drivers/soc/hisilicon/kunpeng_hccs.c          | 516 +++++++++++++++++-
 drivers/soc/hisilicon/kunpeng_hccs.h          |  33 +-
 4 files changed, 582 insertions(+), 19 deletions(-)
Jonathan Cameron Aug. 23, 2024, 9:02 a.m. UTC | #2
On Fri, 23 Aug 2024 11:10:53 +0800
Huisong Li <lihuisong@huawei.com> wrote:

> This series are intended to support the low power feature for specified
> HCCS and add used HCCS types sysfs. In addition, fix some bugfix and
> enhance some codes.

Quick process thing.  Don't send a v2 like this in reply to v1
(for most kernel subsystems anyway, maybe there are some that request
this?).

Most people still review in email clients and they often start at latest
and work back until they run out of time.  Thus a reply to an earlier
thread is not read!

Jonathan

> 
> ---
>  v2:
>   - remove "this patch" words in commit log suggested by Krzyszto.
>   - use for_each_set_bit to replace the cycle scanning all HCCS IP.
>   - add a patch to rename the 'lane_mode' to 'max_lane_num' to make it
>     easy to see.
>   - add doc description into the code patch.
>   - rename the name of the low power interface.
>   - adjust the increasing and decreasing lane interface description.
>   - do not create available_inc_dec_lane_types when no HCCS type support
>     low power.
> ---
> 
> Huisong Li (6):
>   soc: hisilicon: kunpeng_hccs: Fix a PCC typo
>   soc: hisilicon: kunpeng_hccs: Return failure on having not die or port
>     information
>   soc: hisilicon: kunpeng_hccs: Add the check for base address and size
>     of shared memory
>   soc: hisilicon: kunpeng_hccs: Fix the 'lane_mode' field name in port
>     info structure to 'max_lane_num'
>   soc: hisilicon: kunpeng_hccs: Add used HCCS types sysfs
>   soc: hisilicon: kunpeng_hccs: Support low power feature for the
>     specified HCCS type
> 
>  .../sysfs-devices-platform-kunpeng_hccs       |  45 ++
>  drivers/soc/hisilicon/Kconfig                 |   7 +-
>  drivers/soc/hisilicon/kunpeng_hccs.c          | 516 +++++++++++++++++-
>  drivers/soc/hisilicon/kunpeng_hccs.h          |  33 +-
>  4 files changed, 582 insertions(+), 19 deletions(-)
>
Huisong Li Aug. 27, 2024, 11:49 a.m. UTC | #3
在 2024/8/23 17:02, Jonathan Cameron 写道:
> On Fri, 23 Aug 2024 11:10:53 +0800
> Huisong Li <lihuisong@huawei.com> wrote:
>
>> This series are intended to support the low power feature for specified
>> HCCS and add used HCCS types sysfs. In addition, fix some bugfix and
>> enhance some codes.
> Quick process thing.  Don't send a v2 like this in reply to v1
> (for most kernel subsystems anyway, maybe there are some that request
> this?).
>
> Most people still review in email clients and they often start at latest
> and work back until they run out of time.  Thus a reply to an earlier
> thread is not read!
Got it. Thanks for suggestion.
>
> Jonathan
>
>> ---
>>   v2:
>>    - remove "this patch" words in commit log suggested by Krzyszto.
>>    - use for_each_set_bit to replace the cycle scanning all HCCS IP.
>>    - add a patch to rename the 'lane_mode' to 'max_lane_num' to make it
>>      easy to see.
>>    - add doc description into the code patch.
>>    - rename the name of the low power interface.
>>    - adjust the increasing and decreasing lane interface description.
>>    - do not create available_inc_dec_lane_types when no HCCS type support
>>      low power.
>> ---
>>
>> Huisong Li (6):
>>    soc: hisilicon: kunpeng_hccs: Fix a PCC typo
>>    soc: hisilicon: kunpeng_hccs: Return failure on having not die or port
>>      information
>>    soc: hisilicon: kunpeng_hccs: Add the check for base address and size
>>      of shared memory
>>    soc: hisilicon: kunpeng_hccs: Fix the 'lane_mode' field name in port
>>      info structure to 'max_lane_num'
>>    soc: hisilicon: kunpeng_hccs: Add used HCCS types sysfs
>>    soc: hisilicon: kunpeng_hccs: Support low power feature for the
>>      specified HCCS type
>>
>>   .../sysfs-devices-platform-kunpeng_hccs       |  45 ++
>>   drivers/soc/hisilicon/Kconfig                 |   7 +-
>>   drivers/soc/hisilicon/kunpeng_hccs.c          | 516 +++++++++++++++++-
>>   drivers/soc/hisilicon/kunpeng_hccs.h          |  33 +-
>>   4 files changed, 582 insertions(+), 19 deletions(-)
>>
> .