From patchwork Mon Sep 9 23:52:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 13797706 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6CB3ECE58E for ; Mon, 9 Sep 2024 23:53:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=XoY8HneQkhH5ZjxPqOoPttw1x0WMnLjBkxmjs118fsc=; b=R5yjXb2IzSpY29ao5DOEtCIgE/ rBFIus3Z06OcSeTG1qr/62XgB0Jy3uFCL/4M4i+BFzi3hN7u8a2nZFRBioRewGpXAkAN1PvQjSJHr OOnnXL24R/sLcCnbCVkwx4bngT6IEFCHhNY5XdPoEbX8P34A35+Ws0gPRYU7rIcjuQKWhhudmk0t9 Jm+i1/D0Chx7WnUNdNGFIHLNXB8Me//tW+94PCF7JloyfYO9FB0xrAS573Z3gNrfQ3FWQ7gzNomXQ 1PUL/i0aePWnrAl0HOnEhMFMl7XSVp98xSkE5wio4y2N+uDbh8Yh0DuxHok9/UzTTYDbD5Ywjob+A l0b7StUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1snoC9-00000003cXv-0MY9; Mon, 09 Sep 2024 23:53:21 +0000 Received: from out-182.mta1.migadu.com ([95.215.58.182]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1snoB7-00000003cI9-0W9y for linux-arm-kernel@lists.infradead.org; Mon, 09 Sep 2024 23:52:18 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1725925933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=XoY8HneQkhH5ZjxPqOoPttw1x0WMnLjBkxmjs118fsc=; b=dL5NKquBh3unx+vlb2FBfSby+vLEx+lrcUjNjJ2sPnLnSsAZwdFVJPL03X/J/re7lJL+XK LhrVWnZ02Xj4EuZgo6LwPvlIv9EkMkIJBIXKU3lcdiYxZpkUw/XA50Cw/hUHAZggVgqVh7 b7mR8eLnwBi81b///22l4KtDRjM/ufQ= From: Sean Anderson To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Radhey Shyam Pandey , netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Michal Simek , linux-kernel@vger.kernel.org, Sean Anderson , Heng Qi Subject: [RFC PATCH net-next v2 0/6] net: xilinx: axienet: Enable adaptive IRQ coalescing with DIM Date: Mon, 9 Sep 2024 19:52:02 -0400 Message-Id: <20240909235208.1331065-1-sean.anderson@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240909_165217_329750_75E59871 X-CRM114-Status: GOOD ( 10.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org To improve performance without sacrificing latency under low load, enable DIM. While I appreciate not having to write the library myself, I do think there are many unusual aspects to DIM, as detailed in the last patch. This series depends on [1-2] and is therefore marked RFC. This series is otherwise ready to merge. [1] https://lore.kernel.org/netdev/20240909230908.1319982-1-sean.anderson@linux.dev/ [2] https://lore.kernel.org/netdev/20240909231904.1322387-1-sean.anderson@linux.dev/ Changes in v2: - Add some symbolic constants for IRQ delay timer - Report an error for bad coalesce settings - Don't use spin_lock_irqsave when we know the context - Split the CR calculation refactor from runtime coalesce settings adjustment support for easier review. - Have axienet_update_coalesce_rx/tx take the cr value/mask instead of calculating it with axienet_calc_cr. This will make it easier to add partial updates in the next few commits. - Get coalesce parameters from driver state - Don't take the RTNL in axienet_rx_dim_work to avoid deadlock. Instead, calculate a partial cr update that axienet_update_coalesce_rx can perform under a spin lock. - Use READ/WRITE_ONCE when accessing/modifying rx_irqs Sean Anderson (6): net: xilinx: axienet: Add some symbolic constants for IRQ delay timer net: xilinx: axienet: Report an error for bad coalesce settings net: xilinx: axienet: Combine CR calculation net: xilinx: axienet: Support adjusting coalesce settings while running net: xilinx: axienet: Get coalesce parameters from driver state net: xilinx: axienet: Enable adaptive IRQ coalescing with DIM drivers/net/ethernet/xilinx/Kconfig | 1 + drivers/net/ethernet/xilinx/xilinx_axienet.h | 31 +- .../net/ethernet/xilinx/xilinx_axienet_main.c | 320 ++++++++++++++---- 3 files changed, 273 insertions(+), 79 deletions(-)