| Message ID | 20241007-tisci-syssuspendresume-v13-0-ed54cd659a49@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | firmware: ti_sci: Introduce system suspend support | expand |
Hi Markus On 07/10/2024 09:08, Markus Schneider-Pargmann wrote: > Abstract > ******** > > This series introduces necessary ti_sci driver functionality to support > various Suspend-to-RAM modes on TI AM62 family of devices. These Low > Power Modes include Deep Sleep and MCU Only as described in section > "6.2.4 Power Modes" of the AM62P Technical Reference Manual [0]. > > Summary > ******* > > This series is a restructuring and rebase of the patch series by > Dave Gerlach [1] and Dhruva Gole [2]. It applies on top of Linux > 6.12-rc1. > > The kernel triggers entry to Low Power Mode through the mem suspend > transition with the following: > > * At the bootloader stage, one is expected to package the TIFS stub > which then gets pulled into the Tightly coupled memory of the Device > Mgr (DM) R5 when it starts up. If using U-Boot, then it requires > tispl.bin to contain the TIFS stub. Refer to documentation in upstream > u-boot[3] for further details. The supported firmware version is from > TI Processor SDK >= 10.00 ie. tag 10.00.04 from ti-linux-firmware [4]. > > * Use a TF-A binary that supports PSCI_SYSTEM_SUSPEND call. This causes > system to use PSCI system suspend as last step of mem sleep. > > * We add support for the TISCI_MSG_QUERY_FW_CAPS message, used to retrieve > the firmware capabilities of the currently running system firmware [6]. > Sysfw version >= 10.00.04 support LPM_DM_MANAGED capability, where > Device Mgr firmware now manages which low power mode is chosen. Going > forward, this is the default configuration supported for TI AM62 family > of devices. The state chosen by the DM can be influenced by sending > constraints using the new LPM constraint APIs. (Patch 1) > > * The firmware requires that the OS sends a TISCI_MSG_PREPARE_SLEEP > message in order to provide details about suspend. The ti_sci driver > must send this message to firmware with the above information > included, which it does during the driver suspend handler when > PM_MEM_SUSPEND is the determined state being entered. The mode being > sent depends on whether firmware capabilities have support for > LPM_DM_MANAGED feature. Legacy firmware or those supporting other > modes can extend the mode selection logic as needed. (Patch 2) > > * We also add the remaining TISCI Low Power Mode messages required for > inquiring wake reason and managing LPM constraints as part of a new PM > ops. These messages are part of the TISCI PM Low Power Mode API [5]. > (Patch 3) > > * Finally if any CPUs have PM QoS resume latency constraints set, we > aggregate these and set the TISCI system-wide latency constraint. > (Patch 4) > > Testing > ******* > > This series can for example be tested with a am62a-lp-sk board. Tested on am62-sk. Tested-by: Roger Quadros <rogerq@kernel.org> > > For am62a-lp-sk all usb nodes have to be disabled at the moment (usbss0, > usb0, usbss1 and usb1). There is currently an issue with USB Link Power > Management and turning off the USB device which is being worked on. Or you can this patch [1]. [1] https://lore.kernel.org/all/20241009-am62-lpm-usb-v2-1-da26c0cd2b1e@kernel.org/ cheers, -roger
Hi Markus Schneider-Pargmann, On Mon, 07 Oct 2024 08:08:53 +0200, Markus Schneider-Pargmann wrote: > Abstract > ******** > > This series introduces necessary ti_sci driver functionality to support > various Suspend-to-RAM modes on TI AM62 family of devices. These Low > Power Modes include Deep Sleep and MCU Only as described in section > "6.2.4 Power Modes" of the AM62P Technical Reference Manual [0]. > > [...] I have applied the following to branch ti-drivers-soc-next on [1]. Thank you! NOTE: I have picked up Ack from Rafael per [2] and applied the full series. [1/5] PM: QoS: Export dev_pm_qos_read_value commit: 3e360703d0bff3bb5643b2a0bf9a670931ba8b71 [2/5] firmware: ti_sci: Add support for querying the firmware caps commit: 055b6cfb62f5a1ea811aa21b96f2e611329b12b8 [3/5] firmware: ti_sci: Add system suspend and resume call commit: ec24643bdd625971933451f22b8e33d364920f6e [4/5] firmware: ti_sci: Introduce Power Management Ops commit: 60357991f6b9d4bd4dc442a368da3f468cfa4903 [5/5] firmware: ti_sci: add CPU latency constraint management commit: a7a15754c7f70a833ffeb9ad996b358924f10305 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git [2] https://lore.kernel.org/lkml/CAJZ5v0g1Ri_wKYppomE6RXqcZXRnX7bLOPMtsQaao0uchSfE9A@mail.gmail.com/
Abstract ******** This series introduces necessary ti_sci driver functionality to support various Suspend-to-RAM modes on TI AM62 family of devices. These Low Power Modes include Deep Sleep and MCU Only as described in section "6.2.4 Power Modes" of the AM62P Technical Reference Manual [0]. Summary ******* This series is a restructuring and rebase of the patch series by Dave Gerlach [1] and Dhruva Gole [2]. It applies on top of Linux 6.12-rc1. The kernel triggers entry to Low Power Mode through the mem suspend transition with the following: * At the bootloader stage, one is expected to package the TIFS stub which then gets pulled into the Tightly coupled memory of the Device Mgr (DM) R5 when it starts up. If using U-Boot, then it requires tispl.bin to contain the TIFS stub. Refer to documentation in upstream u-boot[3] for further details. The supported firmware version is from TI Processor SDK >= 10.00 ie. tag 10.00.04 from ti-linux-firmware [4]. * Use a TF-A binary that supports PSCI_SYSTEM_SUSPEND call. This causes system to use PSCI system suspend as last step of mem sleep. * We add support for the TISCI_MSG_QUERY_FW_CAPS message, used to retrieve the firmware capabilities of the currently running system firmware [6]. Sysfw version >= 10.00.04 support LPM_DM_MANAGED capability, where Device Mgr firmware now manages which low power mode is chosen. Going forward, this is the default configuration supported for TI AM62 family of devices. The state chosen by the DM can be influenced by sending constraints using the new LPM constraint APIs. (Patch 1) * The firmware requires that the OS sends a TISCI_MSG_PREPARE_SLEEP message in order to provide details about suspend. The ti_sci driver must send this message to firmware with the above information included, which it does during the driver suspend handler when PM_MEM_SUSPEND is the determined state being entered. The mode being sent depends on whether firmware capabilities have support for LPM_DM_MANAGED feature. Legacy firmware or those supporting other modes can extend the mode selection logic as needed. (Patch 2) * We also add the remaining TISCI Low Power Mode messages required for inquiring wake reason and managing LPM constraints as part of a new PM ops. These messages are part of the TISCI PM Low Power Mode API [5]. (Patch 3) * Finally if any CPUs have PM QoS resume latency constraints set, we aggregate these and set the TISCI system-wide latency constraint. (Patch 4) Testing ******* This series can for example be tested with a am62a-lp-sk board. For am62a-lp-sk all usb nodes have to be disabled at the moment (usbss0, usb0, usbss1 and usb1). There is currently an issue with USB Link Power Management and turning off the USB device which is being worked on. Once booted suspend/resume can be tested with rtcwake: $ rtcwake -m mem -s 10 -d /dev/rtc0 Make sure /dev/rtc0 corresponds to rtc-ti-k3: $ dmesg | grep rtc-ti-k3 rtc-ti-k3 2b1f0000.rtc: registered as rtc0 Base commit: ************ v6.12-rc1 Changelog: ********** v13: - Rebased to v6.12-rc1 - The patch to add the EXPORT for the dev_pm_qos_read_value() function was sent separately once and reintegrated into this series after some feedback. Commit message was rephrased. https://lore.kernel.org/lkml/20241002194446.269775-1-msp@baylibre.com/ - Removed an unreachable return 0 in ti_sci_prepare_system_suspend to make the compiler complain in case it gets reachable in the future. v12: - Add patch to add an export for dev_pm_qos_read_value() to fix module build on KEYSTONE - Remove include of linux/dev_printk.h v11: - Add dev_err() in many error cases - Fix a typo in the commit message of 'firmware: ti_sci: Add support for querying the firmware caps' - Fix URL in commit message - Unify error handling and printing over the added ti_sci_cmd_* functions - Use dev_* instead of pr_* - Add a debug message listing the capabilities the firmware returned - Add a small comment describing why context address is 0x0 - Removed unnecessary debug prints - Restructure the ifdefs for pm ops as suggested - Only print the wake reason if there was no error. If there is an error, the ti_sci_cmd_lpm_wake_reason already printed an error. As a missing reason is not critical, the error is ignored and the system continues to resume - Remove wakeup source macros from sci_protocol.h v10: - add "wake reason" handling which is also supported by 10.x firmware update, but was mistakenly left out of v9 - fix debug print of which CPU caused max CPU latency - update TRM pointer[0] to point to AM62P TRM which has better description of low-power modes shared across AM62P family - update u-boot documentaion pointer to point to upstream u-boot commit. v9: - Include Kevin's patch to add CPU latency constraint management into this series. Posted here in v3: https://lore.kernel.org/lkml/20240802214220.3472221-1-khilman@baylibre.com/ - reorder patches to avoid any build warnings - ti_sci_cmd_prepare_sleep was moved into the patch that adds suspend and resume calls - pmops wake_reason is now only set if the capabilities exist - Use pmops pointer instead of full path v8: - Restructuring of code to include all TISCI PM LPM ops - Removing malloc related to TIFS Stub as it is managed by DM - Dropping has_lpm check as suggested by Nishanth - Using LPM_DM_MANAGED capability for mode selection - Updating the suspend and resume callback handlers v7: - Address Andrew's concerns on SYSFW fw_caps API - Remove all the unused functions and variables including set_io_isolation and wake_reason calls - use dma_free_attrs - remove IO isolation related code from linux side, v6: - link to v6 [5] - Loading of FS Stub from linux no longer needed, hence drop that patch, - Drop 1/6 and 5/6 from the previous series [4]. - Add system suspend resume callbacks which were removed in commit 9225bcdedf16297a346082e7d23b0e8434aa98ed ("firmware: ti_sci: Use system_state to determine polling") - Use IO isolation while putting the system in suspend to RAM v5: - Add support (patch 3) for detecting the low power modes (LPM) of the FW/SoC with a recently introduced core TISCI_MSG_QUERY_FW_CAPS message. - Use TISCI_MSG_QUERY_FW_CAPS instead of misusing the TISCI_MSG_PREPARE_SLEEP to detect the FW/SoC low power caps (patch 4). - Take into account the supported LPMs in ti_sci_prepare_system_suspend() and handle the case when CONFIG_SUSPEND is not enabled (patch 6) that was reported by Roger Quadros and LKP. - Pick up Rob Herring's "Reviewed-by" tag for the binding patch. v4: - Fix checkpacth warnings in patches 2 and 3. - Drop the links with anchors in patch 2. v3: - Fix the compile warnings on 32-bit platforms reported by the kernel test robot in patches (3,5). - Pick up Roger's "Tested-by" tags. v2: - Addressed comments received for v1 series [1]. - Updated v1 patch 5 to use pm notifier to avoid firmware loading issues. - Dropped the reserved region requirement and allocate DMA memory instead. The reserved region binding patch is also removed. - Introduce two more TISCI LPM messages that are supported in SysFW. - Fixes in error handling. References: *********** [0] https://www.ti.com/lit/pdf/spruiv7 [1] https://lore.kernel.org/lkml/20220421203659.27853-1-d-gerlach@ti.com [2] https://lore.kernel.org/lkml/20230804115037.754994-1-d-gole@ti.com [3] https://source.denx.de/u-boot/u-boot/-/commit/962f60abca82bb11501bc0c627abacda15bed076 [4] https://git.ti.com/cgit/processor-firmware/ti-linux-firmware/commit/?h=10.00.06&id=193f7d7570583a41ddc50a221e37c32be6be583e [5] https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/pm/lpm.html [6] https://downloads.ti.com/tisci/esd/latest/2_tisci_msgs/general/core.html#tisci-msg-query-fw-caps Dave Gerlach (1): firmware: ti_sci: Introduce Power Management Ops Georgi Vlaev (1): firmware: ti_sci: Add support for querying the firmware caps Kevin Hilman (1): firmware: ti_sci: add CPU latency constraint management Markus Schneider-Pargmann (1): PM: QoS: Export dev_pm_qos_read_value Vibhore Vardhan (1): firmware: ti_sci: Add system suspend and resume call drivers/base/power/qos.c | 1 + drivers/firmware/ti_sci.c | 489 ++++++++++++++++++++++++- drivers/firmware/ti_sci.h | 143 +++++++- include/linux/soc/ti/ti_sci_protocol.h | 30 ++ 4 files changed, 661 insertions(+), 2 deletions(-) -- 2.45.2 --- Dave Gerlach (1): firmware: ti_sci: Introduce Power Management Ops Georgi Vlaev (1): firmware: ti_sci: Add support for querying the firmware caps Kevin Hilman (1): firmware: ti_sci: add CPU latency constraint management Markus Schneider-Pargmann (1): PM: QoS: Export dev_pm_qos_read_value Vibhore Vardhan (1): firmware: ti_sci: Add system suspend and resume call drivers/base/power/qos.c | 1 + drivers/firmware/ti_sci.c | 487 ++++++++++++++++++++++++++++++++- drivers/firmware/ti_sci.h | 143 +++++++++- include/linux/soc/ti/ti_sci_protocol.h | 30 ++ 4 files changed, 659 insertions(+), 2 deletions(-) --- base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc change-id: 20241006-tisci-syssuspendresume-e6550720a50f Best regards,