mbox series

[v4,0/6] staging: vchiq: Lower indentation at various

Message ID 20241013112128.397249-1-umang.jain@ideasonboard.com (mailing list archive)
Headers show
Series staging: vchiq: Lower indentation at various | expand

Message

Umang Jain Oct. 13, 2024, 11:21 a.m. UTC 
Series is attempted to fix few alignments issues.                               
Also, it aims to lower indentation of various nested `if` conditional           
blocks without introducing any functional changes.                              
                                                                                
Changes in v4:
- Improve return value from service_notify_bulks(3/6)
- Drop 'service' and 'bulk' null check from 3/6 

Changes in v3:
- fix status (return value) in 4/6

Changes in v2:                                                                  
- Assimilated fixes from v1 which can make independent progress                 
- drop following patches from v1:                                               
  - [PATCH 2/8] staging: vchiq_core: Properly log dev_err()                     
  - [PATCH 6/8] staging: vchiq_arm: Lower indentation of a conditional block    
  - Will be handled separately                                                  
- Rework 4/8 from v1                                                            
  - Now included as "staging: vchiq_core: Refactor notify_bulks()"              
                                                                                
Link to v1:                                                                     
https://lore.kernel.org/linux-staging/20241011072210.494672-1-umang.jain@ideasonboard.com/T/#t

Umang Jain (6):
  staging: vchiq_core: Locally cache cache_line_size information
  staging: vchiq_core: Do not log debug in a separate scope
  staging: vchiq_core: Indent copy_message_data() on a single line
  staging: vchiq_core: Refactor notify_bulks()
  staging: vchiq_core: Lower indentation in parse_open()
  staging: vchiq_core: Lower indentation in vchiq_close_service_internal

 .../interface/vchiq_arm/vchiq_core.c          | 184 ++++++++++--------
 1 file changed, 99 insertions(+), 85 deletions(-)

Comments

Dan Carpenter Oct. 13, 2024, 12:21 p.m. UTC | #1 
LGTM.

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter