From patchwork Mon Oct 14 08:56:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Carrasco X-Patchwork-Id: 13834499 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5362CFC50A for ; Mon, 14 Oct 2024 09:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Bka1XtdhEywlqdYAZ4vAB5CJJ60IdylXCrsQgeEz6GI=; b=yFwGoKsUPttg3w lXZGkDD3c+F+Uj0SsjNVGB4CYiWErj10vJ/vcDHuf8KEfrb2xozJ9NRYuR8+6rCGmCsjhmjPqmJ+W sSWXR2RH6ChXMzcAH89tT6bojsEyixCu+8Ayl2wRmcUWlUOeeCKtyLEnyVYqd4hDNCz3HUeChX/wr b0d6Hc6BV6Ou/N1wElIZsoe4C5hgujUcGwmKVuo22eCrHqqT0jMfYPrNugLJXjfRU43Jmzd8qdw0K WLJ+kFNczeM5oaV7XEaj0K0EBJf5y3bIoorgMLs6dv6z3Kll0HqJW7WyoslLGw4epYq2MIRccwJ0u 7xna0oXPjbhQO1HBavyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0HDE-00000004TZi-1qKp; Mon, 14 Oct 2024 09:18:00 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0Gsm-00000004OCR-1e3g; Mon, 14 Oct 2024 08:56:53 +0000 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5c96df52c52so1310308a12.1; Mon, 14 Oct 2024 01:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728896211; x=1729501011; darn=lists.infradead.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=Bka1XtdhEywlqdYAZ4vAB5CJJ60IdylXCrsQgeEz6GI=; b=PekLlxLeRSUJGa3wje1kqoC/E121RU3wIwRUoyv0X9ZIvayoTb3WdORhejbpna6VRR Wn3UmOBA52rHzo4k6PN0gP8Ce49cDh+VuoPep3fSlNJuFjbgawUf7SiKOPB1gv2+t2m1 FCURoSvBuLtfrMcjHG0dJsDkCJJ91EXXGyV629QlQ+DeR/eaxf+usfNhEnioCdYL0S/c 4RDxdvGuX4NjWKFNhFJU9UiKezmqQILcF7FaXAhzVbsojOUF/kqj+BhhPqkxkggmrzeB khYGSMScW29VnVd8Xng/hgzmQuxnvzyX8eoIYBIEzameXPfMYLEYqvN8JYf8E+WfUzT0 +RQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728896211; x=1729501011; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Bka1XtdhEywlqdYAZ4vAB5CJJ60IdylXCrsQgeEz6GI=; b=poGF/m62RR0owAX2ya+tJdiZOq6Uzvt5xHGFwdZkRyLMa66/L4+T/iQIiUGwcUNdIJ LVt3UkVpj/mdaUwMMH5MKJjEh3ouZ3eMUnit5lzzzUZ6kKnkhNprMwOI1fngbv9phW3i 9hf2fDSYQdTpBy9ilMSdvzeQKwdqvQnQwWNFVA5xNRy2cHtVSlLq8hfFYcuYEXhR+4wL SalwewTwjFEWTeF4LLrVhTURvC1r5eQNRLoFY6rSnYZNaeScCbIYapin0o7Y36UHm03P +ihYpVkynvfS9sd5hLn5Fj99pEuqAvH2QTzxe0y7qWAuvW6gIn4Gay3tzVwvBLeWKgHc b9Ng== X-Forwarded-Encrypted: i=1; AJvYcCVU/uzzXFtvCuY0dEgRWDT92KTrGsW4yP5DtNzHgZyc1xSOTOzvQMb+Oxxqr8mvjD5JmeWspDbICRL7zxQTy3AO@lists.infradead.org X-Gm-Message-State: AOJu0YxnMOOAb0AAITmfA3arYFqeokFX+JMpHvl420innRdTqEEygHgm UWsUc4C8TbwY5mwMeLZZBz1lguYP1IeBPW7L9++LAiD9lZjRmodD X-Google-Smtp-Source: AGHT+IGDJQrFJVmLNzaOGm//MX2LnTO5StHI/IaPJSK+vM3ey2DDnOs01a7EiS7Ktr8Rdy6PAFN7xg== X-Received: by 2002:a05:6402:354b:b0:5c9:488b:1dd9 with SMTP id 4fb4d7f45d1cf-5c95ac416b3mr4767381a12.24.1728896210311; Mon, 14 Oct 2024 01:56:50 -0700 (PDT) Received: from [127.0.1.1] (91-118-163-37.static.upcbusiness.at. [91.118.163.37]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c9370d2296sm4635091a12.15.2024.10.14.01.56.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 01:56:48 -0700 (PDT) From: Javier Carrasco Subject: [PATCH v2 0/2] staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node Date: Mon, 14 Oct 2024 10:56:35 +0200 Message-Id: <20241014-vchiq_arm-of_node_put-v2-0-cafe0a4c2666@gmail.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAMPcDGcC/4WNQQ6CMBBFr0JmbU1bERJX3sOQZqRTmEQotthoS O9u5QIu30v++xtECkwRLtUGgRJH9nMBfaigH3EeSLAtDFrqWkl1Eqkf+WkwTMI7M3tLZnmtopF 4JkR0tpVQtksgx++9e+sKjxxXHz77TVI/+6+YlFDCtfqusaG6tfI6TMiPY+8n6HLOX5kF3Ou6A AAA To: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman , Stefan Wahren , Umang Jain , Laurent Pinchart Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Javier Carrasco , stable@vger.kernel.org X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1728896207; l=961; i=javier.carrasco.cruz@gmail.com; s=20240312; h=from:subject:message-id; bh=deoA6W7KISJU4Lqs4NPTSSLQ+sPbpJvu3bhsGmcntkY=; b=ziGzncipHzJsiNZ8mCCJaD/J81b7kY8naAZ9Qg/cp3Ux6cTrCppMq5petwUtH9bPQ44NEESyJ KiKLKjJ7rhRDIKMtTtOTTTMGWfjbCpneZwkkSC2TLJ4z0EnR3mYoK0H X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=lzSIvIzMz0JhJrzLXI0HAdPwsNPSSmEn6RbS+PTS9aQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241014_015652_472199_D0ED3E4A X-CRM114-Status: UNSURE ( 7.34 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series refactors some useless goto instructions as a preparation for the fix of a missing of_node_put() by means of the cleanup attribute. Signed-off-by: Javier Carrasco Reviewed-by: Umang Jain Reviewed-by: Dan Carpenter --- Changes in v2: - Refactor vchiq_probe() to remove goto instructions. - Declare and initialize the node right before its first usage. - Link to v1: https://lore.kernel.org/r/20241013-vchiq_arm-of_node_put-v1-1-f72b2a6e47d0@gmail.com --- Javier Carrasco (2): staging: vchiq_arm: refactor goto instructions in vchiq_probe() staging: vchiq_arm: Fix missing refcount decrement in error path for fw_node .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) --- base-commit: d61a00525464bfc5fe92c6ad713350988e492b88 change-id: 20241013-vchiq_arm-of_node_put-60a5eaaafd70 Best regards,