mbox series

[v3,0/2] staging: staging: vchiq_arm: Two memory leak fixes

Message ID 20241014100624.104987-1-umang.jain@ideasonboard.com (mailing list archive)
Headers show
Series staging: staging: vchiq_arm: Two memory leak fixes | expand

Message

Umang Jain Oct. 14, 2024, 10:06 a.m. UTC 
Two memory leaks were identified and this series addresses those leaks.

Changes in v3:
- Add Fixes tag to 1/2 as well.
  (Suggestion by Dan Carpenter)

changes in v2:
- Split patches into two

v1:
- https://lore.kernel.org/linux-staging/b176520b-5578-40b0-9d68-b1051810c5bb@gmx.net/T/#t

Umang Jain (2):
  staging: vchiq_arm: Utilise devm_kzalloc() for allocation
  staging: vchiq_arm: Utilize devm_kzalloc() for allocation

 .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c   | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Dan Carpenter Oct. 14, 2024, 10:11 a.m. UTC | #1 
On Mon, Oct 14, 2024 at 03:36:22PM +0530, Umang Jain wrote:
> Two memory leaks were identified and this series addresses those leaks.
> 
> Changes in v3:
> - Add Fixes tag to 1/2 as well.
>   (Suggestion by Dan Carpenter)

Thanks.

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter
Greg KH Oct. 16, 2024, 7:58 a.m. UTC | #2 
On Mon, Oct 14, 2024 at 03:36:22PM +0530, Umang Jain wrote:
> Two memory leaks were identified and this series addresses those leaks.
> 
> Changes in v3:
> - Add Fixes tag to 1/2 as well.
>   (Suggestion by Dan Carpenter)
> 
> changes in v2:
> - Split patches into two
> 
> v1:
> - https://lore.kernel.org/linux-staging/b176520b-5578-40b0-9d68-b1051810c5bb@gmx.net/T/#t
> 
> Umang Jain (2):
>   staging: vchiq_arm: Utilise devm_kzalloc() for allocation
>   staging: vchiq_arm: Utilize devm_kzalloc() for allocation

You have two commits with almost identical commit messages (one with a
spelling mistake.)  Please fix this up to have them be unique not in a
way with a misspelling :)

thanks,

greg k-h