From patchwork Tue Oct 15 19:15:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 13837017 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F806D1F9C5 for ; Tue, 15 Oct 2024 19:28:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+QOt9gzhjBA2a3HFdFsXGU33uA19Bo/pjPie57KuItA=; b=NCP5hU7VB7dRnv YM18l6rtgvJX9RlgX4ryPvKFhJ99fZVuyyUI8CiCk+BeQbmRa3gH1kYapXW0vpusagIbgGihKT3O7 SaKSsM75xB5vEY0qztQcywWsP1HkbCbBN4IBxtuXK6UN4ZztNku6z4ITvv18mISfUi47muFYQtE9n dX7CA3me+ZkgpNyseHWrFSiRrZODTVA5Vy1r58I7U9iQw0G+SIto8Qr/FlkxANwJn6ej7Iu6RJ/Er os33MAx9FygsaliWiDTeMGzuLvlT7iO7g+E/cKNAAGjyKfeAkJ4yNYiHc23QRKa5N5dtAoyXrRzdU 9bXmD392iWiAMXZMnt3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0nDl-00000009OaM-26EM; Tue, 15 Oct 2024 19:28:41 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0n2s-00000009MWG-1O4k for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Oct 2024 19:17:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=+QOt9gzhjBA2a3HFdFsXGU33uA19Bo/pjPie57KuItA=; b=Oizp58fnGu8YuTMFK5F7QJ1ioV wSgcGixVZNJeDcGQG6Z+1YyllV9/8I7KR7dq+tQJrvxwBFHF2ADEfZfB7IG17QhQ5Hs+rw1SOUjE9 kULHv2BLa8DrogItFJnM+Vt8mB5JkjeD56YGidtiXlbNBXYTWcTByphVGhHn4BPhVYuST5ws4lsbA mjW1un3sQBwQmD/Obe2shuty+E4346ls3X0x19nsqHoXQc1QNUl299EypmYnBfY1pNNNCZzSk92OR 5CzJeMYB1JOkDf8UVFIm/yGnJx9BmncKpQnyAyOK8DY/HtHXohRtR2jxwmvE7tT2KuHgqE/2ckNbg 7xJVYlDw==; Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0n2g-00000006dfd-2lOa for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2024 19:17:20 +0000 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2fb5014e2daso25446261fa.0 for ; Tue, 15 Oct 2024 12:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1729019829; x=1729624629; darn=lists.infradead.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=+QOt9gzhjBA2a3HFdFsXGU33uA19Bo/pjPie57KuItA=; b=VCuXcMNG5t2dVVrfjWud1sE18LTdKxH31oDdA3OY+996mKeOp7BMxuqcj9iScjxsi7 lvAPXCDmOzwwgTstRBGTEF58yrx76SZGfDoAwSNCKSMKa7Gs1YHGZUyEm7h7un7aHEXZ ot+9+Em52iOB6SqdV4I+0kWAamFm8W7rPyT/UnvVT3aGw5NG5FYFsjhZXAAllyK5hzyJ IJei7eWaHepAlFLq9voMer/PYuwrD0JiZZXrdoLWl5QlloY4mbn7PV/h262wWVyPw245 /qbn//ibPkzK+NVBtG81j2T6TnU0MJtk2fDWUgftxgT/t5CCafhvqsW0gWAWs9DvLH5H pFOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729019829; x=1729624629; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+QOt9gzhjBA2a3HFdFsXGU33uA19Bo/pjPie57KuItA=; b=e7U/pijmDGkq187g25aB4U8XzLB4LVnO2vi7ifFxHI8U4jOHehVsKvsQhQvr/jIIIB 9zELamJPoTJ7Tcx9rTzuKakpCdq/ZtDyU9Bk6bnprEz82jX/E3Sl+gwXEtpzkWnZaYYS viGCXfZu/6qLeeuRgwPczMUtZGV3i8pocIGGRNKObL1KlWCl7dnJCRnYbletZTw9on2n 7yX0jj5FsGTty9YCcoyXzzL6fNWpU1ROSRWROBeb/T8QQ+3K1LMslQv5yuMgFI/kCJpC Vv6rcjhOyEdAWCXN6BVX04U/mO2tdoYpa51iDUscIwCVIsjiO3ahI0qEJ3bPQCWau+dc wotQ== X-Forwarded-Encrypted: i=1; AJvYcCVoZYsHQLoCVEphve71IbQoFti4Aci8FsVHP8gvsh3AF3d7E2cQPJxE3IUA4oIR9FrqxuJGKXintc+QAaYvLtyr@lists.infradead.org X-Gm-Message-State: AOJu0YzEdP7WX2sqTl2feScjy9CXCC1qoFPp2u+nQUzqSlx7b0e+pa8k 9VVTPDOR1/nmCNgjLeyExX5N6ut239gKDfIJew5eu8HDJ/OwBLbjn4olbxLEE0A= X-Google-Smtp-Source: AGHT+IEZfN9DftNPsDmwiL1MDACcRsbm13jb32Ds2T5xIid0qTiIYe5LUNFD+F4+u8zsriFIRIS1Xw== X-Received: by 2002:a2e:6119:0:b0:2f7:5f6e:d894 with SMTP id 38308e7fff4ca-2fb3f247256mr48275281fa.25.1729019829277; Tue, 15 Oct 2024 12:17:09 -0700 (PDT) Received: from localhost ([2001:4090:a244:83ae:2517:2666:43c9:d0d3]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c98d7b7a96sm973002a12.93.2024.10.15.12.17.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Oct 2024 12:17:08 -0700 (PDT) From: Markus Schneider-Pargmann Subject: [PATCH v4 0/9] can: m_can: Add am62 wakeup support Date: Tue, 15 Oct 2024 21:15:54 +0200 Message-Id: <20241015-topic-mcan-wakeup-source-v6-12-v4-0-fdac1d1e7aa6@baylibre.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAGq/DmcC/4WNQQ6CMBAAv0J6dk23IFBP/sNwKG2VjUJJC1VC+ LuVePc4c5hZWbCebGDnbGXeRgrkhgTFIWO6U8PdApnETHBRIOcSJjeShl6rAV7qYecRgpu9thB LQAG1RlNKmWNrapYio7c3eu+Da5O4ozA5v+y/mH/tL434Lx1z4CCrk9AVFsqguLRqeVLr7VG7n jXbtn0A/Jw6388AAAA= X-Change-ID: 20241009-topic-mcan-wakeup-source-v6-12-8c1d69931bd8 To: Chandrasekar Ramakrishnan , Marc Kleine-Budde , Vincent Mailhol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Matthias Schiffer , Vishal Mahaveer , Kevin Hilman , Dhruva Gole , Simon Horman , Vincent MAILHOL , Markus Schneider-Pargmann , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4405; i=msp@baylibre.com; h=from:subject:message-id; bh=GtxskHIkNO8eIMlbmj3L18RvHD/mDf4rhq6VhZfNIhg=; b=owGbwMvMwCGm0rPl0RXRdfaMp9WSGNL59jfZFzMe9pvWeqfu5rqnVyrLZW9q3/3Mety2Kurpd sGoWIfZHaUsDGIcDLJiiix3Pyx8Vyd3fUHEukeOMHNYmUCGMHBxCsBExP8yMmw7ePPaknmR3osV Phs8ONJWIGZ7gT/8Ds89m/MVdx686tFj+O+3Lea4qF762avLgy11vra8qvu1NXqxO7tPMoNR9f7 NZSwA X-Developer-Key: i=msp@baylibre.com; a=openpgp; fpr=BADD88DB889FDC3E8A3D5FE612FA6A01E0A45B41 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241015_201718_252704_DA6DA442 X-CRM114-Status: GOOD ( 19.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Series ------ am62, am62a and am62p support Partial-IO, a poweroff SoC state with a few pin groups being active for wakeup. To support mcu_mcan0 and mcu_mcan1 wakeup for the mentioned SoCs, the series introduces a notion of wake-on-lan for m_can. If the user decides to enable wake-on-lan for a m_can device, the device is set to wakeup enabled. A 'wakeup' pinctrl state is selected to enable wakeup flags for the relevant pins. If wake-on-lan is disabled the default pinctrl is selected. It is based on v6.12-rc1. Partial-IO ---------- This series is part of a bigger topic to support Partial-IO on am62, am62a and am62p. Partial-IO is a poweroff state in which some pins are able to wakeup the SoC. In detail MCU m_can and two serial port pins can trigger the wakeup. A documentation can also be found in section 6.2.4 in the TRM: https://www.ti.com/lit/pdf/spruiv7 This other series is relevant for the support of Partial-IO: - firmware: ti_sci: Partial-IO support https://gitlab.baylibre.com/msp8/linux/-/tree/topic/am62-partialio/v6.12?ref_type=heads Testing ------- A test branch is available here that includes all patches required to test Partial-IO: https://gitlab.baylibre.com/msp8/linux/-/tree/integration/am62/v6.12?ref_type=heads After enabling Wake-on-LAN the system can be powered off and will enter the Partial-IO state in which it can be woken up by activity on the specific pins: ethtool -s can0 wol p ethtool -s can1 wol p poweroff I tested these patches on am62-lp-sk. Best, Markus Previous versions: v1: https://lore.kernel.org/lkml/20240523075347.1282395-1-msp@baylibre.com/ v2: https://lore.kernel.org/lkml/20240729074135.3850634-1-msp@baylibre.com/ v3: https://lore.kernel.org/lkml/20241011-topic-mcan-wakeup-source-v6-12-v3-0-9752c714ad12@baylibre.com Changes in v4: - Remove leftover testing code that always returned -EIO in a specific - Redesign pincontrol setup to be easier understandable and less nested - Fix missing parantheses around wol_enable expression - Remove | from binding description Changes in v3: - Rebase to v6.12-rc1 - Change 'wakeup-source' to only 'true' - Simplify m_can_set_wol by returning early on error - Add vio-suuply binding and handling of this optional property. vio-supply is used to reflect the SoC architecture and which power line powers the m_can unit. This is important as some units are powered in special low power modes. Changes in v2: - Rebase to v6.11-rc1 - Squash these two patches for the binding into one: dt-bindings: can: m_can: Add wakeup-source property dt-bindings: can: m_can: Add wakeup pinctrl state - Add error handling to multiple patches of the m_can driver - Add error handling in m_can_class_allocate_dev(). This also required to add a new patch to return error pointers from m_can_class_allocate_dev(). Signed-off-by: Markus Schneider-Pargmann --- Markus Schneider-Pargmann (8): dt-bindings: can: m_can: Add wakeup properties dt-bindings: can: m_can: Add vio-supply can: m_can: Map WoL to device_set_wakeup_enable can: m_can: Return ERR_PTR on error in allocation can: m_can: Support pinctrl wakeup state can: m_can: Add use of optional regulator arm64: dts: ti: k3-am62: Mark mcu_mcan0/1 as wakeup-source arm64: dts: ti: k3-am62a-mcu: Mark mcu_mcan0/1 as wakeup-source Vibhore Vardhan (1): arm64: dts: ti: k3-am62p-mcu: Mark mcu_mcan0/1 as wakeup-source .../devicetree/bindings/net/can/bosch,m_can.yaml | 22 ++++ arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi | 2 + arch/arm64/boot/dts/ti/k3-am62a-mcu.dtsi | 2 + .../boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 2 + drivers/net/can/m_can/m_can.c | 117 ++++++++++++++++++++- drivers/net/can/m_can/m_can.h | 4 + drivers/net/can/m_can/m_can_pci.c | 4 +- drivers/net/can/m_can/m_can_platform.c | 4 +- drivers/net/can/m_can/tcan4x5x-core.c | 4 +- 9 files changed, 152 insertions(+), 9 deletions(-) --- base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc change-id: 20241009-topic-mcan-wakeup-source-v6-12-8c1d69931bd8 Best regards,