| Message ID | 20241023075917.186835-1-ryan@testtoast.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: add Allwinner H616 audio codec support | expand |
On Wed, Oct 23, 2024 at 08:56:56PM +1300, Ryan Walklin wrote:
> V3 of this patch adding support for the Allwinner H616 (and variant)'s audio codec. Some clarification of comments, particularly regarding the clock driver changes, and a small fix for the device tree binding (apologies I forgot to re-run dt_binding_check on V2). Review comments otherwise addressed and reviews noted.
Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to.
On Wed, 23 Oct 2024 20:56:56 +1300, Ryan Walklin wrote: > V3 of this patch adding support for the Allwinner H616 (and variant)'s audio codec. Some clarification of comments, particularly regarding the clock driver changes, and a small fix for the device tree binding (apologies I forgot to re-run dt_binding_check on V2). Review comments otherwise addressed and reviews noted. > > Changelog v1..v2: > - Reordered patches to group ASoC changes > - Corrected PLL_AUDIO clock dividers to match values from manual and vendor SDK. > - Remove PLL_AUDIO_4X clock from the device tree binding (not used in the driver). > - Restrict TX-only DMA changes to the H616. > - Change the codec name to fit into the 16 char limit. > - Move the codec (and spdif) blocks in the H616 DTSI to restore address-order. > - Add board enablement (and power/GPIO changes for RG35XX to support speaker amp). > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [2/7] dt-bindings: allwinner: add H616 sun4i audio codec binding commit: 542e19c20506953c03eec57b1cb65355164dfb64 [3/7] ASoC: sun4i-codec: Add support for different DAC FIFOC addresses to quirks commit: 5836a9d2ca48bb7473bb10d061c03525d8f4f163 [4/7] ASoC: sun4i-codec: Add playback only flag to quirks commit: 9fde21d6c5d1f75c2651442e5aae463545136aad [5/7] ASoC: sun4i-codec: support allwinner H616 codec commit: 9155c321a1d0220a60878f2c99bc79b5a7e34d95 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Wed, 23 Oct 2024 20:56:56 +1300, Ryan Walklin wrote: > V3 of this patch adding support for the Allwinner H616 (and variant)'s audio codec. Some clarification of comments, particularly regarding the clock driver changes, and a small fix for the device tree binding (apologies I forgot to re-run dt_binding_check on V2). Review comments otherwise addressed and reviews noted. > > Changelog v1..v2: > - Reordered patches to group ASoC changes > - Corrected PLL_AUDIO clock dividers to match values from manual and vendor SDK. > - Remove PLL_AUDIO_4X clock from the device tree binding (not used in the driver). > - Restrict TX-only DMA changes to the H616. > - Change the codec name to fit into the 16 char limit. > - Move the codec (and spdif) blocks in the H616 DTSI to restore address-order. > - Add board enablement (and power/GPIO changes for RG35XX to support speaker amp). > > [...] Applied to clk-for-6.13 in git@github.com:linux-sunxi/linux-sunxi.git, thanks! [1/7] clk: sunxi-ng: h616: Add sigma-delta modulation settings for audio PLL commit: d0c322b6e4bff8cc0e40ee4983bf2ab1f7f680f0 Best regards,
On Wed, 23 Oct 2024 20:56:56 +1300, Ryan Walklin wrote: > V3 of this patch adding support for the Allwinner H616 (and variant)'s audio codec. Some clarification of comments, particularly regarding the clock driver changes, and a small fix for the device tree binding (apologies I forgot to re-run dt_binding_check on V2). Review comments otherwise addressed and reviews noted. > > Changelog v1..v2: > - Reordered patches to group ASoC changes > - Corrected PLL_AUDIO clock dividers to match values from manual and vendor SDK. > - Remove PLL_AUDIO_4X clock from the device tree binding (not used in the driver). > - Restrict TX-only DMA changes to the H616. > - Change the codec name to fit into the 16 char limit. > - Move the codec (and spdif) blocks in the H616 DTSI to restore address-order. > - Add board enablement (and power/GPIO changes for RG35XX to support speaker amp). > > [...] Applied to dt-for-6.13 in git@github.com:linux-sunxi/linux-sunxi.git, thanks! [6/7] arm64: dts: allwinner: h616: Add audio codec node commit: 3eef85034c96f61b54809e24d4b7f29a336701ae [7/7] arm64: dts: allwinner: h313/h616/h618/h700: Enable audio codec for all supported boards commit: 86a8f1aef9702f730c824aa96ae24ffa1b401988 Best regards,
Hi All, V3 of this patch adding support for the Allwinner H616 (and variant)'s audio codec. Some clarification of comments, particularly regarding the clock driver changes, and a small fix for the device tree binding (apologies I forgot to re-run dt_binding_check on V2). Review comments otherwise addressed and reviews noted. Changelog v1..v2: - Reordered patches to group ASoC changes - Corrected PLL_AUDIO clock dividers to match values from manual and vendor SDK. - Remove PLL_AUDIO_4X clock from the device tree binding (not used in the driver). - Restrict TX-only DMA changes to the H616. - Change the codec name to fit into the 16 char limit. - Move the codec (and spdif) blocks in the H616 DTSI to restore address-order. - Add board enablement (and power/GPIO changes for RG35XX to support speaker amp). Changelog v2..v3: - Update clock driver patch commit message and inline comments to more accurately describe SDM changes. - Fix missing "-" in H616 conditional binding as reported by dt_binding_check - Add additional clarification of internal playback_only quirk in sun4i-codec driver - Add short driver_name to H616 codec driver and restore descriptive name. - Remove leading 0 from codec node's address in H616 device tree to match other blocks. Original blurb below: Hi, The Allwinner H616 has a playback-only audio codec, with a single stereo or differential-mono line output. This patch adds support for the H616 (and H313/H618/H700/T507) SoC. Based on the Allwinner kernel SDK driver, and tested on the H700. Regards, Ryan Marcus Cooper (2): ASoC: sun4i-codec: Add support for different DAC FIFOC addresses to quirks ASoC: sun4i-codec: Add playback only flag to quirks Ryan Walklin (5): clk: sunxi-ng: h616: Add sigma-delta modulation settings for audio PLL dt-bindings: allwinner: add H616 sun4i audio codec binding ASoC: sun4i-codec: support allwinner H616 codec arm64: dts: allwinner: h616: Add audio codec node arm64: dts: allwinner: h313/h616/h618/h700: Enable audio codec for all supported boards .../sound/allwinner,sun4i-a10-codec.yaml | 53 +++- .../dts/allwinner/sun50i-h313-tanix-tx1.dts | 5 + .../allwinner/sun50i-h616-orangepi-zero.dtsi | 5 + .../dts/allwinner/sun50i-h616-x96-mate.dts | 5 + .../arm64/boot/dts/allwinner/sun50i-h616.dtsi | 44 ++- .../allwinner/sun50i-h618-orangepi-zero2w.dts | 5 + .../sun50i-h618-transpeed-8k618-t.dts | 5 + .../sun50i-h700-anbernic-rg35xx-2024.dts | 13 +- drivers/clk/sunxi-ng/ccu-sun50i-h616.c | 46 ++- sound/soc/sunxi/sun4i-codec.c | 298 +++++++++++++++--- 10 files changed, 404 insertions(+), 75 deletions(-)