From patchwork Sun Nov 3 16:57:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Drew Fustini X-Patchwork-Id: 13860460 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4609D11183 for ; Sun, 3 Nov 2024 17:00:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=SiRHBTzAaAAcdz9wR1AEo/4hHR8Jww4cDbAZ/MX74uo=; b=n7PBOfUwmt0fFH DrYb/w+nyR+geo4nsKvFHA8eEdw3vZsNAfIMbJZ75toDc3ZlRQ0WXctA+4k5WfmJOlvi7fvgas14g t+0xoZHCnvDmaOV08T5h0c45tDbkvzYNH2UUV8PQSoZhm2zeJ86ZSwe7KfIUjD/clKNiMSn3vHvSq rWei2npQPnNwxDhta8/TLnEBh8rB7tgZcZ7RQObAuY2dj8qsho7551wqsjsoGVSNjOtZHx77SXBN6 3XAX8dHsaO/r/eNVYxdqD1tznDziQJAW+UB4/fc+0EWLKGUZhreZk/oD2RDafLCYj2ZxHjI65jT1f H0QtPDd8W8dY/66hmbLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t7dxD-0000000Bjd6-1abh; Sun, 03 Nov 2024 16:59:55 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t7dvU-0000000BjMV-41X6 for linux-arm-kernel@lists.infradead.org; Sun, 03 Nov 2024 16:58:11 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-20e6981ca77so36175985ad.2 for ; Sun, 03 Nov 2024 08:58:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tenstorrent.com; s=google; t=1730653087; x=1731257887; darn=lists.infradead.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=SiRHBTzAaAAcdz9wR1AEo/4hHR8Jww4cDbAZ/MX74uo=; b=h3OgtW9KfN0hM/bRFRFl78mu/1TPBJr7k3V+TxQ1Qzhe21udqCckDzqh7paDHtgewD QjbVLxHYjUj+icYGwmS4oGQowWnOlMME1SH+jML90yfSnAL1dL/jgnAHc/U/Wjfp+V/S KrFSw+45AiIxKeFtdUdqg5gQ0klrApLpC9/Cc7FLF9bBRGAR0+COteC9tykfA2Qknufx V+C0qjA/Hrz8BUEIrpfVjhKObRAYLmkxUjTtmxS8d2+9HUmuzEN0vDd1I34mZoYVuHEU XJsoSKJ8jmXeTJYossX44dt97uNXfUjFih7nKEVEI36kQGzeJaG1aiTVbtJyBDtP/5QI NG8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730653087; x=1731257887; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SiRHBTzAaAAcdz9wR1AEo/4hHR8Jww4cDbAZ/MX74uo=; b=KuYxOJJBxIrRl5hCJA5WqA5RqnEE12dR5YLJt+NDw56sm2nsWyq9xI0INjK7vI+YJf tMofILL7FQ9N5avLkwVFpnH7pG7XB6/s0ZUWZw9Sg2kKGMelAmGCDO4imuvi/43d6dWV lM/r7is2Kbc3TOXdFOyORvmguiHkyCOWlTgWGG6J3CNaPaX0KEVf5r037KbLfMGYaJZa aIdDn/IKJhOpsa1qRjOa1/iCitAjCm3gB2qNFbVigIgWrKZtqeTsXXhWrFbPhflODKBJ zGs3xM9FKx9zlzC7+a+thXvuIQT4huiu3f3c3p/2f6FIAemPjbNy9MGz/y6VKDQtRuwS vtoA== X-Forwarded-Encrypted: i=1; AJvYcCVJE2nGpRy5bOlVO7JWnu8Hr4GSBMsRvnryBbCTPUavKo3n76XcjF2+iGAWJosUxbPeJ8eogvSB8cd5qbBEmw/7@lists.infradead.org X-Gm-Message-State: AOJu0YwwmOb/blb2/otc8FmTqz5fKtV57rEv9S058j3d9MAFw3S/8KC+ ILOm3+IHrMcQvNlZm8Edj5X5PPmU9D32SGoWZ6CZauBlI+1r37cMLngzrZanqyA= X-Google-Smtp-Source: AGHT+IHZ3SR688u4NeecI0FgN5pXp5mQEMhPTdsDVQGdNI3vsPP0cL6muQcMZTinATTJ8tXbeT7e2A== X-Received: by 2002:a17:902:c40c:b0:20c:7d4c:64db with SMTP id d9443c01a7336-21103c7bfafmr179492615ad.49.1730653087220; Sun, 03 Nov 2024 08:58:07 -0800 (PST) Received: from [127.0.1.1] (71-34-69-82.ptld.qwest.net. [71.34.69.82]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057c9783sm47531355ad.236.2024.11.03.08.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Nov 2024 08:58:06 -0800 (PST) From: Drew Fustini Subject: [PATCH net-next v7 0/2] Add the dwmac driver support for T-HEAD TH1520 SoC Date: Sun, 03 Nov 2024 08:57:58 -0800 Message-Id: <20241103-th1520-gmac-v7-0-ef094a30169c@tenstorrent.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAJerJ2cC/23NTQ7CIBQE4KuYtxYDlD9deQ/jgtDXlkWpAUJqm t5dZKXR5WQy32yQMHpMcDlsELH45JdQgz4ewE02jEh8XzNwygWjXJI8MckpGWfriDZWK2vP1Ck OdfGIOPi1aTcImEnANcO9NpNPeYnPdlNk6/+KRRJKOtNTK4ygahiuGcN7GjHkk1vmphX1IXT0W 1BVQGGYVr2QjKlfYd/3F0fDCcj4AAAA To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Coquelin , Emil Renner Berthing , Jisheng Zhang , Guo Ren , Fu Wei , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Lunn , Drew Fustini Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Drew Fustini , linux-stm32@st-md-mailman.stormreply.com, Krzysztof Kozlowski X-Mailer: b4 0.14.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241103_085809_062235_26DD70AB X-CRM114-Status: GOOD ( 21.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series adds support for dwmac gigabit ethernet in the T-Head TH1520 RISC-V SoC used on boards like BeagleV Ahead and the LicheePi 4A. The gigabit ethernet on these boards does need pinctrl support to mux the necessary pads. The pinctrl-th1520 driver, pinctrl binding, and related dts patches are in linux-next. However, they are not yet in net-next/main. Therefore, I am dropping the dts patch for v5 as it will not build on net-next/main due to the lack of the padctrl0_apsys pin controller node in next-next/main version th1520.dtsi. It does exist in linux-next [1] and the two patches in this series allow the ethernet ports to work correctly on the LPi4A and Ahead when applied to linux-next. The dwmac-thead driver in this series does not need the pinctrl-th1520 driver to build. Nor does the thead,th1520-gmac.yaml binding need the pinctrl binding to pass the schema check. [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/riscv/boot/dts/thead/th1520.dtsi Changes in v7: - Remove GMAC_RXCLK_DELAY_VAL(x), GMAC_RXCLK_DELAY_VAL(x) and GMAC_PLLCLK_DIV_NUM(x) marcos - Fix register write in thead_dwmac_fix_speed() by using FIELD_PREP() directly instead of the above macros - Fix thead_dwmac_init() to preserve bypass and invert bits when writing to GMAC_RXCLK_DELAY_CTRL and GMAC_TXCLK_DELAY_CTRL - Add sentinel to end of thead_dwmac_match[] - Normalize capitalization in dev_err_probe message - Link to v6: https://lore.kernel.org/r/20241030-th1520-gmac-v6-0-e48176d45116@tenstorrent.com Changes in v6: - Remove unnecessary semicolon from end of switch() blocks - Add Rb from Andrew Lunn on both patches - Link to v5: https://lore.kernel.org/r/20241025-th1520-gmac-v5-0-38d0a48406ff@tenstorrent.com Changes in v5: - Rebase on net-next/main - Drop the dts patch from this series. It applies to linux-next but not net-next/main. - Remove repeated properties from required: in binding - Add Rb from Krzysztof for binding - Link to v4: https://lore.kernel.org/r/20241020-th1520-dwmac-v4-0-c77acd33ccef@tenstorrent.com Changes in v4: - Rebase on next for pinctrl dependency - Add 'net-next' prefix to subject per maintainer-netdev.rst - Add clocks, clock-names, interrupts and interrupt-names to binding - Simplify driver code by switching from regmap to regualar mmio Changes in v3: - Rebase on v6.12-rc1 - Remove thead,rx-internal-delay and thead,tx-internal-delay properties - Remove unneeded call to thead_dwmac_fix_speed() during probe - Fix filename for the yaml file in MAINTAINERS patch - Link: https://lore.kernel.org/linux-riscv/20240930-th1520-dwmac-v3-0-ae3e03c225ab@tenstorrent.com/ Changes in v2: - Drop the first patch as it is no longer needed due to upstream commit d01e0e98de31 ("dt-bindings: net: dwmac: Validate PBL for all IP-cores") - Rename compatible from "thead,th1520-dwmac" to "thead,th1520-gmac" - Add thead,rx-internal-delay and thead,tx-internal-delay properties and check that it does not exceed the maximum value - Convert from stmmac_dvr_probe() to devm_stmmac_pltfr_probe() and delete the .remove_new hook as it is no longer needed - Handle return value of regmap_write() in case it fails - Add phy reset delay properties to the BeagleV Ahead device tree - Link: https://lore.kernel.org/linux-riscv/20240926-th1520-dwmac-v2-0-f34f28ad1dc9@tenstorrent.com/ Changes in v1: - remove thead,gmacapb that references syscon for APB registers - add a second memory region to gmac nodes for the APB registers - Link: https://lore.kernel.org/all/20240713-thead-dwmac-v1-0-81f04480cd31@tenstorrent.com/ --- Jisheng Zhang (2): dt-bindings: net: Add T-HEAD dwmac support net: stmmac: Add glue layer for T-HEAD TH1520 SoC .../devicetree/bindings/net/snps,dwmac.yaml | 1 + .../devicetree/bindings/net/thead,th1520-gmac.yaml | 110 +++++++++ MAINTAINERS | 2 + drivers/net/ethernet/stmicro/stmmac/Kconfig | 10 + drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + drivers/net/ethernet/stmicro/stmmac/dwmac-thead.c | 273 +++++++++++++++++++++ 6 files changed, 397 insertions(+) --- base-commit: 03fc07a24735e0be8646563913abf5f5cb71ad19 change-id: 20241025-th1520-gmac-78a76aa90c62 Best regards,