[net-next,v3,0/9] Support external snapshots on dwmac1000

Message

Maxime Chevallier Nov. 6, 2024, 9:03 a.m. UTC

Hi,

This V3 is just a rebase a V2 on top of net-next to address some minor
conflicts. No changes were made.

This series is another take on the pervious work [1] done by
Alexis Lothoré, that fixes the support for external snapshots
timestamping in GMAC3-based devices.

Details on why this is needed are mentionned on the cover [2] from V1.

This V2 addresses multiple issues found in V1 :

 - The PTP_TCR register is configured from multiple places, as reported
   by Alexis, so we need to make sure that the extts configuration
   doesn't interfere with the hwtstamp configuration.

 - The interrupt management in V1 was incomplete, as the interrupt
   wasn't correctly acked.

 - This series also makes so that we only enable the extts interrupt
   when necessary.

[1]: https://lore.kernel.org/netdev/[e-mail]/
[2]: https://lore.kernel.org/netdev/[e-mail]/

Thanks Alexis for laying the groundwork for this,

Best regards,

Maxime

Link to V1: https://lore.kernel.org/netdev/[e-mail]/
Link to V2: https://lore.kernel.org/netdev/[e-mail]/

Maxime Chevallier (9):
  net: stmmac: Don't modify the global ptp ops directly
  net: stmmac: Use per-hw ptp clock ops
  net: stmmac: Only update the auto-discovered PTP clock features
  net: stmmac: Introduce dwmac1000 ptp_clock_info and operations
  net: stmmac: Introduce dwmac1000 timestamping operations
  net: stmmac: Enable timestamping interrupt on dwmac1000
  net: stmmac: Don't include dwmac4 definitions in stmmac_ptp
  net: stmmac: Configure only the relevant bits for timestamping setup
  net: stmmac: dwmac_socfpga: This platform has GMAC

 drivers/net/ethernet/stmicro/stmmac/common.h  |   4 +
 .../ethernet/stmicro/stmmac/dwmac-socfpga.c   |   1 +
 .../net/ethernet/stmicro/stmmac/dwmac1000.h   |  12 +++
 .../ethernet/stmicro/stmmac/dwmac1000_core.c  | 101 ++++++++++++++++++
 drivers/net/ethernet/stmicro/stmmac/hwif.c    |  15 ++-
 .../ethernet/stmicro/stmmac/stmmac_hwtstamp.c |  26 ++++-
 .../net/ethernet/stmicro/stmmac/stmmac_ptp.c  |  38 +++++--
 .../net/ethernet/stmicro/stmmac/stmmac_ptp.h  |  10 ++
 8 files changed, 196 insertions(+), 11 deletions(-)

Comments

Daniel Machon Nov. 7, 2024, 7:19 p.m. UTC | #1

> Hi,
> 
> This V3 is just a rebase a V2 on top of net-next to address some minor
> conflicts. No changes were made.
> 
> This series is another take on the pervious work [1] done by
> Alexis Lothoré, that fixes the support for external snapshots
> timestamping in GMAC3-based devices.
> 
> Details on why this is needed are mentionned on the cover [2] from V1.
> 
> This V2 addresses multiple issues found in V1 :
> 
>  - The PTP_TCR register is configured from multiple places, as reported
>    by Alexis, so we need to make sure that the extts configuration
>    doesn't interfere with the hwtstamp configuration.
> 
>  - The interrupt management in V1 was incomplete, as the interrupt
>    wasn't correctly acked.
> 
>  - This series also makes so that we only enable the extts interrupt
>    when necessary.
> 
> [1]: https://lore.kernel.org/netdev/[e-mail]/
> [2]: https://lore.kernel.org/netdev/[e-mail]/
> 
> Thanks Alexis for laying the groundwork for this,
> 
> Best regards,
> 
> Maxime
> 
> Link to V1: https://lore.kernel.org/netdev/[e-mail]/
> Link to V2: https://lore.kernel.org/netdev/[e-mail]/

Hi Maxime,

Dont know much about this particular driver, but the patches looked good
to me!

For the series:

Reviewed-by: Daniel Machon <[e-mail]>