| Message ID | 20250103-wake_irq-v2-0-e3aeff5e9966@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | pm: Introduce devm_pm_set_wake_irq | expand |
Hi Alexandre, Dmitry On Fri, Jan 03, 2025 at 04:41:12PM +0800, Peng Fan (OSS) wrote: >This was a retry to address [1][2], to let common code handle >dev_pm_clear_wake_irq. Then no need to call dev_pm_clear_wake_irq >in each driver.remove() hook and error handling path. Patch 1 has been accepted into pm tree. For the rtc and input patches, are you ok with them? Thanks, Peng
Hello: This series was applied to riscv/linux.git (fixes) by Rafael J. Wysocki <rafael.j.wysocki@intel.com>: On Fri, 03 Jan 2025 16:41:12 +0800 you wrote: > This was a retry to address [1][2], to let common code handle > dev_pm_clear_wake_irq. Then no need to call dev_pm_clear_wake_irq > in each driver.remove() hook and error handling path. > > In this patchset, I include input and rtc patches to show the usage > to avoid introducing an API without users. There are still > other places using dev_pm_clear_wake_irq. If this patchset is > good for you, I could start to clean up other drivers such as mmc and > etc. > > [...] Here is the summary with links: - [v2,01/12] PM: sleep: wakeirq: Introduce device-managed variant of dev_pm_set_wake_irq https://git.kernel.org/riscv/c/fd8318a32573 - [v2,02/12] input: keyboard: ep93xx_keypad: Use devm_pm_set_wake_irq (no matching commit) - [v2,03/12] input: keyboard: omap4_keypad: Use devm_pm_set_wake_irq (no matching commit) - [v2,04/12] input: misc: nxp-bbnsm-pwrkey: Use resource managed API to simplify code (no matching commit) - [v2,05/12] input: touchscreen: ti_am335x_tsc: Use resource managed API to simplify code (no matching commit) - [v2,06/12] rtc: stm32: Use resource managed API to simplify code (no matching commit) - [v2,07/12] rtc: nxp-bbnsm: Use resource managed API to simplify code (no matching commit) - [v2,08/12] rtc: ds1343: Use devm_pm_set_wake_irq (no matching commit) - [v2,09/12] rtc: pm8xxx: Use devm_pm_set_wake_irq (no matching commit) - [v2,10/12] rtc: ab8500: Use resource managed API to simplify code (no matching commit) - [v2,11/12] rtc: mpfs: Use devm_pm_set_wake_irq (no matching commit) - [v2,12/12] rtc: pl031: Use resource managed API to simplify code (no matching commit) You are awesome, thank you!
This was a retry to address [1][2], to let common code handle dev_pm_clear_wake_irq. Then no need to call dev_pm_clear_wake_irq in each driver.remove() hook and error handling path. In this patchset, I include input and rtc patches to show the usage to avoid introducing an API without users. There are still other places using dev_pm_clear_wake_irq. If this patchset is good for you, I could start to clean up other drivers such as mmc and etc. [1] https://lore.kernel.org/all/20241111092131.1693319-1-peng.fan@oss.nxp.com/ [2] https://lore.kernel.org/all/ZymxvLMkkktRoCXZ@google.com/ Signed-off-by: Peng Fan <peng.fan@nxp.com> --- Changes in v2: - Add R-b from Linus Walleij. Thanks! - Export devm_pm_set_wake_irq to fix module build failure. - Link to v1: https://lore.kernel.org/r/20241228-wake_irq-v1-0-09cfca77cd47@nxp.com --- Peng Fan (12): PM: sleep: wakeirq: Introduce device-managed variant of dev_pm_set_wake_irq input: keyboard: ep93xx_keypad: Use devm_pm_set_wake_irq input: keyboard: omap4_keypad: Use devm_pm_set_wake_irq input: misc: nxp-bbnsm-pwrkey: Use resource managed API to simplify code input: touchscreen: ti_am335x_tsc: Use resource managed API to simplify code rtc: stm32: Use resource managed API to simplify code rtc: nxp-bbnsm: Use resource managed API to simplify code rtc: ds1343: Use devm_pm_set_wake_irq rtc: pm8xxx: Use devm_pm_set_wake_irq rtc: ab8500: Use resource managed API to simplify code rtc: mpfs: Use devm_pm_set_wake_irq rtc: pl031: Use resource managed API to simplify code drivers/base/power/wakeirq.c | 26 +++++++++++++++++++ drivers/input/keyboard/ep93xx_keypad.c | 8 +----- drivers/input/keyboard/omap4-keypad.c | 8 +----- drivers/input/misc/nxp-bbnsm-pwrkey.c | 15 ++++------- drivers/input/touchscreen/ti_am335x_tsc.c | 43 ++++++++++--------------------- drivers/rtc/rtc-ab8500.c | 11 ++------ drivers/rtc/rtc-ds1343.c | 8 +----- drivers/rtc/rtc-mpfs.c | 8 +----- drivers/rtc/rtc-nxp-bbnsm.c | 29 +++++++-------------- drivers/rtc/rtc-pl031.c | 6 ++--- drivers/rtc/rtc-pm8xxx.c | 12 +-------- drivers/rtc/rtc-stm32.c | 10 ++----- include/linux/pm_wakeirq.h | 6 +++++ 13 files changed, 71 insertions(+), 119 deletions(-) --- base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2 change-id: 20241227-wake_irq-b68d604dd902 Best regards,