| Message ID | 20250120130119.671119-1-svarbanov@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add PCIe support for bcm2712 | expand |
Hi Stan, On 01-20 15:01, Stanimir Varbanov wrote: > > Here is v5 of the series which aims to add support for PCIe on bcm2712 SoC > used by RPi5. Previous v4 can be found at [1]. > > Based the series on linux-next because of vc4 gpu node in bcm2712.dtsi. > > v4 -> v5 changes include: > - Addressed comments to interrupt-controller driver. (Thomas) > - Fixed DTB warnings broadcom/bcm2712-rpi-5-b.dtb. > - New patch in the series to fix missing of_node_put. > - New patch to make a softdep to a MIP MSI-X driver. > - Dropped the patch which adds MSI-X support in pcie-brcmstb driver, > and instead use DT dma-ranges to pass the needed information. (Jim) > > For more detailed info check patches. > > Comments are welcome! > ~Stan > > [1] https://patchwork.kernel.org/project/linux-pci/cover/20241025124515.14066-1-svarbanov@suse.de/ > > Stanimir Varbanov (11): > dt-bindings: interrupt-controller: Add bcm2712 MSI-X DT bindings > dt-bindings: PCI: brcmstb: Update bindings for PCIe on bcm2712 > irqchip: Add Broadcom bcm2712 MSI-X interrupt controller > PCI: brcmstb: Reuse config structure > PCI: brcmstb: Expand inbound window size up to 64GB > PCI: brcmstb: Add bcm2712 support > PCI: brcmstb: Adjust PHY PLL setup to use a 54MHz input refclk > PCI: brcmstb: Adding a softdep to MIP MSI-X driver > PCI: brcmstb: Fix for missing of_node_put > arm64: dts: broadcom: bcm2712: Add PCIe DT nodes > arm64: dts: broadcom: bcm2712-rpi-5-b: Enable PCIe DT nodes > > .../brcm,bcm2712-msix.yaml | 60 ++++ > .../bindings/pci/brcm,stb-pcie.yaml | 6 +- > .../boot/dts/broadcom/bcm2712-rpi-5-b.dts | 8 + > arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 147 +++++++++ > drivers/irqchip/Kconfig | 16 + > drivers/irqchip/Makefile | 1 + > drivers/irqchip/irq-bcm2712-mip.c | 292 ++++++++++++++++++ > drivers/pci/controller/pcie-brcmstb.c | 147 ++++++--- > 8 files changed, 632 insertions(+), 45 deletions(-) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2712-msix.yaml > create mode 100644 drivers/irqchip/irq-bcm2712-mip.c Thanks! This works fine. Tested-by: Ivan T. Ivanov <iivanov@suse.de>
Hi Bjorn, Do I need to send a new version with the collected Acked/Reviewed tags? Thanks, ~Stan On 1/20/25 3:01 PM, Stanimir Varbanov wrote: > Here is v5 of the series which aims to add support for PCIe on bcm2712 SoC > used by RPi5. Previous v4 can be found at [1]. > > Based the series on linux-next because of vc4 gpu node in bcm2712.dtsi. > > v4 -> v5 changes include: > - Addressed comments to interrupt-controller driver. (Thomas) > - Fixed DTB warnings broadcom/bcm2712-rpi-5-b.dtb. > - New patch in the series to fix missing of_node_put. > - New patch to make a softdep to a MIP MSI-X driver. > - Dropped the patch which adds MSI-X support in pcie-brcmstb driver, > and instead use DT dma-ranges to pass the needed information. (Jim) > > For more detailed info check patches. > > Comments are welcome! > ~Stan > > [1] https://patchwork.kernel.org/project/linux-pci/cover/20241025124515.14066-1-svarbanov@suse.de/ > > Stanimir Varbanov (11): > dt-bindings: interrupt-controller: Add bcm2712 MSI-X DT bindings > dt-bindings: PCI: brcmstb: Update bindings for PCIe on bcm2712 > irqchip: Add Broadcom bcm2712 MSI-X interrupt controller > PCI: brcmstb: Reuse config structure > PCI: brcmstb: Expand inbound window size up to 64GB > PCI: brcmstb: Add bcm2712 support > PCI: brcmstb: Adjust PHY PLL setup to use a 54MHz input refclk > PCI: brcmstb: Adding a softdep to MIP MSI-X driver > PCI: brcmstb: Fix for missing of_node_put > arm64: dts: broadcom: bcm2712: Add PCIe DT nodes > arm64: dts: broadcom: bcm2712-rpi-5-b: Enable PCIe DT nodes > > .../brcm,bcm2712-msix.yaml | 60 ++++ > .../bindings/pci/brcm,stb-pcie.yaml | 6 +- > .../boot/dts/broadcom/bcm2712-rpi-5-b.dts | 8 + > arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 147 +++++++++ > drivers/irqchip/Kconfig | 16 + > drivers/irqchip/Makefile | 1 + > drivers/irqchip/irq-bcm2712-mip.c | 292 ++++++++++++++++++ > drivers/pci/controller/pcie-brcmstb.c | 147 ++++++--- > 8 files changed, 632 insertions(+), 45 deletions(-) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2712-msix.yaml > create mode 100644 drivers/irqchip/irq-bcm2712-mip.c >
On Tue, Feb 11, 2025 at 03:30:22PM +0200, Stanimir Varbanov wrote: > Hi Bjorn, > > Do I need to send a new version with the collected Acked/Reviewed tags? No need to resend unless you change the code. Bjorn
Hi Bjorn, On 2/12/25 8:04 PM, Bjorn Helgaas wrote: > On Tue, Feb 11, 2025 at 03:30:22PM +0200, Stanimir Varbanov wrote: >> Hi Bjorn, >> >> Do I need to send a new version with the collected Acked/Reviewed tags? > > No need to resend unless you change the code. At this point I have no plans to change the code. > > Bjorn Thank you! ~Stan