| Message ID | 20250206201036.1516800-1-sean.anderson@linux.dev (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: xilinx: axienet: Enable adaptive IRQ coalescing with DIM | expand |
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 6 Feb 2025 15:10:32 -0500 you wrote: > To improve performance without sacrificing latency under low load, > enable DIM. While I appreciate not having to write the library myself, I > do think there are many unusual aspects to DIM, as detailed in the last > patch. > > Changes in v5: > - Move axienet_coalesce_params doc fix to correct patch > - Rebase onto net-next/master > > [...] Here is the summary with links: - [net-next,v5,1/4] net: xilinx: axienet: Combine CR calculation https://git.kernel.org/netdev/net-next/c/e76d1ea8cb18 - [net-next,v5,2/4] net: xilinx: axienet: Support adjusting coalesce settings while running https://git.kernel.org/netdev/net-next/c/d048c717df33 - [net-next,v5,3/4] net: xilinx: axienet: Get coalesce parameters from driver state https://git.kernel.org/netdev/net-next/c/eb80520e8a5b - [net-next,v5,4/4] net: xilinx: axienet: Enable adaptive IRQ coalescing with DIM https://git.kernel.org/netdev/net-next/c/e1d27d29dbe5 You are awesome, thank you!
To improve performance without sacrificing latency under low load, enable DIM. While I appreciate not having to write the library myself, I do think there are many unusual aspects to DIM, as detailed in the last patch. Changes in v5: - Move axienet_coalesce_params doc fix to correct patch - Rebase onto net-next/master Changes in v4: - Rebase onto net-next/master - Fix incorrect function name in doc comment for axienet_coalesce_params Changes in v3: - Fix mismatched parameter name documentation for axienet_calc_cr - Integrate some cleanups originally included in https://lore.kernel.org/netdev/20240909230908.1319982-1-sean.anderson@linux.dev/ - Move spin (un)locking in IRQs inside the if condition of napi_schedule_prep. This lets us hold the lock just for the rmw. - Fix function name in doc comments for axienet_update_coalesce_rx/tx - Adjust axienet_local doc comment order to match the members - Rebase onto net-next/master Changes in v2: - Don't use spin_lock_irqsave when we know the context - Split the CR calculation refactor from runtime coalesce settings adjustment support for easier review. - Have axienet_update_coalesce_rx/tx take the cr value/mask instead of calculating it with axienet_calc_cr. This will make it easier to add partial updates in the next few commits. - Get coalesce parameters from driver state - Don't take the RTNL in axienet_rx_dim_work to avoid deadlock. Instead, calculate a partial cr update that axienet_update_coalesce_rx can perform under a spin lock. - Use READ/WRITE_ONCE when accessing/modifying rx_irqs Sean Anderson (4): net: xilinx: axienet: Combine CR calculation net: xilinx: axienet: Support adjusting coalesce settings while running net: xilinx: axienet: Get coalesce parameters from driver state net: xilinx: axienet: Enable adaptive IRQ coalescing with DIM drivers/net/ethernet/xilinx/Kconfig | 1 + drivers/net/ethernet/xilinx/xilinx_axienet.h | 29 +- .../net/ethernet/xilinx/xilinx_axienet_main.c | 312 ++++++++++++++---- 3 files changed, 264 insertions(+), 78 deletions(-)