mbox series

[v2,0/2] apple-nvme: bug fixes

Message ID 20250213-nvme-fixes-v2-0-a20032d13e38@rosenzweig.io (mailing list archive)
Headers show
Series apple-nvme: bug fixes | expand

Message

Alyssa Rosenzweig Feb. 13, 2025, 4:12 p.m. UTC
This small series fixes two unrelated issues with the Apple NVMe driver.

* fix NVMe on certain combinations of firmware + machine
* fix a power domain leak

Although these are strict bug fixes, given the early stage of mainlining
for these SoCs, none of this needs to be backported.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
---
Changes in v2:
- Add Neal's review
- Drop cache flush change.
- Link to v1: https://lore.kernel.org/r/20250211-nvme-fixes-v1-0-6958b3aa49fe@rosenzweig.io

---
Hector Martin (2):
      apple-nvme: Support coprocessors left idle
      apple-nvme: Release power domains when probe fails

 drivers/nvme/host/apple.c | 55 ++++++++++++++++++++++++++++++++---------------
 1 file changed, 38 insertions(+), 17 deletions(-)
---
base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
change-id: 20250211-nvme-fixes-29c409c2553f

Best regards,

Comments

Sven Peter Feb. 13, 2025, 4:14 p.m. UTC | #1
On Thu, Feb 13, 2025, at 17:12, Alyssa Rosenzweig wrote:
> This small series fixes two unrelated issues with the Apple NVMe driver.
>
> * fix NVMe on certain combinations of firmware + machine
> * fix a power domain leak
>
> Although these are strict bug fixes, given the early stage of mainlining
> for these SoCs, none of this needs to be backported.
>
> Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
> ---

For both patches:

Reviewed-by: Sven Peter <sven@svenpeter.dev>



Best,


Sven
Keith Busch Feb. 18, 2025, 3:42 p.m. UTC | #2
On Thu, Feb 13, 2025 at 11:12:57AM -0500, Alyssa Rosenzweig wrote:
> This small series fixes two unrelated issues with the Apple NVMe driver.
> 
> * fix NVMe on certain combinations of firmware + machine
> * fix a power domain leak

Thanks, applied to nvme-6.14.