From patchwork Fri Feb 14 15:13:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Shameer Kolothum X-Patchwork-Id: 13975103 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 233F0C02198 for ; Fri, 14 Feb 2025 15:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=MdVwyOd9l/FIp8fu7EfT0bCYCDOniIiHav6CbLw72YQ=; b=4rgwJGLCQC3vJbwJB1HRmWwJRN tkXBd0rvKGCNRswxENDwhKGBx46rFR8Uj0CvdT43PXwjT2AtklzmDjzy4ERtc5kIgbfOELMnuDPo6 3aAkYgLW4I7JfOPHoGmJgofeodCiOYktQbs5qjZM6pyujP24StwnwXw9bHhs1X30ZGFk9QrlMfbFp q8V0FVWKgimUHv4i0WbzhGTwc8MQEfP6PcRPnHX2tsWljlaX8v9kBaZZ/lfA96t30fYv3FCsYdalv rhAI74GFNfNSy293+TFfXzx7AmqbLV+w1FkNmRBWg3vzc+OpzJLQMk7FNI1ZfJTFeFlELdc5RvZbY k03dFDBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tixR1-0000000FH8p-0isy; Fri, 14 Feb 2025 15:16:55 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tixOT-0000000FGYd-0gsY for linux-arm-kernel@lists.infradead.org; Fri, 14 Feb 2025 15:14:19 +0000 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YvbC05c6Jz6HJf8; Fri, 14 Feb 2025 23:12:44 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 5F9041404F5; Fri, 14 Feb 2025 23:14:06 +0800 (CST) Received: from A2303104131.china.huawei.com (10.203.177.241) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 14 Feb 2025 16:13:58 +0100 From: Shameer Kolothum To: , , CC: , , , , , , , , , , , , Subject: [PATCH v7 0/5] KVM: arm64: Errata management for VM Live migration Date: Fri, 14 Feb 2025 15:13:38 +0000 Message-ID: <20250214151343.61348-1-shameerali.kolothum.thodi@huawei.com> X-Mailer: git-send-email 2.12.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.203.177.241] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To frapeml500008.china.huawei.com (7.182.85.71) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250214_071417_487828_A09179EC X-CRM114-Status: GOOD ( 12.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, v6-->v7 https://lore.kernel.org/kvmarm/20250205132222.55816-1-shameerali.kolothum.thodi@huawei.com/ Changes:  -Introduced KVM_REG_ARM_VENDOR_HYP_BMAP_2 register for new hypercall support(patch #3) -Added selftest for KVM_REG_ARM_VENDOR_HYP_BMAP_2(patch #5). This can be sanity tested by the Qemu branch here, https://github.com/hisilicon/qemu/tree/v9.0-nv-rfcv4-vcpu-model-v2-target-cpu-errata (branch based on Eric's/Connie's NV + custom CPU series) Eg: to specify target impl CPUs, -machine virt,.., x-target-impl-cpus=0xMIDR1:0xREVIDR1-0xMIDR2:REVIDR2 Please take a look and let me know your feedback. Thanks, Shameer v5 --> v6 https://lore.kernel.org/kvmarm/20250124151732.6072-1-shameerali.kolothum.thodi@huawei.com/ -Addressed comments from Oliver,  -Changed version to 32 bit to match SMCCC_VERSION  -Don't advertise pKVM hypercalls to guests.  -Moved hypercall invocation to kvm_guest.c v4 --> v5 https://lore.kernel.org/kvmarm/20241218105345.73472-1-shameerali.kolothum.thodi@huawei.com/ -Addressed comments from Marc,  -Added an hypercall to retrieve version and number of supported target   impl CPUs.  -Added a check for KVM hypercall services availability. -Removed R-by tags from Connie & Sebastian as patches 2 & 4 are now  changed a bit. Please take another look. v3 --> v4(Minor updates) https://lore.kernel.org/kvmarm/20241209115311.40496-1-shameerali.kolothum.thodi@huawei.com/  -Changed MIDR/REVIDR to 64 bits based on feedback from Connie   and Marc(Patch #3).  -Added R-by tags from Sebastian (Thanks!). RFC v2 --> v3 https://lore.kernel.org/kvmarm/20241024094012.29452-1-shameerali.kolothum.thodi@huawei.com/  -Addressed comments from Oliver(Thanks!).  -Using implementation CPUs MIDR/REVIDR when it is set for   _midr_range() functions(Patch 1 & 3)  -New hypercall for retrieving implementation CPUs(Patch #2).  -Dropped RFC. RFC v1 --> RFCv2: https://lore.kernel.org/kvmarm/20241011075053.80540-1-shameerali.kolothum.thodi@huawei.com/  -Introduced hypercalls to retrieve target CPUs info from user space VMM.   see patch #1 for details.  -Patch #2 uses the hypercall to retrieve the target CPU info if any.  -Use the target CPUs MIDR/REVIDR in errata enablement. See patch #3. Background from v1: On ARM64 platforms most of the errata workarounds are based on CPU MIDR/REVIDR values and a number of these workarounds need to be implemented by the Guest kernel as well. This creates a problem when Guest needs to be migrated to a platform that differs in these MIDR/REVIDR values even if the VMM can come up with a common minimum feature list for the Guest using the recently introduced "Writable ID registers" support. (This is roughly based on a discussion I had with Marc and Oliver at KVM forum. Marc outlined his idea for a solution and this is an attempt to implement it. Thanks to both and I take all the blame if this is nowhere near what is intended/required) Shameer Kolothum (5): arm64: Modify _midr_range() functions to read MIDR/REVIDR internally KVM: arm64: Introduce hypercall support for retrieving target implementations KVM: arm64: Introduce KVM_REG_ARM_VENDOR_HYP_BMAP_2 smccc/kvm_guest: Enable errata based on implementation CPUs KVM: selftests: Add test for KVM_REG_ARM_VENDOR_HYP_BMAP_2 .../virt/kvm/arm/fw-pseudo-registers.rst | 15 ++++- Documentation/virt/kvm/arm/hypercalls.rst | 59 +++++++++++++++++ arch/arm64/include/asm/cputype.h | 50 ++++++++++----- arch/arm64/include/asm/hypervisor.h | 1 + arch/arm64/include/asm/kvm_host.h | 3 +- arch/arm64/include/asm/mmu.h | 3 +- arch/arm64/include/uapi/asm/kvm.h | 12 ++++ arch/arm64/kernel/cpu_errata.c | 37 ++++++++--- arch/arm64/kernel/cpufeature.c | 8 ++- arch/arm64/kernel/image-vars.h | 2 + arch/arm64/kernel/proton-pack.c | 17 +++-- arch/arm64/kvm/hypercalls.c | 13 ++++ arch/arm64/kvm/vgic/vgic-v3.c | 2 +- drivers/clocksource/arm_arch_timer.c | 2 +- drivers/firmware/smccc/kvm_guest.c | 63 +++++++++++++++++++ include/linux/arm-smccc.h | 15 +++++ tools/arch/arm64/include/uapi/asm/kvm.h | 12 ++++ .../selftests/kvm/arm64/get-reg-list.c | 1 + .../testing/selftests/kvm/arm64/hypercalls.c | 46 +++++++++++--- 19 files changed, 308 insertions(+), 53 deletions(-) Reviewed-by: Sebastian Ott