mbox series

[0/4] clk: imx8mp: fix parents of AUDIOMIX DSP/OCRAM_A

Message ID 20250217165718.74619-1-laurentiumihalcea111@gmail.com (mailing list archive)
Headers show
Series clk: imx8mp: fix parents of AUDIOMIX DSP/OCRAM_A | expand

Message

Laurentiu Mihalcea Feb. 17, 2025, 4:57 p.m. UTC
From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>

Correct the parent of the AUDIOMIX DSP and OCRAM_A clock gates by setting
it to AUDIO_AXI_CLK_ROOT, instead of AUDIO_AHB_CLK_ROOT. Additionally, set
the frequency of AUDIO_AXI_CLK_ROOT to 800MHz instead of the current
400MHz.

Laurentiu Mihalcea (4):
  dt-bindings: clock: imx8mp: add axi clock
  clk: clk-imx8mp-audiomix: fix dsp/ocram_a clock parents
  arm64: dts: imx8mp: add AUDIO_AXI_CLK_ROOT to AUDIOMIX block
  arm64: dts: imx8mp: change AUDIO_AXI_CLK_ROOT freq. to 800MHz

 .../devicetree/bindings/clock/imx8mp-audiomix.yaml     | 10 ++++++----
 arch/arm64/boot/dts/freescale/imx8mp.dtsi              |  7 ++++---
 drivers/clk/imx/clk-imx8mp-audiomix.c                  |  6 +++---
 3 files changed, 13 insertions(+), 10 deletions(-)

Comments

Iuliana Prodan Feb. 18, 2025, 11:25 a.m. UTC | #1
On 2/17/2025 6:57 PM, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>
> Correct the parent of the AUDIOMIX DSP and OCRAM_A clock gates by setting
> it to AUDIO_AXI_CLK_ROOT, instead of AUDIO_AHB_CLK_ROOT. Additionally, set
> the frequency of AUDIO_AXI_CLK_ROOT to 800MHz instead of the current
> 400MHz.
>
> Laurentiu Mihalcea (4):
>    dt-bindings: clock: imx8mp: add axi clock
>    clk: clk-imx8mp-audiomix: fix dsp/ocram_a clock parents
>    arm64: dts: imx8mp: add AUDIO_AXI_CLK_ROOT to AUDIOMIX block
>    arm64: dts: imx8mp: change AUDIO_AXI_CLK_ROOT freq. to 800MHz
>
>   .../devicetree/bindings/clock/imx8mp-audiomix.yaml     | 10 ++++++----
>   arch/arm64/boot/dts/freescale/imx8mp.dtsi              |  7 ++++---
>   drivers/clk/imx/clk-imx8mp-audiomix.c                  |  6 +++---
>   3 files changed, 13 insertions(+), 10 deletions(-)

For the series:
Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>

Thanks,
Iulia
Peng Fan Feb. 18, 2025, 1:43 p.m. UTC | #2
Hi Laurentiu,

> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: [PATCH 0/4] clk: imx8mp: fix parents of AUDIOMIX
> DSP/OCRAM_A
> 
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> 
> Correct the parent of the AUDIOMIX DSP and OCRAM_A clock gates by
> setting it to AUDIO_AXI_CLK_ROOT, instead of AUDIO_AHB_CLK_ROOT.
> Additionally, set the frequency of AUDIO_AXI_CLK_ROOT to 800MHz
> instead of the current 400MHz.

The patchset looks good to me, just one nit, 
Should fixes tag be added for the patchset?

Regards,
Peng.

> 
> Laurentiu Mihalcea (4):
>   dt-bindings: clock: imx8mp: add axi clock
>   clk: clk-imx8mp-audiomix: fix dsp/ocram_a clock parents
>   arm64: dts: imx8mp: add AUDIO_AXI_CLK_ROOT to AUDIOMIX block
>   arm64: dts: imx8mp: change AUDIO_AXI_CLK_ROOT freq. to 800MHz
> 
>  .../devicetree/bindings/clock/imx8mp-audiomix.yaml     | 10 ++++++---
> -
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi              |  7 ++++---
>  drivers/clk/imx/clk-imx8mp-audiomix.c                  |  6 +++---
>  3 files changed, 13 insertions(+), 10 deletions(-)
> 
> --
> 2.34.1
Laurentiu Mihalcea Feb. 19, 2025, 6:10 p.m. UTC | #3
On 2/18/25 08:43, Peng Fan (OSS) wrote:
> Hi Laurentiu,
>
>> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
>> Subject: [PATCH 0/4] clk: imx8mp: fix parents of AUDIOMIX
>> DSP/OCRAM_A
>>
>> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
>>
>> Correct the parent of the AUDIOMIX DSP and OCRAM_A clock gates by
>> setting it to AUDIO_AXI_CLK_ROOT, instead of AUDIO_AHB_CLK_ROOT.
>> Additionally, set the frequency of AUDIO_AXI_CLK_ROOT to 800MHz
>> instead of the current 400MHz.
> The patchset looks good to me, just one nit, 
> Should fixes tag be added for the patchset?


sure, will send a V2 with that