mbox series

[RFC,V6,0/2] firmware: arm_scmi: Misc Fixes

Message ID 20250226024338.3994701-1-quic_sibis@quicinc.com (mailing list archive)
Headers show
Series firmware: arm_scmi: Misc Fixes | expand

Message

Sibi Sankar Feb. 26, 2025, 2:43 a.m. UTC
The series addresses the kernel warnings reported by Johan at [1] and are
are required to X1E cpufreq device tree changes to land. It also proposes
addition of quirks to bypass a fw bug on X1E devices.

[1] - https://lore.kernel.org/lkml/ZoQjAWse2YxwyRJv@hovoldconsulting.com/

Duplicate levels:
arm-scmi arm-scmi.0.auto: Level 2976000 Power 218062 Latency 30us Ifreq 2976000 Index 10
arm-scmi arm-scmi.0.auto: Level 3206400 Power 264356 Latency 30us Ifreq 3206400 Index 11
arm-scmi arm-scmi.0.auto: Level 3417600 Power 314966 Latency 30us Ifreq 3417600 Index 12
arm-scmi arm-scmi.0.auto: Failed to add opps_by_lvl at 3417600 for NCC - ret:-16
arm-scmi arm-scmi.0.auto: Failed to add opps_by_lvl at 3417600 for NCC - ret:-16
arm-scmi arm-scmi.0.auto: Level 4012800 Power 528848 Latency 30us Ifreq 4012800 Index 15

^^ exist because SCP reports duplicate values for the highest sustainable
freq for perf domains 1 and 2. These are the only freqs that appear as
duplicates and will be fixed with a firmware update. FWIW the warnings
that we are addressing in this series will also get fixed by a firmware
update but they still have to land for devices already out in the wild.

V5:
* Drop all the patches that have already landed upstream and mark the
  series as RFC to get feedback on adding quirk support for the perf
  protocol.

V4:
* Rework debugfs node creation patch [Ulf/Dmitry]
* Reduce report level to dev_info and tag it with FW_BUG [Johan/Dmitry]
* Add cc stable and err logs to patch 1 commit message [Johan]

V3:
* Pick up R-b, T-b from the list.
* Pick up the updated patch from Cristian for skipping opps.
* Update device names only when a name collision occurs [Dmitry/Ulf]
* Drop Johan's T-b from "fix debugfs node creation failure"
* Move scmi_protocol_msg_check to the top [Sudeep]

V2:
* Include the fix for do_xfer timeout
* Include the fix debugfs node creation failure
* Include Cristian's fix for skipping opp duplication

V1:
* add missing MSG_SUPPORTS_FASTCHANNEL definition.

base: next-20250225

Sibi Sankar (2):
  firmware: arm_scmi: Ensure that the message-id supports fastchannel
  firmware: arm_scmi: Add quirk to bypass SCP fw bug

 drivers/firmware/arm_scmi/driver.c    | 75 +++++++++++++++------------
 drivers/firmware/arm_scmi/perf.c      | 30 ++++++++---
 drivers/firmware/arm_scmi/powercap.c  |  8 +--
 drivers/firmware/arm_scmi/protocols.h |  4 +-
 4 files changed, 72 insertions(+), 45 deletions(-)