From patchwork Wed Feb 26 07:48:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Choong Yong Liang X-Patchwork-Id: 13991695 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85DF5C021B8 for ; Wed, 26 Feb 2025 07:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=l5GQ0VB+U0qlLd8tcKJSdmALth7M2O7ILI6p1J26Zgo=; b=qDXs1SkARs7lOUrQCN7n8UQ7oE oHsbPR48YFy6+PM7mk9LSkUXiNAXcuCQvehctG8lmYNdxrkA68+YwciV+aXzpZiRflbYWfZIKX0uV b7VaEny6IRl5fYN+YHHdMHJfXP64CZmMOjVE9urguOcM3szaPEazw3deo3lJTvJ26e7bREr4rWS9P khNUD3MT8bxfQ8OATlHZM3CoF36nMNOfUBznyFmvTTWimjlsRvj1HmaQ2iW+TMdZTHEqpmO+xdEKU c+zBrh1veYbZzdQVvL2a/pJ0qb1XWzIdzUpLwJcQzobMjqX9l1gdq9Oc1acdaWNI/lAO82eAxP66k CIeM3wuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnCIS-00000002m59-43Wz; Wed, 26 Feb 2025 07:57:37 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnCBL-00000002jzd-1JDU for linux-arm-kernel@bombadil.infradead.org; Wed, 26 Feb 2025 07:50:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=l5GQ0VB+U0qlLd8tcKJSdmALth7M2O7ILI6p1J26Zgo=; b=IFffgAApoQ4bDgqmtZ7nkVpQPa M8oTLnoGDaKNsIlPmCbzWdR5NMUr0K73DgglMr4lD8eyWs4j5F9MUr0wAj9N1LsUR8/WrSb5bjoCr eHA+EtOw8HK7Mjj+oUZK/mAVprQi+vfVOH0OExe8ys6854Px+qDEYuzmVjpQaAOLANwbY64uOqMTN 7bGuvyyvlnUSZCHEFNJ+XHS5xfg0qL1G9Ue4mqbhVcml/ztEn74DNkQMfbP0ASkz2Ht0I3V6daG+A zzHcVC/ruo7mFv/riuQv1cLfc7ZbSlzd7LiQPszYJTe4FGXPbizPnvfE74I6cpLt5GrQ/Agy0l8MO 8KnOD7Rw==; Received: from mgamail.intel.com ([192.198.163.12]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnCBH-00000003Y2E-22WF for linux-arm-kernel@lists.infradead.org; Wed, 26 Feb 2025 07:50:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740556211; x=1772092211; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=8EIhzlM2gLlOBarT9qw4PuIMvUldVxztIuTe/SPq5U0=; b=mkGIzRybTdy6rpyvbUzRqp6mvjFbVp6OoNqveBrbjKV1zcLu+3BX1fie I7CGZYln7txUhozGG86CZHGmPCGMzMwb45wFuokNfU4Ec4pBDyDA9ev/F RGHCUg8bBHljp5jn//odtGxKvS0g2rTeUfhims2hu8OIC0LPWSZYxffqI VrQ9GUaSMnlXYLByMN77OKbvjPaOBRl60iJiSGfGTxVbiRwuSweOcuICo 7eZWoA9BALw/pVtht7seLr6r4BGlPXqKnhEznAqNiQNhLeTWS8PXRxqpB x/i3dAF+gdEvvEYaoxxJtPdXvD7KFl8mkYDcaDaJzJ1p67M3EOpJsI2Mh A==; X-CSE-ConnectionGUID: 5/OVk3MRQhGQhj+6ebnFiQ== X-CSE-MsgGUID: yshtGfTQRT6rdfSuPxSbXA== X-IronPort-AV: E=McAfee;i="6700,10204,11356"; a="45304965" X-IronPort-AV: E=Sophos;i="6.13,316,1732608000"; d="scan'208";a="45304965" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2025 23:49:55 -0800 X-CSE-ConnectionGUID: YViQm8QORYaoX5S3GrZdIw== X-CSE-MsgGUID: NzyRZrwHQuSYgVocsSPURQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="120742932" Received: from yongliang-ubuntu20-ilbpg12.png.intel.com ([10.88.227.39]) by fmviesa003.fm.intel.com with ESMTP; 25 Feb 2025 23:49:48 -0800 From: Choong Yong Liang To: Simon Horman , Jose Abreu , Jose Abreu , David E Box , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Rajneesh Bhardwaj , David E Box , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Jiawen Wu , Mengyuan Lou , Heiner Kallweit , Russell King , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Richard Cochran , Serge Semin Cc: x86@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH net-next v8 0/6] Enable SGMII and 2500BASEX interface mode switching for Intel platforms Date: Wed, 26 Feb 2025 15:48:31 +0800 Message-Id: <20250226074837.1679988-1-yong.liang.choong@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250226_075012_092280_B4D20442 X-CRM114-Status: GOOD ( 17.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org During the interface mode change, the 'phylink_major_config' function will be triggered in phylink. The modification of the following functions will support the switching between SGMII and 2500BASE-X interface modes for the Intel platform: - xpcs_switch_interface_mode: Re-initiates clause 37 auto-negotiation for the SGMII interface mode to perform auto-negotiation. - mac_finish: Configures the SerDes according to the interface mode. With the above changes, the code will work as follows during the interface mode change. The PCS will reconfigure according to the pcs_neg_mode and the selected interface mode. Then, the MAC driver will perform SerDes configuration in 'mac_finish' based on the selected interface mode. During the SerDes configuration, the selected interface mode will identify TSN lane registers from FIA and then send IPC commands to the Power Management Controller (PMC) through the PMC driver/API. The PMC will act as a proxy to program the PLL registers. Change log: v1 -> v2: - Add static to pmc_lpm_modes declaration - Add cur_link_an_mode to the kernel doc - Combine 2 commits i.e. "stmmac: intel: Separate driver_data of ADL-N from TGL" and "net: stmmac: Add 1G/2.5G auto-negotiation support for ADL-N" into 1 commit. v2 -> v3: - Create `pmc_ipc.c` file for `intel_pmc_ipc()` function and allocate the file in `arch/x86/platform/intel/` directory. - Update phylink's AN mode during phy interface change and not exposing phylink's AN mode into phylib. v3 -> v4: - Introduce `allow_switch_interface` flag to have all ethtool link modes that are supported and advertised will be published. - Introduce `mac_get_pcs_neg_mode` function that selects the PCS negotiation mode according to the interface mode. - Remove pcs-xpcs.c changes and handle pcs during `mac_select_pcs` function - Configure SerDes base on the interface on `mac_finish` function. v4 -> v5: - remove 'allow_switch_interface' related patches. - remove 'mac_select_pcs' related patches. - add a soft reset according to XPCS datasheet for re-initiate Clause 37 auto-negotiation when switching to SGMII interface mode. v5 -> v6: - Remove 'mac_get_pcs_neg_mode' related patches. The pcs_neg_mode is properly handled by the 'net: add negotiation of in-band capabilities' patch series: https://patchwork.kernel.org/project/netdevbpf/cover/Z08kCwxdkU4n2V6x@shell.armlinux.org.uk/ - Using act_link_an_mode to determine PHY, as cfg_link_an_mode was not updated for the 2500BASE-X interface mode, caused a failure to link up. - Clean up and standardize the interface mode switch for xpcs. v6 -> v7: - Remove the "net: phylink: use act_link_an_mode to determine PHY" patch. - Use pl->link_interface in phylink_expects_phy(). - Remove priv->plat->serdes_powerup in intel_tsn_lane_is_available() as it is always true. - Refactor the code in intel_config_serdes(). - Rename intel_config_serdes() to intel_mac_finish() with an AN mode parameter. - Define the magic number as "max_fia_regs". - Store the pointer and the number of elements in the platform info structure. - Move the arrays to the C file. v7 -> v8: - Move xpcs_switch_interface_mode() into xpcs_pre_config(). - Move the "stmmac: intel: interface switching support for EHL platform" commit into "stmmac: intel: configure SerDes according to the interface mode" to resolve the "defined but not used" error. - Changes for the "arch: x86: add IPC mailbox accessor function and add SoC register access" commit: - Rephrase the second bullet in the patch description. - Remove 'config INTEL_PMC_IPC' from Kconfig, as discussed. - Remove the authors from intel_pmc_ipc.h. - Define VALID_IPC_RESPONSE for package.count. - Update the copyright year to 2025. - Create struct pmc_ipc_rbuf. - Update the function description for intel_pmc_ipc(). v1: https://patchwork.kernel.org/project/netdevbpf/cover/20230622041905.629430-1-yong.liang.choong@linux.intel.com/ v2: https://patchwork.kernel.org/project/netdevbpf/cover/20230804084527.2082302-1-yong.liang.choong@linux.intel.com/ v3: https://patchwork.kernel.org/project/netdevbpf/cover/20230921121946.3025771-1-yong.liang.choong@linux.intel.com/ v4: https://patchwork.kernel.org/project/netdevbpf/cover/20240129130253.1400707-1-yong.liang.choong@linux.intel.com/ v5: https://patchwork.kernel.org/project/netdevbpf/cover/20240215030500.3067426-1-yong.liang.choong@linux.intel.com/ v6: https://patchwork.kernel.org/project/netdevbpf/cover/20250204061020.1199124-1-yong.liang.choong@linux.intel.com/ v7: https://patchwork.kernel.org/project/netdevbpf/cover/20250206131859.2960543-1-yong.liang.choong@linux.intel.com/ Choong Yong Liang (5): net: phylink: use pl->link_interface in phylink_expects_phy() net: pcs: xpcs: re-initiate clause 37 Auto-negotiation stmmac: intel: configure SerDes according to the interface mode net: stmmac: configure SerDes on mac_finish stmmac: intel: interface switching support for ADL-N platform David E. Box (1): arch: x86: add IPC mailbox accessor function and add SoC register access MAINTAINERS | 1 + drivers/net/ethernet/stmicro/stmmac/Kconfig | 1 + .../net/ethernet/stmicro/stmmac/dwmac-intel.c | 231 +++++++++++++++++- .../net/ethernet/stmicro/stmmac/dwmac-intel.h | 29 +++ .../net/ethernet/stmicro/stmmac/stmmac_main.c | 13 + drivers/net/pcs/pcs-xpcs-wx.c | 4 +- drivers/net/pcs/pcs-xpcs.c | 29 ++- drivers/net/phy/phylink.c | 2 +- .../linux/platform_data/x86/intel_pmc_ipc.h | 94 +++++++ include/linux/stmmac.h | 4 + 10 files changed, 394 insertions(+), 14 deletions(-) create mode 100644 include/linux/platform_data/x86/intel_pmc_ipc.h