| Message ID | 20250417-iio-more-timestamp-alignment-v1-0-eafac1e22318@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio: more timestamp alignment | expand |
On Thu, Apr 17, 2025 at 11:52:32AM -0500, David Lechner wrote: > Wile reviewing [1], I noticed a few more cases where we can use > aligned_s64 or need __aligned(8) on data structures used with > iio_push_to_buffers_with_timestamp(). > > [1]: https://lore.kernel.org/linux-iio/20250413103443.2420727-1-jic23@kernel.org/ Link: URL [1] :-) This will help to maintainer with b4 as it manages tags. > Signed-off-by: David Lechner <dlechner@baylibre.com> Reviewed-by: Andy Shevchenko <andy@kernel.org> for non-commented patches.
On 4/17/25 12:01 PM, Andy Shevchenko wrote: > On Thu, Apr 17, 2025 at 11:52:32AM -0500, David Lechner wrote: >> Wile reviewing [1], I noticed a few more cases where we can use >> aligned_s64 or need __aligned(8) on data structures used with >> iio_push_to_buffers_with_timestamp(). >> >> [1]: https://lore.kernel.org/linux-iio/20250413103443.2420727-1-jic23@kernel.org/ > > > Link: URL [1] :-) > > This will help to maintainer with b4 as it manages tags. In this case, I don't want b4 to add this Link: to all patches, it is just context for the cover letter and not so useful long-term. > >> Signed-off-by: David Lechner <dlechner@baylibre.com> > > Reviewed-by: Andy Shevchenko <andy@kernel.org> > for non-commented patches. >
On Thu, Apr 17, 2025 at 12:16:53PM -0500, David Lechner wrote: > On 4/17/25 12:01 PM, Andy Shevchenko wrote: > > On Thu, Apr 17, 2025 at 11:52:32AM -0500, David Lechner wrote: > >> Wile reviewing [1], I noticed a few more cases where we can use > >> aligned_s64 or need __aligned(8) on data structures used with > >> iio_push_to_buffers_with_timestamp(). > >> > >> [1]: https://lore.kernel.org/linux-iio/20250413103443.2420727-1-jic23@kernel.org/ > > > > > > Link: URL [1] :-) > > > > This will help to maintainer with b4 as it manages tags. > > In this case, I don't want b4 to add this Link: to all patches, it is just > context for the cover letter and not so useful long-term. Then tell it to not do that. OTOH I dunno if it has a special filters for cover letter. > > Reviewed-by: Andy Shevchenko <andy@kernel.org> > > for non-commented patches.
On Thu, 17 Apr 2025 11:52:32 -0500 David Lechner <dlechner@baylibre.com> wrote: > Wile reviewing [1], I noticed a few more cases where we can use > aligned_s64 or need __aligned(8) on data structures used with > iio_push_to_buffers_with_timestamp(). > > [1]: https://lore.kernel.org/linux-iio/20250413103443.2420727-1-jic23@kernel.org/ > > Signed-off-by: David Lechner <dlechner@baylibre.com> I have a bunch of these in a 'too hard before sending that patch pile' as well. Hopefully you've covered many of those :) There were definitely more bugs than I expected to see when I started that effort! I thought we'd tracked all these down long ago :( Jonathan > --- > David Lechner (8): > iio: adc: dln2-adc: use aligned_s64 for timestamp > iio: adc: mt6360-adc: use aligned_s64 for timestamp > iio: addac: ad74413r: use aligned_s64 for timestamp > iio: chemical: pms7003: use aligned_s64 for timestamp > iio: chemical: sps30: use aligned_s64 for timestamp > iio: imu: adis16550: align buffers for timestamp > iio: imu: inv_mpu6050: align buffer for timestamp > iio: pressure: mprls0025pa: use aligned_s64 for timestamp > > drivers/iio/accel/bmc150-accel.h | 2 +- > drivers/iio/adc/dln2-adc.c | 2 +- > drivers/iio/adc/mt6360-adc.c | 4 ++-- > drivers/iio/addac/ad74413r.c | 5 +++-- > drivers/iio/chemical/pms7003.c | 5 +++-- > drivers/iio/chemical/sps30.c | 2 +- > drivers/iio/imu/adis16550.c | 2 +- > drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 2 +- > drivers/iio/pressure/mprls0025pa.h | 2 +- > 9 files changed, 14 insertions(+), 12 deletions(-) > --- > base-commit: 3159d40a2ca0ae14e69e1cae8b12f04c933d0445 > change-id: 20250416-iio-more-timestamp-alignment-6c6c6a87ebda > > Best regards,
On Thu, 17 Apr 2025 20:01:13 +0300 Andy Shevchenko <andy@kernel.org> wrote: > On Thu, Apr 17, 2025 at 11:52:32AM -0500, David Lechner wrote: > > Wile reviewing [1], I noticed a few more cases where we can use > > aligned_s64 or need __aligned(8) on data structures used with > > iio_push_to_buffers_with_timestamp(). > > > > [1]: https://lore.kernel.org/linux-iio/20250413103443.2420727-1-jic23@kernel.org/ > > > Link: URL [1] :-) In a cover letter? Not sure we care. In general agree though. > > This will help to maintainer with b4 as it manages tags. > > > Signed-off-by: David Lechner <dlechner@baylibre.com> Also no need to sign off on cover letters as they don't end up in git. > > Reviewed-by: Andy Shevchenko <andy@kernel.org> > for non-commented patches. >
On Thu, Apr 17, 2025 at 06:47:16PM +0100, Jonathan Cameron wrote: > On Thu, 17 Apr 2025 20:01:13 +0300 > Andy Shevchenko <andy@kernel.org> wrote: > > On Thu, Apr 17, 2025 at 11:52:32AM -0500, David Lechner wrote: ... > > > Signed-off-by: David Lechner <dlechner@baylibre.com> > Also no need to sign off on cover letters as they don't end up in git. It depends if you use `b4 shazam` or not. I like that feature.
On Thu, 17 Apr 2025 21:05:40 +0300 Andy Shevchenko <andy@kernel.org> wrote: > On Thu, Apr 17, 2025 at 06:47:16PM +0100, Jonathan Cameron wrote: > > On Thu, 17 Apr 2025 20:01:13 +0300 > > Andy Shevchenko <andy@kernel.org> wrote: > > > On Thu, Apr 17, 2025 at 11:52:32AM -0500, David Lechner wrote: > > ... > > > > > Signed-off-by: David Lechner <dlechner@baylibre.com> > > Also no need to sign off on cover letters as they don't end up in git. > > It depends if you use `b4 shazam` or not. I like that feature. > Definitely don't add what you did here though in a reply! That adds: + Link: URL [1] :-)
On Thu, 17 Apr 2025 11:52:32 -0500 David Lechner <dlechner@baylibre.com> wrote: > Wile reviewing [1], I noticed a few more cases where we can use > aligned_s64 or need __aligned(8) on data structures used with > iio_push_to_buffers_with_timestamp(). > > [1]: https://lore.kernel.org/linux-iio/20250413103443.2420727-1-jic23@kernel.org/ I picked up via one or other branch all but 1 (as that was already fixed), 6 and 8 Jonathan > > Signed-off-by: David Lechner <dlechner@baylibre.com> > --- > David Lechner (8): > iio: adc: dln2-adc: use aligned_s64 for timestamp > iio: adc: mt6360-adc: use aligned_s64 for timestamp > iio: addac: ad74413r: use aligned_s64 for timestamp > iio: chemical: pms7003: use aligned_s64 for timestamp > iio: chemical: sps30: use aligned_s64 for timestamp > iio: imu: adis16550: align buffers for timestamp > iio: imu: inv_mpu6050: align buffer for timestamp > iio: pressure: mprls0025pa: use aligned_s64 for timestamp > > drivers/iio/accel/bmc150-accel.h | 2 +- > drivers/iio/adc/dln2-adc.c | 2 +- > drivers/iio/adc/mt6360-adc.c | 4 ++-- > drivers/iio/addac/ad74413r.c | 5 +++-- > drivers/iio/chemical/pms7003.c | 5 +++-- > drivers/iio/chemical/sps30.c | 2 +- > drivers/iio/imu/adis16550.c | 2 +- > drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 2 +- > drivers/iio/pressure/mprls0025pa.h | 2 +- > 9 files changed, 14 insertions(+), 12 deletions(-) > --- > base-commit: 3159d40a2ca0ae14e69e1cae8b12f04c933d0445 > change-id: 20250416-iio-more-timestamp-alignment-6c6c6a87ebda > > Best regards,
Wile reviewing [1], I noticed a few more cases where we can use aligned_s64 or need __aligned(8) on data structures used with iio_push_to_buffers_with_timestamp(). [1]: https://lore.kernel.org/linux-iio/20250413103443.2420727-1-jic23@kernel.org/ Signed-off-by: David Lechner <dlechner@baylibre.com> --- David Lechner (8): iio: adc: dln2-adc: use aligned_s64 for timestamp iio: adc: mt6360-adc: use aligned_s64 for timestamp iio: addac: ad74413r: use aligned_s64 for timestamp iio: chemical: pms7003: use aligned_s64 for timestamp iio: chemical: sps30: use aligned_s64 for timestamp iio: imu: adis16550: align buffers for timestamp iio: imu: inv_mpu6050: align buffer for timestamp iio: pressure: mprls0025pa: use aligned_s64 for timestamp drivers/iio/accel/bmc150-accel.h | 2 +- drivers/iio/adc/dln2-adc.c | 2 +- drivers/iio/adc/mt6360-adc.c | 4 ++-- drivers/iio/addac/ad74413r.c | 5 +++-- drivers/iio/chemical/pms7003.c | 5 +++-- drivers/iio/chemical/sps30.c | 2 +- drivers/iio/imu/adis16550.c | 2 +- drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 2 +- drivers/iio/pressure/mprls0025pa.h | 2 +- 9 files changed, 14 insertions(+), 12 deletions(-) --- base-commit: 3159d40a2ca0ae14e69e1cae8b12f04c933d0445 change-id: 20250416-iio-more-timestamp-alignment-6c6c6a87ebda Best regards,