From patchwork Tue May 23 17:19:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Rosin X-Patchwork-Id: 13252710 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90E26C77B75 for ; Tue, 23 May 2023 17:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Subject:From:To:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WF0qd+lgHAOoThAdWqErFpfm92OZ19AqVcrs0pk9PjY=; b=txyV4wGX7ifteY 3OW2rMr9PCxo9FAIJVO0yKRDki1I7rm3WusyzPkynKhNkAFaac/xRkS5FLh6E3hmByYC2Z90d3t6v cg/QRX9++3025fAo25yWuha1J4h15lwQf2q6p1cc2cPzzpn+Nuyi4IKxTEpgE1fINJ6A0oaJe2+hc XOKphQ7yedmiBrtoGnLzmHhDIIiEcpKLmje3a51+K0MvjUy0VqLyivhpjBx+KmPovsrMzllCAPk6R C/rS9N9UQMAsRUj5FIy4GWpBSv//7iRnNR3vhFbFxzFRj/u9gm22Oxu1Xvn9zaZqwwgf6cUex8a8s SHt076zAUow03coCdhDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1VgA-00Aw80-2z; Tue, 23 May 2023 17:20:10 +0000 Received: from mail-db3eur04on0731.outbound.protection.outlook.com ([2a01:111:f400:fe0c::731] helo=EUR04-DB3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1Vg7-00Aw6w-1I for linux-arm-kernel@lists.infradead.org; Tue, 23 May 2023 17:20:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bdGpohLVXxGeNmgh+OX2GWf7ye3CFNX+EtxW1tw4wcR1uKEecJ8a5xdsupXkiL67h+6ZhPb97dfYX2Bb394CykwjC1/XRPZzcAF8sCKMH9uprEdJ+lprOH9kqKFXwg0gvart6iVcm6gfw4vUyCgK52r2O6OcbXjJ5zq3iKnwhmFZphU7aYSbZ+5WypTvzh9QrP/ijfiWvVIQeEO41EBpU3idLaVxLPSd7vLibs6pALj+U1dIvqApHHFbov9UcZYf9NG7TLB9BHHteW+ekmD9aSeuKKMb8grZ8r8MX9HeMef3KXh4PL7LR2vITiAEKQAKUTpM0y5cpFO8bEyF68E3tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QrDyClST2Z6WcJ2Z4d9cXRz3h8gVFkK2c5hLwxNXXPA=; b=BVrOZuAhbiqaPHzYfGPuoXcxfjO201t/yyqfnnX+3vk/oh13rMZlfwd/jPCk+29R5iEj/Q+gmV/zSu3dtW6cZDYcQ3t8l7fDxU0YYqsO3W0Y8uvWSWSzW9U7ShgJ8bB+C0RY9WI6oss6uSUrBiAAvu/HtzgIj2VrRIpHHpn5LyqK5c+XaR1dqZI7abkVSeUO9I5h/Yj8ClJ1W33CXoKHcCnaI0zN2OtpSzpaQ+7Zbv/hLIS+BjdEIOA97AAWnYjlNBEKYLvYoXym1rs+EpCnhmDs29WcP95mmi8UlgFsnIHSnEKW3TTB1Ym/7lioCj+NUO29Oo11EYQmCUFKNJO4bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=axentia.se; dmarc=pass action=none header.from=axentia.se; dkim=pass header.d=axentia.se; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axentia.se; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QrDyClST2Z6WcJ2Z4d9cXRz3h8gVFkK2c5hLwxNXXPA=; b=YXxL3Rt0mbbOl2/tYFoJI9KnlR/AbBewlDuy88B4nwWm+8Mqbfwq1GdEZWUIruW4+MBdg/Mi+Cay1ZoAZvbDdCbhvkreSfP/0AiCbh0SOmqiPVxED7QMCFtm243KpZncBAaRfFS+qE834olLeDTy+i0p4GXEC5FJMniNNpd3feY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=axentia.se; Received: from AM0PR02MB4436.eurprd02.prod.outlook.com (2603:10a6:208:ed::15) by PAVPR02MB9205.eurprd02.prod.outlook.com (2603:10a6:102:320::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 17:20:02 +0000 Received: from AM0PR02MB4436.eurprd02.prod.outlook.com ([fe80::681f:7dcc:3f6c:3b36]) by AM0PR02MB4436.eurprd02.prod.outlook.com ([fe80::681f:7dcc:3f6c:3b36%5]) with mapi id 15.20.6411.028; Tue, 23 May 2023 17:20:01 +0000 Message-ID: <221d19e2-6b92-7f38-7d8a-a730f54c33ea@axentia.se> Date: Tue, 23 May 2023 19:19:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Content-Language: sv-SE To: LKML From: Peter Rosin Subject: [PATCH v2 0/2] dmaengine: at_hdmac: Regression fix and cleanup X-ClientProxiedBy: MM0P280CA0081.SWEP280.PROD.OUTLOOK.COM (2603:10a6:190:8::31) To AM0PR02MB4436.eurprd02.prod.outlook.com (2603:10a6:208:ed::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM0PR02MB4436:EE_|PAVPR02MB9205:EE_ X-MS-Office365-Filtering-Correlation-Id: 55af58ac-8f68-4da1-67f3-08db5bb1f127 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m2+ICWCxGSaiA6aLdRSqybVi8bwWsA8HunGn506Shva76PD0Ijm9q+vobB1sXQbmnwK2aBetD/AmO88iysVsSl90bN2wO5+/ewqFDXkndpBo+zhNmFoFzbb3l3woClrQXjku2uIUTaS1rOcJnAN+74DTjZG2gcJBs54nw7ifCE6pxHItd76P0ATzORMPpG4ThlxDPgLuvlwYdkG2mjLhoH/3qfkMHeasGhhAPCrY5IuW1hO9XuMTzqxoeig4/YsGwP12ASGwcrM9DY18EakpHd8L5/BX4VZS4zr62oJQ3uFDAkPTJkaWr/iqVWwjKdCJmbG3NR4dEdUuYuT4W7wskrFR0uShs4zdFdxIiJqK8F5S3kzVSY3qWcZq4ERfnvaOpqQKYQ36l9Wu9IJbkKjCe5hDjNXpAp64S5XNxPJz//RqWs28QP2i/zQVJUE2TPZ1c6BbaFN5tO+LlBBCrFd4eg4xLMqwW5Vaooa0OfIRWif3J5zN5DzwgBi8qkputmOZagyshthuDd4eXr/1dvD/g6Uff61tnbPQUnPNqVJ2R+/DLj8BmH+dg9WpItx7F3lsBQbvlD6wLFa/Uh0+Q2JrSvBMh7TrPGX6nr2lljF9qFX0+U+8mTusuFI423e15Czd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR02MB4436.eurprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39840400004)(376002)(396003)(136003)(366004)(451199021)(8936002)(8676002)(5660300002)(186003)(83380400001)(26005)(6506007)(6512007)(86362001)(31696002)(2616005)(38100700002)(41300700001)(6486002)(966005)(66476007)(66556008)(66946007)(6916009)(4326008)(36756003)(478600001)(316002)(54906003)(2906002)(4744005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?yEBosJWn6jIOKTQHgd6DhGXF5JX7?= =?utf-8?q?wzz1JFw8o6dwCq3A2vmmBOwMYjouKEi8dkrEisuXwL4UWEMqZA5PVvNmEU6DDFRgW?= =?utf-8?q?eL6ofHuIDWHhL8bHy7xgemEA97A659yv5hjxadNvkE8lG0JZ5onj1/P7YU9Zl7fmd?= =?utf-8?q?xvT0UHwZZKUALc3GK9WiFjl6LaDHThd53ovfSevQruEffSqf/MhsYI5X7zqw0wX0g?= =?utf-8?q?ODMahZ1cb1V2r3r84CQ6cke25+f2UPgjo4CmlFWDPwdgWqZGw2F/lpxAQN138/QKR?= =?utf-8?q?ZeAh1J8WnEUHwUpi7yOe68gHSVtfxsTA+/pautqD893X4GiIwmdWRpALCzIztTnOL?= =?utf-8?q?uxnQkYt9UIAMWOzhlHcsRbDbYFavlTjgX+G4sTaDVKx8cGLNvsbbJx4rY65LL8t0i?= =?utf-8?q?fu4WYbLZoHeM7ucy2k4oH0q65+3+/C8VWPVw29tZPH4bs4CD8hOPQE+VO5hsY6VCx?= =?utf-8?q?PqTfuxQABxOCqASebIAfZDeUMpfgc00xWaXsA1AvwhJwy8dg9veUZ17NUTv51mvg7?= =?utf-8?q?35erj7Fu0DiXZUuAwIJ2dD216NPj9Z1qB5bTyxGmqFipr5gClDowsk5cAaXZaviUv?= =?utf-8?q?3PU0mqW/hhAeauWWIFegljoqfo3VMcxLLNYTNUWhaNsytjjr8nO/y9uUgjeVeO3Q8?= =?utf-8?q?/B6aBDnzR/d4BSRkiY0tsHRtLu8YuQ/4+mo3Vrs9suYXI6FNWpRHekRzdyftYQclK?= =?utf-8?q?KsmV0tbncORqc6iC1Y/LGGVyS/S4YVAfqEkA4hgfh5V5h5QcDWAM39VkIUT6K7t2m?= =?utf-8?q?jqgRbR5cLiXajlcTpKH/TKG+SDMu2U7dGSUZ5D3ZjevXeBRg9gdB+y/Wic6vXhO6C?= =?utf-8?q?LOf475GrrhxoaYS05/y4qA1ivcvXd4QrQ0ZsvaiaeZEIrhn25w5Ko7Huz0aPaHQDP?= =?utf-8?q?7R1NzoLikls7akC0hmkBlJEw8LNzmBhpCL1fQdujXGVYEiyaRcY5w7gWh0WewHJza?= =?utf-8?q?X+fpAwXTFWn8K3MxcM0Y/fOcZEyns+KQdLVCM65W0nKmSGBMX9g+g6ZK2bvFi9cBn?= =?utf-8?q?wurKFZkgwH/P4gfXjPimSpwx6N38Nc87zCU+Rv5ROblp+m1JMBpfxXQQrMH49dsxs?= =?utf-8?q?D+oMifwK9jrSxytJX+CuY0J8SWzS0n68Y3XyBEXVrH3dkvwEhDI9HC5PSkp2orx1t?= =?utf-8?q?rcrDB9V0pHjlJbf3Na+NQvi3YFFk3ZM9AgUGBngbSkyFasGwGlqn9nPhz8dL+ymfi?= =?utf-8?q?lz6KVFZbptyZXwi5w3QXOSMfHKx08vEhFdIC/J63J0HCVsmBGGUu7j9i62gaiQuKc?= =?utf-8?q?yxrcQJLYNlzNVoLmpCpL1ZwRzZdd3JrexQT1BoR6NL0PVpXd8sN87it9cuwek/n/w?= =?utf-8?q?6adaJpzw4eKvnacKuWKaExhfY6Q01Nd8Hgz81PYDRLl9Kj2erW0Rnd47Jz/xyS5fV?= =?utf-8?q?/fntT9LsrcKMEqk3BYkqWyK6CtqZLf9B7AzshV5FJDQM16cSCSE09RXz7D8RcF8k7?= =?utf-8?q?By34QydtO1do3V4eKLqpjMZBzRC79llPPkjGUc28RMDRuiBWddPhqVHWdiGDbXMji?= =?utf-8?q?2PUJftRTlaFg?= X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-Network-Message-Id: 55af58ac-8f68-4da1-67f3-08db5bb1f127 X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 17:20:01.8078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vzC1Wqg325Tn2Mrlo3FY3b9N4FT41zufJemk7VWioZgPFvbm8/R3TaDlAZV+OEfa X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR02MB9205 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230523_102008_107013_F0EF90C8 X-CRM114-Status: UNSURE ( 7.32 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tudor Ambarus , Ludovic Desroches , "stable@vger.kernel.org" , Vinod Koul , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! I found a regression in DMA handling on one of our SAMA5D3 boards. While combing through the regressing commit, a found two unrelated strange things. The first is the actually problematic change. The second is a number of suspect defines, that I fail to see how they can ever do any good. Cheers, Peter Changes since v1 [1], after comments from Tudor Ambarus: Patch 1/2: - Don't convert to inline functions. - Cc stable Patch 2/2: - Extend the field instead of killing "too big" field values. - Add Fixes and R-b tags. - Cc stable [1] https://lore.kernel.org/lkml/dc4834cb-fadf-17a5-fbc7-cf500db88f20@axentia.se/ Peter Rosin (2): dmaengine: at_hdmac: Repair bitfield macros for peripheral ID handling dmaengine: at_hdmac: Extend the Flow Controller bitfield to three bits drivers/dma/at_hdmac.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)